You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/services
Lunny Xiao 5f82ead13c
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.

## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:

Firstly, there are temporary repositories which do not change:

```go
git.OpenRepository(ctx, diskPath)
```

Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:

```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```

Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.

## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.

---------

Co-authored-by: delvh <dev.lh@web.de>
1 year ago
..
actions Simplify how git repositories are opened (#28937) 1 year ago
agit Adjust object format interface (#28469) 1 year ago
asymkey Simplify how git repositories are opened (#28937) 1 year ago
attachment Even more `db.DefaultContext` refactor (#27352) 1 year ago
auth Fix SSPI user creation (#28948) 1 year ago
automerge Simplify how git repositories are opened (#28937) 1 year ago
context Another round of `db.DefaultContext` refactor (#27103) 1 year ago
convert Simplify how git repositories are opened (#28937) 1 year ago
cron Update go dependencies (#28518) 1 year ago
doctor Simplify how git repositories are opened (#28937) 1 year ago
externalaccount Final round of `db.DefaultContext` refactor (#27587) 1 year ago
feed More `db.DefaultContext` refactor (#27265) 1 year ago
forms Remove trust model selection from repository creation on web page because it can be changed in settings later (#28814) 1 year ago
gitdiff Add option to disable ambiguous unicode characters detection (#28454) 1 year ago
indexer Fix missing issue search index update when changing status (#28325) 1 year ago
issue Remove deadcode under models/issues (#28536) 1 year ago
lfs Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (#28220) 1 year ago
mailer Rework markup link rendering (#26745) 1 year ago
markup make writing main test easier (#27270) 1 year ago
migrations Simplify how git repositories are opened (#28937) 1 year ago
mirror Simplify how git repositories are opened (#28937) 1 year ago
notify Update status and code index after changing the default branch (#27018) 1 year ago
org Delete repos of org when purge delete user (#27273) 1 year ago
packages Fix some RPM registry flaws (#28782) 1 year ago
pull Simplify how git repositories are opened (#28937) 1 year ago
release Simplify how git repositories are opened (#28937) 1 year ago
repository Simplify how git repositories are opened (#28937) 1 year ago
secrets Refactor deletion (#28610) 1 year ago
task Fix incorrect ctx usage in defer function (#27740) 1 year ago
uinotification Penultimate round of `db.DefaultContext` refactor (#27414) 1 year ago
user Forbid removing the last admin user (#28337) 1 year ago
webhook Abstract hash function usage (#28138) 1 year ago
wiki Simplify how git repositories are opened (#28937) 1 year ago