You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/services/convert
Lunny Xiao 5f82ead13c
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.

## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:

Firstly, there are temporary repositories which do not change:

```go
git.OpenRepository(ctx, diskPath)
```

Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:

```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```

Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.

## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.

---------

Co-authored-by: delvh <dev.lh@web.de>
1 year ago
..
activity.go For API attachments, use API URL (#25639) 2 years ago
attachment.go Fix attachment download bug (#27486) 1 year ago
convert.go Add branch protection setting for ignoring stale approvals (#28498) 1 year ago
git_commit.go Even more `db.DefaultContext` refactor (#27352) 2 years ago
git_commit_test.go Adjust object format interface (#28469) 1 year ago
issue.go Final round of `db.DefaultContext` refactor (#27587) 1 year ago
issue_comment.go Even more `db.DefaultContext` refactor (#27352) 2 years ago
issue_test.go Move `convert` package to services (#22264) 2 years ago
main_test.go make writing main test easier (#27270) 2 years ago
mirror.go Even more `db.DefaultContext` refactor (#27352) 2 years ago
notification.go Even more `db.DefaultContext` refactor (#27352) 2 years ago
package.go Fix package webhook (#27839) 1 year ago
pull.go Simplify how git repositories are opened (#28937) 1 year ago
pull_review.go Fix `convert.ToTeams` on empty input (#28426) 1 year ago
pull_test.go Fix `Permission` in API returned repository struct (#25388) 2 years ago
release.go add Upload URL to release API (#26663) 2 years ago
release_test.go add Upload URL to release API (#26663) 2 years ago
repository.go Move more functions to db.Find (#28419) 1 year ago
secret.go feat: implement organization secret creation API (#26566) 2 years ago
status.go refactor improve NoBetterThan (#26126) 2 years ago
user.go Fix API leaking Usermail if not logged in (#25097) 2 years ago
user_test.go Add context cache as a request level cache (#22294) 2 years ago
utils.go Move `convert` package to services (#22264) 2 years ago
utils_test.go Rewrite queue (#24505) 2 years ago
wiki.go Make wiki title supports dashes and improve wiki name related features (#24143) 2 years ago