You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/services/repository
Lunny Xiao 5f82ead13c
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.

## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:

Firstly, there are temporary repositories which do not change:

```go
git.OpenRepository(ctx, diskPath)
```

Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:

```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```

Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.

## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.

---------

Co-authored-by: delvh <dev.lh@web.de>
1 year ago
..
archiver Simplify how git repositories are opened (#28937) 1 year ago
files Simplify how git repositories are opened (#28937) 1 year ago
adopt.go Simplify how git repositories are opened (#28937) 1 year ago
adopt_test.go
avatar.go
avatar_test.go
branch.go Simplify how git repositories are opened (#28937) 1 year ago
cache.go Always enable caches (#28527) 1 year ago
check.go Adjust object format interface (#28469) 1 year ago
collaboration.go Fix `DeleteCollaboration` transaction behaviour (#28886) 1 year ago
collaboration_test.go
commit.go
create.go Simplify how git repositories are opened (#28937) 1 year ago
create_test.go Remove unnecessary parameter (#27671) 1 year ago
delete.go Use db.Find instead of writing methods for every object (#28084) 1 year ago
delete_test.go Delete repos of org when purge delete user (#27273) 1 year ago
fork.go Simplify how git repositories are opened (#28937) 1 year ago
fork_test.go
hooks.go Simplify how git repositories are opened (#28937) 1 year ago
lfs.go Simplify how git repositories are opened (#28937) 1 year ago
lfs_test.go Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (#28220) 1 year ago
main_test.go make writing main test easier (#27270) 1 year ago
push.go Simplify how git repositories are opened (#28937) 1 year ago
repository.go Remove unnecessary parameter (#27671) 1 year ago
repository_test.go
review.go
review_test.go
setting.go Fix schedule tasks bugs (#28691) 1 year ago
template.go
transfer.go
transfer_test.go