refactor(dataset): protect delete invocation only

8 years ago · 16b14888b7
parent 06c9cfbb47
commit 16b14888b7
1 changed files with 4 additions and 2 deletions
--- a/src/modules/dataset.ts
+++ b/src/modules/dataset.ts
@ -19,8 +19,10 @@ function updateDataset(oldVnode: VNode, vnode: VNode): void {

  for (key in oldDataset) {
    if (!dataset[key]) {
-      if (d && d[key]) {
-        delete d[key];
+      if (d) {
+        if (key in d) {
+          delete d[key];
+        }
      } else {
        elm.removeAttribute('data-' + key.replace(CAPS_REGEX, '-$&').toLowerCase());
      }