From 16b14888b7524005acc6c741d7da0700b94d292f Mon Sep 17 00:00:00 2001 From: Churchill Lee Date: Sat, 1 Jul 2017 12:22:18 +0800 Subject: [PATCH] refactor(dataset): protect delete invocation only --- src/modules/dataset.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/modules/dataset.ts b/src/modules/dataset.ts index d9070ea..a49204b 100755 --- a/src/modules/dataset.ts +++ b/src/modules/dataset.ts @@ -19,8 +19,10 @@ function updateDataset(oldVnode: VNode, vnode: VNode): void { for (key in oldDataset) { if (!dataset[key]) { - if (d && d[key]) { - delete d[key]; + if (d) { + if (key in d) { + delete d[key]; + } } else { elm.removeAttribute('data-' + key.replace(CAPS_REGEX, '-$&').toLowerCase()); }