Codec's encoder/decoder instances caching

src/main/java/org/redisson/client/codec/LongCodec.java

@@ -25,14 +25,16 @@ public class LongCodec extends StringCodec {
 
     public static final LongCodec INSTANCE = new LongCodec();
 
-    @Override
-    public Decoder<Object> getValueDecoder() {
-        return new Decoder<Object>() {
+    public final Decoder<Object> decoder = new Decoder<Object>() {
         @Override
         public Object decode(ByteBuf buf, State state) {
             return Long.valueOf(buf.toString(CharsetUtil.UTF_8));
         }
     };
+
+    @Override
+    public Decoder<Object> getValueDecoder() {
+        return decoder;
     }
 
 }

src/main/java/org/redisson/client/codec/StringCodec.java

@@ -28,24 +28,28 @@ public class StringCodec implements Codec {
 
     public static final StringCodec INSTANCE = new StringCodec();
 
+    private final Encoder encoder = new Encoder() {
         @Override
-    public Decoder<Object> getValueDecoder() {
-        return new Decoder<Object>() {
+        public byte[] encode(Object in) throws IOException {
+            return in.toString().getBytes("UTF-8");
+        }
+    };
+
+    private final Decoder<Object> decoder = new Decoder<Object>() {
         @Override
         public Object decode(ByteBuf buf, State state) {
             return buf.toString(CharsetUtil.UTF_8);
         }
     };
+
+    @Override
+    public Decoder<Object> getValueDecoder() {
+        return decoder;
     }
 
     @Override
     public Encoder getValueEncoder() {
-        return new Encoder() {
-            @Override
-            public byte[] encode(Object in) throws IOException {
-                return in.toString().getBytes("UTF-8");
-            }
-        };
+        return encoder;
     }
 
     @Override

src/main/java/org/redisson/codec/JsonJacksonCodec.java

@@ -44,7 +44,21 @@ import io.netty.buffer.ByteBufInputStream;
  */
 public class JsonJacksonCodec implements Codec {
 
-    private ObjectMapper mapObjectMapper = new ObjectMapper();
+    private final ObjectMapper mapObjectMapper = new ObjectMapper();
+
+    private final Encoder encoder = new Encoder() {
+        @Override
+        public byte[] encode(Object in) throws IOException {
+            return mapObjectMapper.writeValueAsBytes(in);
+        }
+    };
+
+    private final Decoder<Object> decoder = new Decoder<Object>() {
+        @Override
+        public Object decode(ByteBuf buf, State state) throws IOException {
+            return mapObjectMapper.readValue(new ByteBufInputStream(buf), Object.class);
+        }
+    };
 
     public JsonJacksonCodec() {
         init(mapObjectMapper);
@@ -94,24 +108,12 @@ public class JsonJacksonCodec implements Codec {
 
     @Override
     public Decoder<Object> getMapValueDecoder() {
-        return new Decoder<Object>() {
-
-            @Override
-            public Object decode(ByteBuf buf, State state) throws IOException {
-                return mapObjectMapper.readValue(new ByteBufInputStream(buf), Object.class);
-            }
-        };
+        return decoder;
     }
 
     @Override
     public Encoder getMapValueEncoder() {
-        return new Encoder() {
-
-            @Override
-            public byte[] encode(Object in) throws IOException {
-                return mapObjectMapper.writeValueAsBytes(in);
-            }
-        };
+        return encoder;
     }
 
     @Override

src/main/java/org/redisson/codec/KryoCodec.java

@@ -93,43 +93,7 @@ public class KryoCodec implements Codec {
 
     private final KryoPool kryoPool;
 
-    public KryoCodec() {
-        this(new KryoPoolImpl(Collections.<Class<?>>emptyList()));
-    }
-
-    public KryoCodec(List<Class<?>> classes) {
-        this(new KryoPoolImpl(classes));
-    }
-
-
-    public KryoCodec(KryoPool kryoPool) {
-        this.kryoPool = kryoPool;
-    }
-
-    @Override
-    public Decoder<Object> getMapValueDecoder() {
-        return getValueDecoder();
-    }
-
-    @Override
-    public Encoder getMapValueEncoder() {
-        return getValueEncoder();
-    }
-
-    @Override
-    public Decoder<Object> getMapKeyDecoder() {
-        return getValueDecoder();
-    }
-
-    @Override
-    public Encoder getMapKeyEncoder() {
-        return getValueEncoder();
-    }
-
-    @Override
-    public Decoder<Object> getValueDecoder() {
-        return new Decoder<Object>() {
-
+    private final Decoder<Object> decoder = new Decoder<Object>() {
         @Override
         public Object decode(ByteBuf buf, State state) throws IOException {
             Kryo kryo = null;
@@ -148,11 +112,8 @@ public class KryoCodec implements Codec {
             }
         }
     };
-    }
 
-    @Override
-    public Encoder getValueEncoder() {
-        return new Encoder() {
+    private final Encoder encoder = new Encoder() {
 
         @Override
         public byte[] encode(Object in) throws IOException {
@@ -176,6 +137,48 @@ public class KryoCodec implements Codec {
             }
         }
     };
+
+    public KryoCodec() {
+        this(new KryoPoolImpl(Collections.<Class<?>>emptyList()));
+    }
+
+    public KryoCodec(List<Class<?>> classes) {
+        this(new KryoPoolImpl(classes));
+    }
+
+
+    public KryoCodec(KryoPool kryoPool) {
+        this.kryoPool = kryoPool;
+    }
+
+    @Override
+    public Decoder<Object> getMapValueDecoder() {
+        return getValueDecoder();
+    }
+
+    @Override
+    public Encoder getMapValueEncoder() {
+        return getValueEncoder();
+    }
+
+    @Override
+    public Decoder<Object> getMapKeyDecoder() {
+        return getValueDecoder();
+    }
+
+    @Override
+    public Encoder getMapKeyEncoder() {
+        return getValueEncoder();
+    }
+
+    @Override
+    public Decoder<Object> getValueDecoder() {
+        return decoder;
+    }
+
+    @Override
+    public Encoder getValueEncoder() {
+        return encoder;
     }
 
 }

src/main/java/org/redisson/codec/SerializationCodec.java

@@ -35,6 +35,32 @@ import io.netty.buffer.ByteBufInputStream;
  */
 public class SerializationCodec implements Codec {
 
+    private final Decoder<Object> decoder = new Decoder<Object>() {
+        @Override
+        public Object decode(ByteBuf buf, State state) throws IOException {
+            try {
+                ObjectInputStream inputStream = new ObjectInputStream(new ByteBufInputStream(buf));
+                return inputStream.readObject();
+            } catch (IOException e) {
+                throw e;
+            } catch (Exception e) {
+                throw new IOException(e);
+            }
+        }
+    };
+
+    private final Encoder encoder = new Encoder() {
+
+        @Override
+        public byte[] encode(Object in) throws IOException {
+            ByteArrayOutputStream result = new ByteArrayOutputStream();
+            ObjectOutputStream outputStream = new ObjectOutputStream(result);
+            outputStream.writeObject(in);
+            outputStream.close();
+            return result.toByteArray();
+        }
+    };
+
     @Override
     public Decoder<Object> getMapValueDecoder() {
         return getValueDecoder();
@@ -57,34 +83,12 @@ public class SerializationCodec implements Codec {
 
     @Override
     public Decoder<Object> getValueDecoder() {
-        return new Decoder<Object>() {
-            @Override
-            public Object decode(ByteBuf buf, State state) throws IOException {
-                try {
-                    ObjectInputStream inputStream = new ObjectInputStream(new ByteBufInputStream(buf));
-                    return inputStream.readObject();
-                } catch (IOException e) {
-                    throw e;
-                } catch (Exception e) {
-                    throw new IOException(e);
-                }
-            }
-        };
+        return decoder;
     }
 
     @Override
     public Encoder getValueEncoder() {
-        return new Encoder() {
-
-            @Override
-            public byte[] encode(Object in) throws IOException {
-                ByteArrayOutputStream result = new ByteArrayOutputStream();
-                ObjectOutputStream outputStream = new ObjectOutputStream(result);
-                outputStream.writeObject(in);
-                outputStream.close();
-                return result.toByteArray();
-            }
-        };
+        return encoder;
     }
 
 }