Fixed - validation of cron expression parameter of RScheduledExecutorService.schedule method #1494

redisson/src/main/java/org/redisson/RedissonExecutorService.java

@@ -850,6 +850,9 @@ public class RedissonExecutorService implements RScheduledExecutorService {
         byte[] classBody = getClassBody(task);
         byte[] state = encode(task);
         final Date startDate = cronSchedule.getExpression().getNextValidTimeAfter(new Date());
+        if (startDate == null) {
+            throw new IllegalArgumentException("Wrong cron expression! Unable to calculate start date");
+        }
         long startTime = startDate.getTime();
         RemotePromise<Void> result = (RemotePromise<Void>) asyncScheduledServiceAtFixed.schedule(task.getClass().getName(), classBody, state, startTime, cronSchedule.getExpression().getCronExpression(), executorId, null);
         addListener(result);

redisson/src/test/java/org/redisson/executor/RedissonScheduledExecutorServiceTest.java

@@ -138,6 +138,12 @@ public class RedissonScheduledExecutorServiceTest extends BaseTest {
         assertThat(redisson.getAtomicLong("executed").get()).isEqualTo(2);
     }
     
+    @Test(expected = IllegalArgumentException.class)
+    public void testWrongCronExpression() throws InterruptedException, ExecutionException {
+        RScheduledExecutorService executor = redisson.getExecutorService("test");
+        executor.schedule(new ScheduledRunnableTask("executed"), CronSchedule.of("0 44 12 19 JUN ? 2018"));
+    }
+    
     @Test
     public void testCronExpressionMultipleTasks() throws InterruptedException, ExecutionException {
         RScheduledExecutorService executor = redisson.getExecutorService("test");