closeConnectionAfterFailAttempts. #198

src/main/java/org/redisson/BaseConfig.java

@@ -35,6 +35,8 @@ class BaseConfig<T extends BaseConfig<T>> {
 
     private int retryInterval = 1000;
 
+    private int closeConnectionAfterFailAttempts = -1;
+
     /**
      * Database index used for Redis connection
      */
@@ -67,6 +69,7 @@ class BaseConfig<T extends BaseConfig<T>> {
         setTimeout(config.getTimeout());
         setClientName(config.getClientName());
         setPingTimeout(config.getPingTimeout());
+        setCloseConnectionAfterFailAttempts(config.getCloseConnectionAfterFailAttempts());
     }
 
     /**
@@ -159,30 +162,45 @@ class BaseConfig<T extends BaseConfig<T>> {
     }
 
     /**
-     * Name for client connection
+     * Setup connection name during connection init
+     * via CLIENT SETNAME command
+     *
+     * @param name
      */
-    public String getClientName() {
-        return clientName;
-    }
-
     public T setClientName(String clientName) {
         this.clientName = clientName;
         return (T) this;
     }
+    public String getClientName() {
+        return clientName;
+    }
+
 
     /**
      * Ping timeout used in <code>Node.ping</code> and <code>Node.pingAll<code> operation
      *
-     * @return
+     * @param ping timeout in milliseconds
      */
-    public int getPingTimeout() {
-        return pingTimeout;
-    }
     public T setPingTimeout(int pingTimeout) {
         this.pingTimeout = pingTimeout;
         return (T) this;
     }
+    public int getPingTimeout() {
+        return pingTimeout;
+    }
 
+    /**
+     * Close connection if it has <code>failAttemptsAmount</code>
+     * fails in a row during command sending. Turned off by default.
+     *
+     * @param failAttemptsAmount
+     */
+    public void setCloseConnectionAfterFailAttempts(int failAttemptsAmount) {
+        this.closeConnectionAfterFailAttempts = failAttemptsAmount;
+    }
+    public int getCloseConnectionAfterFailAttempts() {
+        return closeConnectionAfterFailAttempts;
+    }
 
 
 }

src/main/java/org/redisson/client/RedisConnection.java

@@ -39,6 +39,7 @@ public class RedisConnection implements RedisCommands {
     private volatile boolean closed;
     volatile Channel channel;
     private ReconnectListener reconnectListener;
+    private int failAttempts;
 
     public RedisConnection(RedisClient redisClient, Channel channel) {
         super();
@@ -55,6 +56,18 @@ public class RedisConnection implements RedisCommands {
         return reconnectListener;
     }
 
+    public void resetFailAttempt() {
+        failAttempts = 0;
+    }
+
+    public void incFailAttempt() {
+        failAttempts++;
+    }
+
+    public int getFailAttempts() {
+        return failAttempts;
+    }
+
     public void updateChannel(Channel channel) {
         this.channel = channel;
         channel.attr(CONNECTION).set(this);

src/main/java/org/redisson/connection/BaseLoadBalancer.java

@@ -225,7 +225,7 @@ abstract class BaseLoadBalancer implements LoadBalancer {
 
     public void returnConnection(RedisConnection connection) {
         SubscribesConnectionEntry entry = clients.get(connection.getRedisClient());
-        if (entry.isFreezed()) {
+        if (entry.isFreezed() || connection.getFailAttempts() == config.getCloseConnectionAfterFailAttempts()) {
             connection.closeAsync();
         } else {
             entry.getConnections().add(connection);

src/main/java/org/redisson/connection/ClusterConnectionManager.java

@@ -244,6 +244,7 @@ public class ClusterConnectionManager extends MasterSlaveConnectionManager {
         c.setPassword(cfg.getPassword());
         c.setDatabase(cfg.getDatabase());
         c.setClientName(cfg.getClientName());
+        c.setCloseConnectionAfterFailAttempts(cfg.getCloseConnectionAfterFailAttempts());
         c.setMasterConnectionPoolSize(cfg.getMasterConnectionPoolSize());
         c.setSlaveConnectionPoolSize(cfg.getSlaveConnectionPoolSize());
         c.setSlaveSubscriptionConnectionPoolSize(cfg.getSlaveSubscriptionConnectionPoolSize());

src/main/java/org/redisson/connection/MasterSlaveConnectionManager.java

@@ -166,6 +166,12 @@ public class MasterSlaveConnectionManager implements ConnectionManager {
         return new FutureListener<T>() {
             @Override
             public void operationComplete(io.netty.util.concurrent.Future<T> future) throws Exception {
+                if (!future.isSuccess()) {
+                    conn.incFailAttempt();
+                } else {
+                    conn.resetFailAttempt();
+                }
+
                 shutdownLatch.release();
                 timeout.cancel();
                 releaseWrite(slot, conn);
@@ -179,6 +185,12 @@ public class MasterSlaveConnectionManager implements ConnectionManager {
         return new FutureListener<T>() {
             @Override
             public void operationComplete(io.netty.util.concurrent.Future<T> future) throws Exception {
+                if (!future.isSuccess()) {
+                    conn.incFailAttempt();
+                } else {
+                    conn.resetFailAttempt();
+                }
+
                 shutdownLatch.release();
                 timeout.cancel();
                 releaseRead(slot, conn);

src/main/java/org/redisson/connection/MasterSlaveEntry.java

@@ -175,6 +175,10 @@ public class MasterSlaveEntry {
         if (!entry.getClient().equals(connection.getRedisClient())) {
             connection.closeAsync();
             return;
+        } else if (connection.getFailAttempts() == config.getCloseConnectionAfterFailAttempts()) {
+            connection.closeAsync();
+            entry.getConnectionsSemaphore().release();
+            return;
         }
 
         entry.getConnections().add(connection);

src/main/java/org/redisson/connection/SentinelConnectionManager.java

@@ -61,6 +61,7 @@ public class SentinelConnectionManager extends MasterSlaveConnectionManager {
         c.setPassword(cfg.getPassword());
         c.setDatabase(cfg.getDatabase());
         c.setClientName(cfg.getClientName());
+        c.setCloseConnectionAfterFailAttempts(cfg.getCloseConnectionAfterFailAttempts());
         c.setMasterConnectionPoolSize(cfg.getMasterConnectionPoolSize());
         c.setSlaveConnectionPoolSize(cfg.getSlaveConnectionPoolSize());
         c.setSlaveSubscriptionConnectionPoolSize(cfg.getSlaveSubscriptionConnectionPoolSize());

src/main/java/org/redisson/connection/SingleConnectionManager.java

@@ -48,6 +48,7 @@ public class SingleConnectionManager extends MasterSlaveConnectionManager {
         newconfig.setPassword(cfg.getPassword());
         newconfig.setDatabase(cfg.getDatabase());
         newconfig.setClientName(cfg.getClientName());
+        newconfig.setCloseConnectionAfterFailAttempts(cfg.getCloseConnectionAfterFailAttempts());
         newconfig.setMasterAddress(addr);
         newconfig.setMasterConnectionPoolSize(cfg.getConnectionPoolSize());
         newconfig.setSubscriptionsPerConnection(cfg.getSubscriptionsPerConnection());