Merge pull request #3227 from microsoft/hediet/workerManager

Refactors workerManager

src/language/typescript/workerManager.ts

@@ -8,8 +8,6 @@ import type { TypeScriptWorker } from './tsWorker';
 import { editor, Uri, IDisposable } from '../../fillers/monaco-editor-core';
 
 export class WorkerManager {
-	private _modeId: string;
-	private _defaults: LanguageServiceDefaults;
 	private _configChangeListener: IDisposable;
 	private _updateExtraLibsToken: number;
 	private _extraLibsChangeListener: IDisposable;
@@ -17,9 +15,10 @@ export class WorkerManager {
 	private _worker: editor.MonacoWebWorker<TypeScriptWorker> | null;
 	private _client: Promise<TypeScriptWorker> | null;
 
-	constructor(modeId: string, defaults: LanguageServiceDefaults) {
+	constructor(
-		this._modeId = modeId;
+		private readonly _modeId: string,
-		this._defaults = defaults;
+		private readonly _defaults: LanguageServiceDefaults
+	) {
 		this._worker = null;
 		this._client = null;
 		this._configChangeListener = this._defaults.onDidChange(() => this._stopWorker());
@@ -29,6 +28,12 @@ export class WorkerManager {
 		);
 	}
 
+	dispose(): void {
+		this._configChangeListener.dispose();
+		this._extraLibsChangeListener.dispose();
+		this._stopWorker();
+	}
+
 	private _stopWorker(): void {
 		if (this._worker) {
 			this._worker.dispose();
@@ -37,12 +42,6 @@ export class WorkerManager {
 		this._client = null;
 	}
 
-	dispose(): void {
-		this._configChangeListener.dispose();
-		this._extraLibsChangeListener.dispose();
-		this._stopWorker();
-	}
-
 	private async _updateExtraLibs(): Promise<void> {
 		if (!this._worker) {
 			return;
@@ -58,6 +57,7 @@ export class WorkerManager {
 
 	private _getClient(): Promise<TypeScriptWorker> {
 		if (!this._client) {
+			this._client = (async () => {
 				this._worker = editor.createWebWorker<TypeScriptWorker>({
 					// module that exports the create() method and returns a `TypeScriptWorker` instance
 					moduleId: 'vs/language/typescript/tsWorker',
@@ -75,39 +75,27 @@ export class WorkerManager {
 					}
 				});
 
-			let p = <Promise<TypeScriptWorker>>this._worker.getProxy();
-
 				if (this._defaults.getEagerModelSync()) {
-				p = p.then((worker) => {
+					return await this._worker.withSyncedResources(
-					if (this._worker) {
-						return this._worker.withSyncedResources(
 						editor
 							.getModels()
 							.filter((model) => model.getLanguageId() === this._modeId)
 							.map((model) => model.uri)
 					);
 				}
-					return worker;
-				});
-			}
 
-			this._client = p;
+				return await this._worker.getProxy();
+			})();
 		}
 
 		return this._client;
 	}
 
-	getLanguageServiceWorker(...resources: Uri[]): Promise<TypeScriptWorker> {
+	async getLanguageServiceWorker(...resources: Uri[]): Promise<TypeScriptWorker> {
-		let _client: TypeScriptWorker;
+		const client = await this._getClient();
-		return this._getClient()
-			.then((client) => {
-				_client = client;
-			})
-			.then((_) => {
 		if (this._worker) {
-					return this._worker.withSyncedResources(resources);
+			await this._worker.withSyncedResources(resources);
 		}
-			})
+		return client;
-			.then((_) => _client);
 	}
 }