Call clearFiles on internal EmitOutput diagnostics

pull/4482/head
Jake Bailey 10 months ago
parent 707338797b
commit 5a8eb62e4e

@ -216,9 +216,10 @@ export interface DiagnosticRelatedInformation {
messageText: string | DiagnosticMessageChain; messageText: string | DiagnosticMessageChain;
} }
interface EmitOutput { export interface EmitOutput {
outputFiles: OutputFile[]; outputFiles: OutputFile[];
emitSkipped: boolean; emitSkipped: boolean;
diagnostics?: Diagnostic[];
} }
interface OutputFile { interface OutputFile {
name: string; name: string;

@ -8,6 +8,7 @@ import { libFileMap } from './lib/lib';
import { import {
Diagnostic, Diagnostic,
DiagnosticRelatedInformation, DiagnosticRelatedInformation,
EmitOutput,
IExtraLibs, IExtraLibs,
TypeScriptWorker as ITypeScriptWorker TypeScriptWorker as ITypeScriptWorker
} from './monaco.contribution'; } from './monaco.contribution';
@ -401,11 +402,18 @@ export class TypeScriptWorker implements ts.LanguageServiceHost, ITypeScriptWork
return this._languageService.getRenameInfo(fileName, position, options); return this._languageService.getRenameInfo(fileName, position, options);
} }
async getEmitOutput(fileName: string): Promise<ts.EmitOutput> { async getEmitOutput(fileName: string): Promise<EmitOutput> {
if (fileNameIsLib(fileName)) { if (fileNameIsLib(fileName)) {
return { outputFiles: [], emitSkipped: true }; return { outputFiles: [], emitSkipped: true };
} }
return this._languageService.getEmitOutput(fileName); // The diagnostics property is internal, returning it without clearing breaks message serialization.
const emitOutput = this._languageService.getEmitOutput(fileName) as ts.EmitOutput & {
diagnostics?: ts.Diagnostic[];
};
const diagnostics = emitOutput.diagnostics
? TypeScriptWorker.clearFiles(emitOutput.diagnostics)
: undefined;
return { ...emitOutput, diagnostics };
} }
async getCodeFixesAtPosition( async getCodeFixesAtPosition(

Loading…
Cancel
Save