You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/services
wxiaoguang dd8bc1d61d
Refactor issue template parsing and fix API endpoint (#29069) (#29140)
Backport #29069

The old code `GetTemplatesFromDefaultBranch(...) ([]*api.IssueTemplate,
map[string]error)` doesn't really follow Golang's habits, then the
second returned value might be misused. For example, the API function
`GetIssueTemplates` incorrectly checked the second returned value and
always responds 500 error.

This PR refactors GetTemplatesFromDefaultBranch to
ParseTemplatesFromDefaultBranch and clarifies its behavior, and fixes
the API endpoint bug, and adds some tests.

And by the way, add proper prefix `X-` for the header generated in
`checkDeprecatedAuthMethods`, because non-standard HTTP headers should
have `X-` prefix, and it is also consistent with the new code in
`GetIssueTemplates`
1 year ago
..
actions Fix an actions schedule bug (#28942) (#28999) 1 year ago
agit Move notification interface to services layer (#26915) 1 year ago
asymkey Another round of `db.DefaultContext` refactor (#27103) (#27262) 1 year ago
attachment move repository deletion to service layer (#26948) 1 year ago
auth Deprecate query string auth tokens (#28390) (#28430) 1 year ago
automerge Improve queue and logger context (#24924) 2 years ago
context Another round of `db.DefaultContext` refactor (#27103) (#27262) 1 year ago
convert Fix an actions schedule bug (#28942) (#28999) 1 year ago
cron Recover from panic in cron task (#28409) (#28425) 1 year ago
externalaccount More `db.DefaultContext` refactor (#27265) (#27347) 1 year ago
feed More `db.DefaultContext` refactor (#27265) (#27347) 1 year ago
forms Fix required error for token name (#28267) (#28284) 1 year ago
gitdiff Add option to disable ambiguous unicode characters detection (#28454) (#28499) 1 year ago
indexer Fix missing issue search index update when changing status (#28325) (#28330) 1 year ago
issue Refactor issue template parsing and fix API endpoint (#29069) (#29140) 1 year ago
lfs Bump github.com/golang-jwt/jwt to v5 (#25975) 2 years ago
mailer Rework markup link rendering (#26745) (#28803) 1 year ago
markup Move web/api context related testing function into a separate package (#26859) 2 years ago
migrations Only migrate the first 255 chars of a Github issue title (#28902) (#28912) 1 year ago
mirror More `db.DefaultContext` refactor (#27265) (#27347) 1 year ago
notify Update status and code index after changing the default branch (#27018) 1 year ago
org Delete repos of org when purge delete user (#27273) (#27728) 1 year ago
packages Fix reverting a merge commit failing (#28794) (#28825) 1 year ago
pull Concatenate error in `checkIfPRContentChanged` (#28731) (#28737) 1 year ago
release Avoid sending update/delete release notice when it is draft (#29008) (#29025) 1 year ago
repository Fix an actions schedule bug (#28942) (#28999) 1 year ago
secrets Refactor secrets modification logic (#26873) 1 year ago
task Fix incorrect ctx usage in defer function (#27740) (#27741) 1 year ago
uinotification More `db.DefaultContext` refactor (#27265) (#27347) 1 year ago
user Forbid removing the last admin user (#28337) (#28793) 1 year ago
webhook Fix comment permissions (#28213) (#28216) 1 year ago
wiki Fix an actions schedule bug (#28942) (#28999) 1 year ago