You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/services
KN4CK3R 022552d5b6
Rework markup link rendering (#26745) (#28803)
Backport #26745
Fixes #26548

This PR refactors the rendering of markup links. The old code uses
`strings.Replace` to change some urls while the new code uses more
context to decide which link should be generated.

The added tests should ensure the same output for the old and new
behaviour (besides the bug).

We may need to refactor the rendering a bit more to make it clear how
the different helper methods render the input string. There are lots of
options (resolve links / images / mentions / git hashes / emojis / ...)
but you don't really know what helper uses which options. For example,
we currently support images in the user description which should not be
allowed I think:

<details>
  <summary>Profile</summary>

https://try.gitea.io/KN4CK3R


![grafik](https://github.com/go-gitea/gitea/assets/1666336/109ae422-496d-4200-b52e-b3a528f553e5)

</details>
1 year ago
..
actions Fix schedule tasks bugs (#28691) (#28780) 1 year ago
agit Move notification interface to services layer (#26915) 1 year ago
asymkey Another round of `db.DefaultContext` refactor (#27103) (#27262) 1 year ago
attachment move repository deletion to service layer (#26948) 1 year ago
auth Deprecate query string auth tokens (#28390) (#28430) 1 year ago
automerge Improve queue and logger context (#24924) 2 years ago
context Another round of `db.DefaultContext` refactor (#27103) (#27262) 1 year ago
convert Fix `convert.ToTeams` on empty input (#28426) (#28767) 1 year ago
cron Recover from panic in cron task (#28409) (#28425) 1 year ago
externalaccount More `db.DefaultContext` refactor (#27265) (#27347) 1 year ago
feed More `db.DefaultContext` refactor (#27265) (#27347) 1 year ago
forms Fix required error for token name (#28267) (#28284) 1 year ago
gitdiff Add option to disable ambiguous unicode characters detection (#28454) (#28499) 1 year ago
indexer Fix missing issue search index update when changing status (#28325) (#28330) 1 year ago
issue Avoid run change title process when the title is same (#27467) (#27558) 1 year ago
lfs Bump github.com/golang-jwt/jwt to v5 (#25975) 2 years ago
mailer Rework markup link rendering (#26745) (#28803) 1 year ago
markup Move web/api context related testing function into a separate package (#26859) 2 years ago
migrations Use known issue IID to generate new PR index number when migrating from GitLab (#28616) (#28618) 1 year ago
mirror More `db.DefaultContext` refactor (#27265) (#27347) 1 year ago
notify Update status and code index after changing the default branch (#27018) 1 year ago
org Delete repos of org when purge delete user (#27273) (#27728) 1 year ago
packages Fix alpine package files are not rebuilt (#28638) (#28665) 1 year ago
pull Concatenate error in `checkIfPRContentChanged` (#28731) (#28737) 1 year ago
release Fix comment permissions (#28213) (#28216) 1 year ago
repository Fix schedule tasks bugs (#28691) (#28780) 1 year ago
secrets Refactor secrets modification logic (#26873) 1 year ago
task Fix incorrect ctx usage in defer function (#27740) (#27741) 1 year ago
uinotification More `db.DefaultContext` refactor (#27265) (#27347) 1 year ago
user Forbid removing the last admin user (#28337) (#28793) 1 year ago
webhook Fix comment permissions (#28213) (#28216) 1 year ago
wiki Fix schedule tasks bugs (#28691) (#28780) 1 year ago