You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/modules/templates
KN4CK3R 637451a45e
Rework markup link rendering (#26745)
Fixes #26548

This PR refactors the rendering of markup links. The old code uses
`strings.Replace` to change some urls while the new code uses more
context to decide which link should be generated.

The added tests should ensure the same output for the old and new
behaviour (besides the bug).

We may need to refactor the rendering a bit more to make it clear how
the different helper methods render the input string. There are lots of
options (resolve links / images / mentions / git hashes / emojis / ...)
but you don't really know what helper uses which options. For example,
we currently support images in the user description which should not be
allowed I think:

<details>
  <summary>Profile</summary> 

https://try.gitea.io/KN4CK3R

![grafik](https://github.com/go-gitea/gitea/assets/1666336/109ae422-496d-4200-b52e-b3a528f553e5)

</details>

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
1 year ago
..
eval Use a general Eval function for expressions in templates. (#23927) 2 years ago
scopedtmpl Replace `interface{}` with `any` (#25686) 2 years ago
vars Implement FSFE REUSE for golang files (#21840) 2 years ago
base.go Replace `util.SliceXxx` with `slices.Xxx` (#26958) 1 year ago
dynamic.go Use a general approach to access custom/static/builtin assets (#24022) 2 years ago
helper.go Rework markup link rendering (#26745) 1 year ago
helper_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
htmlrenderer.go Upgrade to golangci-lint@v1.55.0 (#27756) 1 year ago
htmlrenderer_test.go Show friendly 500 error page to users and developers (#24110) 2 years ago
mailer.go Improve RunMode / dev mode (#24886) 2 years ago
static.go Use a general approach to access custom/static/builtin assets (#24022) 2 years ago
templates_bindata.go Implement FSFE REUSE for golang files (#21840) 2 years ago
util_avatar.go Use template context function for avatar rendering (#26385) 2 years ago
util_dict.go Use `Set[Type]` instead of `map[Type]bool/struct{}`. (#26804) 1 year ago
util_json.go Improve template helper (#24417) 2 years ago
util_misc.go Improve feed icons and feed merge text color (#27498) 1 year ago
util_render.go Rework markup link rendering (#26745) 1 year ago
util_render_test.go Rework markup link rendering (#26745) 1 year ago
util_slice.go Improve template helper functions: string/slice (#24266) 2 years ago
util_string.go Support for grouping RPMs using paths (#26984) 1 year ago
util_test.go Improve template helper functions: string/slice (#24266) 2 years ago