You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/routers/web
Eng Zer Jun 13d5d2e711
Remove redundant `len` check around loop (#27464)
This pull request is a minor code cleanup.

From the Go specification (https://go.dev/ref/spec#For_range):

> "1. For a nil slice, the number of iterations is 0."
> "3. If the map is nil, the number of iterations is 0."

`len` returns 0 if the slice or map is nil
(https://pkg.go.dev/builtin#len). Therefore, checking `len(v) > 0`
before a loop is unnecessary.

---

At the time of writing this pull request, there wasn't a lint rule that
catches these issues. The closest I could find is
https://staticcheck.dev/docs/checks/#S103

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
1 year ago
..
admin Refactor system setting (#27000) 1 year ago
auth Even more `db.DefaultContext` refactor (#27352) 1 year ago
devtest Make "cancel" buttons have proper type in modal forms (#25618) 2 years ago
events Implement FSFE REUSE for golang files (#21840) 2 years ago
explore Next round of `db.DefaultContext` refactor (#27089) 2 years ago
feed More `db.DefaultContext` refactor (#27265) 2 years ago
healthcheck Remove `db.DefaultContext` in `routers/` and `cmd/` (#26076) 2 years ago
misc Serve pre-defined files in "public", add "security.txt", add CORS header for ".well-known" (#25974) 2 years ago
org Even more `db.DefaultContext` refactor (#27352) 1 year ago
repo Remove redundant `len` check around loop (#27464) 1 year ago
shared Even more `db.DefaultContext` refactor (#27352) 1 year ago
user Refactor system setting (#27000) 1 year ago
base.go Fix all possible setting error related storages and added some tests (#23911) 2 years ago
goget.go Support SSH for go get (#24664) 2 years ago
home.go Reduce usage of `db.DefaultContext` (#27073) 2 years ago
metrics.go Implement FSFE REUSE for golang files (#21840) 2 years ago
nodeinfo.go Implement FSFE REUSE for golang files (#21840) 2 years ago
swagger_json.go Start using template context function (#26254) 2 years ago
web.go Allow get release download files and lfs files with oauth2 token format (#26430) 1 year ago
webfinger.go Add a link to OpenID Issuer URL in WebFinger response (#26000) 2 years ago