You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/routers
Eng Zer Jun 13d5d2e711
Remove redundant `len` check around loop (#27464)
This pull request is a minor code cleanup.

From the Go specification (https://go.dev/ref/spec#For_range):

> "1. For a nil slice, the number of iterations is 0."
> "3. If the map is nil, the number of iterations is 0."

`len` returns 0 if the slice or map is nil
(https://pkg.go.dev/builtin#len). Therefore, checking `len(v) > 0`
before a loop is unnecessary.

---

At the time of writing this pull request, there wasn't a lint rule that
catches these issues. The closest I could find is
https://staticcheck.dev/docs/checks/#S103

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
1 year ago
..
api Don't let API add 2 exclusive labels from same scope (#27433) 1 year ago
common Refactor system setting (#27000) 1 year ago
install Refactor system setting (#27000) 1 year ago
private make writing main test easier (#27270) 2 years ago
utils Implement FSFE REUSE for golang files (#21840) 2 years ago
web Remove redundant `len` check around loop (#27464) 1 year ago
init.go Another round of `db.DefaultContext` refactor (#27103) 2 years ago