github-forks
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Projects Releases Activity

Fix "force private" logic (#31012)

Browse Source 
When creating a repo, the "FORCE_PRIVATE" config option should be
respected, `readonly` doesn't work for checkbox, so it should use
`disabled` attribute.
pull/30999/head^2
wxiaoguang 9 months ago committed by GitHub
parent 82a0c36332
commit edbf74c418
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
16 changed files with 19 additions and 18 deletions
Show Stats Download Patch File Download Diff File

2
routers/api/v1/repo/migrate.go
Unescape Escape View File

@ -175,7 +175,7 @@ func Migrate(ctx *context.APIContext) {
Description: opts.Description, Description: opts.Description,
OriginalURL: form.CloneAddr, OriginalURL: form.CloneAddr,
GitServiceType: gitServiceType, GitServiceType: gitServiceType,
IsPrivate: opts.Private, IsPrivate: opts.Private || setting.Repository.ForcePrivate,
IsMirror: opts.Mirror, IsMirror: opts.Mirror,
Status: repo_model.RepositoryBeingMigrated, Status: repo_model.RepositoryBeingMigrated,
}) })

4
routers/api/v1/repo/repo.go
Unescape Escape View File

@ -252,7 +252,7 @@ func CreateUserRepo(ctx *context.APIContext, owner *user_model.User, opt api.Cre
Gitignores: opt.Gitignores, Gitignores: opt.Gitignores,
License: opt.License, License: opt.License,
Readme: opt.Readme, Readme: opt.Readme,
IsPrivate: opt.Private, IsPrivate: opt.Private || setting.Repository.ForcePrivate,
AutoInit: opt.AutoInit, AutoInit: opt.AutoInit,
DefaultBranch: opt.DefaultBranch, DefaultBranch: opt.DefaultBranch,
TrustModel: repo_model.ToTrustModel(opt.TrustModel), TrustModel: repo_model.ToTrustModel(opt.TrustModel),
@ -364,7 +364,7 @@ func Generate(ctx *context.APIContext) {
Name: form.Name, Name: form.Name,
DefaultBranch: form.DefaultBranch, DefaultBranch: form.DefaultBranch,
Description: form.Description, Description: form.Description,
Private: form.Private, Private: form.Private || setting.Repository.ForcePrivate,
GitContent: form.GitContent, GitContent: form.GitContent,
Topics: form.Topics, Topics: form.Topics,
GitHooks: form.GitHooks, GitHooks: form.GitHooks,

2
routers/web/repo/repo.go
Unescape Escape View File

@ -248,7 +248,7 @@ func CreatePost(ctx *context.Context) {
opts := repo_service.GenerateRepoOptions{ opts := repo_service.GenerateRepoOptions{
Name: form.RepoName, Name: form.RepoName,
Description: form.Description, Description: form.Description,
Private: form.Private, Private: form.Private || setting.Repository.ForcePrivate,
GitContent: form.GitContent, GitContent: form.GitContent,
Topics: form.Topics, Topics: form.Topics,
GitHooks: form.GitHooks, GitHooks: form.GitHooks,

2
services/migrations/gitea_uploader.go
Unescape Escape View File

@ -107,7 +107,7 @@ func (g *GiteaLocalUploader) CreateRepo(repo *base.Repository, opts base.Migrate
Description: repo.Description, Description: repo.Description,
OriginalURL: repo.OriginalURL, OriginalURL: repo.OriginalURL,
GitServiceType: opts.GitServiceType, GitServiceType: opts.GitServiceType,
IsPrivate: opts.Private, IsPrivate: opts.Private || setting.Repository.ForcePrivate,
IsMirror: opts.Mirror, IsMirror: opts.Mirror,
Status: repo_model.RepositoryBeingMigrated, Status: repo_model.RepositoryBeingMigrated,
}) })

2
services/repository/repository.go
Unescape Escape View File

@ -85,7 +85,7 @@ func PushCreateRepo(ctx context.Context, authUser, owner *user_model.User, repoN
repo, err := CreateRepository(ctx, authUser, owner, CreateRepoOptions{ repo, err := CreateRepository(ctx, authUser, owner, CreateRepoOptions{
Name: repoName, Name: repoName,
IsPrivate: setting.Repository.DefaultPushCreatePrivate, IsPrivate: setting.Repository.DefaultPushCreatePrivate || setting.Repository.ForcePrivate,
}) })
if err != nil { if err != nil {
return nil, err return nil, err

2
services/task/task.go
Unescape Escape View File

@ -107,7 +107,7 @@ func CreateMigrateTask(ctx context.Context, doer, u *user_model.User, opts base.
Description: opts.Description, Description: opts.Description,
OriginalURL: opts.OriginalURL, OriginalURL: opts.OriginalURL,
GitServiceType: opts.GitServiceType, GitServiceType: opts.GitServiceType,
IsPrivate: opts.Private, IsPrivate: opts.Private || setting.Repository.ForcePrivate,
IsMirror: opts.Mirror, IsMirror: opts.Mirror,
Status: repo_model.RepositoryBeingMigrated, Status: repo_model.RepositoryBeingMigrated,
}) })

2
templates/repo/create.tmpl
Unescape Escape View File

@ -50,7 +50,7 @@
<label>{{ctx.Locale.Tr "repo.visibility"}}</label> <label>{{ctx.Locale.Tr "repo.visibility"}}</label>
<div class="ui checkbox"> <div class="ui checkbox">
{{if .IsForcedPrivate}} {{if .IsForcedPrivate}}
<input name="private" type="checkbox" checked readonly> <input name="private" type="checkbox" checked disabled>
<label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label> <label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label>
{{else}} {{else}}
<input name="private" type="checkbox" {{if .private}}checked{{end}}> <input name="private" type="checkbox" {{if .private}}checked{{end}}>

2
templates/repo/migrate/codebase.tmpl
Unescape Escape View File

@ -89,7 +89,7 @@
<label>{{ctx.Locale.Tr "repo.visibility"}}</label> <label>{{ctx.Locale.Tr "repo.visibility"}}</label>
<div class="ui checkbox"> <div class="ui checkbox">
{{if .IsForcedPrivate}} {{if .IsForcedPrivate}}
<input name="private" type="checkbox" checked readonly> <input name="private" type="checkbox" checked disabled>
<label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label> <label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label>
{{else}} {{else}}
<input name="private" type="checkbox" {{if .private}}checked{{end}}> <input name="private" type="checkbox" {{if .private}}checked{{end}}>

2
templates/repo/migrate/git.tmpl
Unescape Escape View File

@ -63,7 +63,7 @@
<label>{{ctx.Locale.Tr "repo.visibility"}}</label> <label>{{ctx.Locale.Tr "repo.visibility"}}</label>
<div class="ui checkbox"> <div class="ui checkbox">
{{if .IsForcedPrivate}} {{if .IsForcedPrivate}}
<input name="private" type="checkbox" checked readonly> <input name="private" type="checkbox" checked disabled>
<label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label> <label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label>
{{else}} {{else}}
<input name="private" type="checkbox" {{if .private}}checked{{end}}> <input name="private" type="checkbox" {{if .private}}checked{{end}}>

2
templates/repo/migrate/gitbucket.tmpl
Unescape Escape View File

@ -105,7 +105,7 @@
<label>{{ctx.Locale.Tr "repo.visibility"}}</label> <label>{{ctx.Locale.Tr "repo.visibility"}}</label>
<div class="ui checkbox"> <div class="ui checkbox">
{{if .IsForcedPrivate}} {{if .IsForcedPrivate}}
<input name="private" type="checkbox" checked readonly> <input name="private" type="checkbox" checked disabled>
<label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label> <label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label>
{{else}} {{else}}
<input name="private" type="checkbox" {{if .private}}checked{{end}}> <input name="private" type="checkbox" {{if .private}}checked{{end}}>

2
templates/repo/migrate/gitea.tmpl
Unescape Escape View File

@ -101,7 +101,7 @@
<label>{{ctx.Locale.Tr "repo.visibility"}}</label> <label>{{ctx.Locale.Tr "repo.visibility"}}</label>
<div class="ui checkbox"> <div class="ui checkbox">
{{if .IsForcedPrivate}} {{if .IsForcedPrivate}}
<input name="private" type="checkbox" checked readonly> <input name="private" type="checkbox" checked disabled>
<label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label> <label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label>
{{else}} {{else}}
<input name="private" type="checkbox" {{if .private}} checked{{end}}> <input name="private" type="checkbox" {{if .private}} checked{{end}}>

2
templates/repo/migrate/github.tmpl
Unescape Escape View File

@ -103,7 +103,7 @@
<label>{{ctx.Locale.Tr "repo.visibility"}}</label> <label>{{ctx.Locale.Tr "repo.visibility"}}</label>
<div class="ui checkbox"> <div class="ui checkbox">
{{if .IsForcedPrivate}} {{if .IsForcedPrivate}}
<input name="private" type="checkbox" checked readonly> <input name="private" type="checkbox" checked disabled>
<label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label> <label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label>
{{else}} {{else}}
<input name="private" type="checkbox" {{if .private}}checked{{end}}> <input name="private" type="checkbox" {{if .private}}checked{{end}}>

2
templates/repo/migrate/gitlab.tmpl
Unescape Escape View File

@ -100,7 +100,7 @@
<label>{{ctx.Locale.Tr "repo.visibility"}}</label> <label>{{ctx.Locale.Tr "repo.visibility"}}</label>
<div class="ui checkbox"> <div class="ui checkbox">
{{if .IsForcedPrivate}} {{if .IsForcedPrivate}}
<input name="private" type="checkbox" checked readonly> <input name="private" type="checkbox" checked disabled>
<label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label> <label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label>
{{else}} {{else}}
<input name="private" type="checkbox" {{if .private}}checked{{end}}> <input name="private" type="checkbox" {{if .private}}checked{{end}}>

2
templates/repo/migrate/gogs.tmpl
Unescape Escape View File

@ -103,7 +103,7 @@
<label>{{ctx.Locale.Tr "repo.visibility"}}</label> <label>{{ctx.Locale.Tr "repo.visibility"}}</label>
<div class="ui checkbox"> <div class="ui checkbox">
{{if .IsForcedPrivate}} {{if .IsForcedPrivate}}
<input name="private" type="checkbox" checked readonly> <input name="private" type="checkbox" checked disabled>
<label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label> <label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label>
{{else}} {{else}}
<input name="private" type="checkbox" {{if .private}} checked{{end}}> <input name="private" type="checkbox" {{if .private}} checked{{end}}>

2
templates/repo/migrate/onedev.tmpl
Unescape Escape View File

@ -89,7 +89,7 @@
<label>{{ctx.Locale.Tr "repo.visibility"}}</label> <label>{{ctx.Locale.Tr "repo.visibility"}}</label>
<div class="ui checkbox"> <div class="ui checkbox">
{{if .IsForcedPrivate}} {{if .IsForcedPrivate}}
<input name="private" type="checkbox" checked readonly> <input name="private" type="checkbox" checked disabled>
<label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label> <label>{{ctx.Locale.Tr "repo.visibility_helper_forced"}}</label>
{{else}} {{else}}
<input name="private" type="checkbox" {{if .private}}checked{{end}}> <input name="private" type="checkbox" {{if .private}}checked{{end}}>

3
templates/repo/settings/options.tmpl
Unescape Escape View File

@ -30,7 +30,8 @@
{{if .IsAdmin}} {{if .IsAdmin}}
<input name="private" type="checkbox" {{if .Repository.IsPrivate}}checked{{end}}> <input name="private" type="checkbox" {{if .Repository.IsPrivate}}checked{{end}}>
{{else}} {{else}}
<input name="private" type="checkbox" {{if .Repository.IsPrivate}}checked{{end}}{{if and $.ForcePrivate .Repository.IsPrivate}} readonly{{end}}> <input name="private" type="checkbox" {{if .Repository.IsPrivate}}checked{{end}}{{if and $.ForcePrivate .Repository.IsPrivate}} disabled{{end}}>
{{if and .Repository.IsPrivate $.ForcePrivate}}<input type="hidden" name="private" value="{{.Repository.IsPrivate}}">{{end}}
{{end}} {{end}}
<label>{{ctx.Locale.Tr "repo.visibility_helper"}} {{if .Repository.NumForks}}<span class="text red">{{ctx.Locale.Tr "repo.visibility_fork_helper"}}</span>{{end}}</label> <label>{{ctx.Locale.Tr "repo.visibility_helper"}} {{if .Repository.NumForks}}<span class="text red">{{ctx.Locale.Tr "repo.visibility_fork_helper"}}</span>{{end}}</label>
</div> </div>

Write Preview
Loading…
Cancel
Save