github-forks
/
easy-rules
mirror of https://github.com/j-easy/easy-rules.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use parametrized tests for rule factories

Browse Source
pull/284/head
Mahmoud Ben Hassine 5 years ago
parent 0575a9929c
commit c8b541b32c
No known key found for this signature in database
GPG Key ID: 79FCFB0A184E0036
4 changed files with 72 additions and 376 deletions
Show Stats Download Patch File Download Diff File

53
easy-rules-mvel/src/test/java/org/jeasy/rules/mvel/MVELJsonRuleFactoryTest.java → easy-rules-mvel/src/test/java/org/jeasy/rules/mvel/MVELRuleFactoryTest.java
Unescape Escape View File

@ -23,35 +23,53 @@
*/ */
package org.jeasy.rules.mvel; package org.jeasy.rules.mvel;
import org.jeasy.rules.api.Rule;
import org.jeasy.rules.api.Rules;
import org.jeasy.rules.support.reader.JsonRuleDefinitionReader;
import org.jeasy.rules.support.composite.UnitRuleGroup;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import java.io.File; import java.io.File;
import java.io.FileReader; import java.io.FileReader;
import java.io.Reader; import java.io.Reader;
import java.io.StringReader; import java.io.StringReader;
import java.nio.file.Files; import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths; import java.nio.file.Paths;
import java.util.Arrays;
import java.util.Collection;
import java.util.Iterator; import java.util.Iterator;
import org.jeasy.rules.api.Rule;
import org.jeasy.rules.api.Rules;
import org.jeasy.rules.support.composite.UnitRuleGroup;
import org.jeasy.rules.support.reader.JsonRuleDefinitionReader;
import org.jeasy.rules.support.reader.YamlRuleDefinitionReader;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
// TODO use parametrized test to merge this test class with MVELYamlRuleFactoryTest @RunWith(Parameterized.class)
public class MVELJsonRuleFactoryTest { public class MVELRuleFactoryTest {
@Parameterized.Parameters
public static Collection<Object[]> parameters() {
return Arrays.asList(new Object[][] {
{ new MVELRuleFactory(new YamlRuleDefinitionReader()), "yml" },
{ new MVELRuleFactory(new JsonRuleDefinitionReader()), "json" },
});
}
@org.junit.Rule @org.junit.Rule
public ExpectedException expectedException = ExpectedException.none(); public ExpectedException expectedException = ExpectedException.none();
private MVELRuleFactory factory = new MVELRuleFactory(new JsonRuleDefinitionReader()); @Parameterized.Parameter(0)
public MVELRuleFactory factory;
@Parameterized.Parameter(1)
public String fileExtension;
@Test @Test
public void testRulesCreation() throws Exception { public void testRulesCreation() throws Exception {
// given // given
File rulesDescriptor = new File("src/test/resources/rules.json"); File rulesDescriptor = new File("src/test/resources/rules." + fileExtension);
// when // when
Rules rules = factory.createRules(new FileReader(rulesDescriptor)); Rules rules = factory.createRules(new FileReader(rulesDescriptor));
@ -76,7 +94,7 @@ public class MVELJsonRuleFactoryTest {
@Test @Test
public void testRuleCreationFromFileReader() throws Exception { public void testRuleCreationFromFileReader() throws Exception {
// given // given
Reader adultRuleDescriptorAsReader = new FileReader("src/test/resources/adult-rule.json"); Reader adultRuleDescriptorAsReader = new FileReader("src/test/resources/adult-rule." + fileExtension);
// when // when
Rule adultRule = factory.createRule(adultRuleDescriptorAsReader); Rule adultRule = factory.createRule(adultRuleDescriptorAsReader);
@ -90,7 +108,8 @@ public class MVELJsonRuleFactoryTest {
@Test @Test
public void testRuleCreationFromStringReader() throws Exception { public void testRuleCreationFromStringReader() throws Exception {
// given // given
Reader adultRuleDescriptorAsReader = new StringReader(new String(Files.readAllBytes(Paths.get("src/test/resources/adult-rule.json")))); Path ruleDescriptor = Paths.get("src/test/resources/adult-rule." + fileExtension);
Reader adultRuleDescriptorAsReader = new StringReader(new String(Files.readAllBytes(ruleDescriptor)));
// when // when
Rule adultRule = factory.createRule(adultRuleDescriptorAsReader); Rule adultRule = factory.createRule(adultRuleDescriptorAsReader);
@ -104,7 +123,7 @@ public class MVELJsonRuleFactoryTest {
@Test @Test
public void testRuleCreationFromFileReader_withCompositeRules() throws Exception { public void testRuleCreationFromFileReader_withCompositeRules() throws Exception {
// given // given
File rulesDescriptor = new File("src/test/resources/composite-rules.json"); File rulesDescriptor = new File("src/test/resources/composite-rules." + fileExtension);
// when // when
Rules rules = factory.createRules(new FileReader(rulesDescriptor)); Rules rules = factory.createRules(new FileReader(rulesDescriptor));
@ -132,7 +151,7 @@ public class MVELJsonRuleFactoryTest {
// given // given
expectedException.expect(IllegalArgumentException.class); expectedException.expect(IllegalArgumentException.class);
expectedException.expectMessage("Invalid composite rule type, must be one of [UnitRuleGroup, ConditionalRuleGroup, ActivationRuleGroup]"); expectedException.expectMessage("Invalid composite rule type, must be one of [UnitRuleGroup, ConditionalRuleGroup, ActivationRuleGroup]");
File rulesDescriptor = new File("src/test/resources/composite-rule-invalid-composite-rule-type.json"); File rulesDescriptor = new File("src/test/resources/composite-rule-invalid-composite-rule-type." + fileExtension);
// when // when
Rule rule = factory.createRule(new FileReader(rulesDescriptor)); Rule rule = factory.createRule(new FileReader(rulesDescriptor));
@ -146,7 +165,7 @@ public class MVELJsonRuleFactoryTest {
// given // given
expectedException.expect(IllegalArgumentException.class); expectedException.expect(IllegalArgumentException.class);
expectedException.expectMessage("Composite rules must have composing rules specified"); expectedException.expectMessage("Composite rules must have composing rules specified");
File rulesDescriptor = new File("src/test/resources/composite-rule-invalid-empty-composing-rules.json"); File rulesDescriptor = new File("src/test/resources/composite-rule-invalid-empty-composing-rules." + fileExtension);
// when // when
Rule rule = factory.createRule(new FileReader(rulesDescriptor)); Rule rule = factory.createRule(new FileReader(rulesDescriptor));
@ -160,7 +179,7 @@ public class MVELJsonRuleFactoryTest {
// given // given
expectedException.expect(IllegalArgumentException.class); expectedException.expect(IllegalArgumentException.class);
expectedException.expectMessage("Non-composite rules cannot have composing rules"); expectedException.expectMessage("Non-composite rules cannot have composing rules");
File rulesDescriptor = new File("src/test/resources/non-composite-rule-with-composing-rules.json"); File rulesDescriptor = new File("src/test/resources/non-composite-rule-with-composing-rules." + fileExtension);
// when // when
Rule rule = factory.createRule(new FileReader(rulesDescriptor)); Rule rule = factory.createRule(new FileReader(rulesDescriptor));

171
easy-rules-mvel/src/test/java/org/jeasy/rules/mvel/MVELYamlRuleFactoryTest.java
Unescape Escape View File

@ -1,171 +0,0 @@
/*
* The MIT License
*
* Copyright (c) 2020, Mahmoud Ben Hassine (mahmoud.benhassine@icloud.com)
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/
package org.jeasy.rules.mvel;
import org.jeasy.rules.api.Rule;
import org.jeasy.rules.api.Rules;
import org.jeasy.rules.support.reader.YamlRuleDefinitionReader;
import org.jeasy.rules.support.composite.UnitRuleGroup;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import java.io.File;
import java.io.FileReader;
import java.io.Reader;
import java.io.StringReader;
import java.nio.file.Files;
import java.nio.file.Paths;
import java.util.Iterator;
import static org.assertj.core.api.Assertions.assertThat;
// TODO use parametrized test to merge this test class with MVELJsonRuleFactoryTest
public class MVELYamlRuleFactoryTest {
@org.junit.Rule
public ExpectedException expectedException = ExpectedException.none();
private MVELRuleFactory factory = new MVELRuleFactory(new YamlRuleDefinitionReader());
@Test
public void testRulesCreation() throws Exception {
// given
File rulesDescriptor = new File("src/test/resources/rules.yml");
// when
Rules rules = factory.createRules(new FileReader(rulesDescriptor));
// then
assertThat(rules).hasSize(2);
Iterator<Rule> iterator = rules.iterator();
Rule rule = iterator.next();
assertThat(rule).isNotNull();
assertThat(rule.getName()).isEqualTo("adult rule");
assertThat(rule.getDescription()).isEqualTo("when age is greater than 18, then mark as adult");
assertThat(rule.getPriority()).isEqualTo(1);
rule = iterator.next();
assertThat(rule).isNotNull();
assertThat(rule.getName()).isEqualTo("weather rule");
assertThat(rule.getDescription()).isEqualTo("when it rains, then take an umbrella");
assertThat(rule.getPriority()).isEqualTo(2);
}
@Test
public void testRuleCreationFromFileReader() throws Exception {
// given
Reader adultRuleDescriptorAsReader = new FileReader("src/test/resources/adult-rule.yml");
// when
Rule adultRule = factory.createRule(adultRuleDescriptorAsReader);
// then
assertThat(adultRule.getName()).isEqualTo("adult rule");
assertThat(adultRule.getDescription()).isEqualTo("when age is greater than 18, then mark as adult");
assertThat(adultRule.getPriority()).isEqualTo(1);
}
@Test
public void testRuleCreationFromStringReader() throws Exception {
// given
Reader adultRuleDescriptorAsReader = new StringReader(new String(Files.readAllBytes(Paths.get("src/test/resources/adult-rule.yml"))));
// when
Rule adultRule = factory.createRule(adultRuleDescriptorAsReader);
// then
assertThat(adultRule.getName()).isEqualTo("adult rule");
assertThat(adultRule.getDescription()).isEqualTo("when age is greater than 18, then mark as adult");
assertThat(adultRule.getPriority()).isEqualTo(1);
}
@Test
public void testRuleCreationFromFileReader_withCompositeRules() throws Exception {
// given
File rulesDescriptor = new File("src/test/resources/composite-rules.yml");
// when
Rules rules = factory.createRules(new FileReader(rulesDescriptor));
// then
assertThat(rules).hasSize(2);
Iterator<Rule> iterator = rules.iterator();
Rule rule = iterator.next();
assertThat(rule).isNotNull();
assertThat(rule.getName()).isEqualTo("Movie id rule");
assertThat(rule.getDescription()).isEqualTo("description");
assertThat(rule.getPriority()).isEqualTo(1);
assertThat(rule).isInstanceOf(UnitRuleGroup.class);
rule = iterator.next();
assertThat(rule).isNotNull();
assertThat(rule.getName()).isEqualTo("weather rule");
assertThat(rule.getDescription()).isEqualTo("when it rains, then take an umbrella");
assertThat(rule.getPriority()).isEqualTo(1);
}
@Test
public void testRuleCreationFromFileReader_withInvalidCompositeRuleType() throws Exception {
// given
expectedException.expect(IllegalArgumentException.class);
expectedException.expectMessage("Invalid composite rule type, must be one of [UnitRuleGroup, ConditionalRuleGroup, ActivationRuleGroup]");
File rulesDescriptor = new File("src/test/resources/composite-rule-invalid-composite-rule-type.yml");
// when
Rule rule = factory.createRule(new FileReader(rulesDescriptor));
// then
// expected exception
}
@Test
public void testRuleCreationFromFileReader_withEmptyComposingRules() throws Exception {
// given
expectedException.expect(IllegalArgumentException.class);
expectedException.expectMessage("Composite rules must have composing rules specified");
File rulesDescriptor = new File("src/test/resources/composite-rule-invalid-empty-composing-rules.yml");
// when
Rule rule = factory.createRule(new FileReader(rulesDescriptor));
// then
// expected exception
}
@Test
public void testRuleCreationFromFileReader_withNonCompositeRuleDeclaresComposingRules() throws Exception {
// given
expectedException.expect(IllegalArgumentException.class);
expectedException.expectMessage("Non-composite rules cannot have composing rules");
File rulesDescriptor = new File("src/test/resources/non-composite-rule-with-composing-rules.yml");
// when
Rule rule = factory.createRule(new FileReader(rulesDescriptor));
// then
// expected exception
}
}

53
easy-rules-spel/src/test/java/org/jeasy/rules/spel/SpELJsonRuleFactoryTest.java → easy-rules-spel/src/test/java/org/jeasy/rules/spel/SpELRuleFactoryTest.java
Unescape Escape View File

@ -23,35 +23,53 @@
*/ */
package org.jeasy.rules.spel; package org.jeasy.rules.spel;
import org.jeasy.rules.api.Rule;
import org.jeasy.rules.api.Rules;
import org.jeasy.rules.support.reader.JsonRuleDefinitionReader;
import org.jeasy.rules.support.composite.UnitRuleGroup;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import java.io.File; import java.io.File;
import java.io.FileReader; import java.io.FileReader;
import java.io.Reader; import java.io.Reader;
import java.io.StringReader; import java.io.StringReader;
import java.nio.file.Files; import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths; import java.nio.file.Paths;
import java.util.Arrays;
import java.util.Collection;
import java.util.Iterator; import java.util.Iterator;
import org.jeasy.rules.api.Rule;
import org.jeasy.rules.api.Rules;
import org.jeasy.rules.support.composite.UnitRuleGroup;
import org.jeasy.rules.support.reader.JsonRuleDefinitionReader;
import org.jeasy.rules.support.reader.YamlRuleDefinitionReader;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
// TODO use parametrized test to merge this test class with SpELYamlRuleFactoryTest @RunWith(Parameterized.class)
public class SpELJsonRuleFactoryTest { public class SpELRuleFactoryTest {
@Parameterized.Parameters
public static Collection<Object[]> parameters() {
return Arrays.asList(new Object[][] {
{ new SpELRuleFactory(new YamlRuleDefinitionReader()), "yml" },
{ new SpELRuleFactory(new JsonRuleDefinitionReader()), "json" },
});
}
@org.junit.Rule @org.junit.Rule
public ExpectedException expectedException = ExpectedException.none(); public ExpectedException expectedException = ExpectedException.none();
private SpELRuleFactory factory = new SpELRuleFactory(new JsonRuleDefinitionReader()); @Parameterized.Parameter(0)
public SpELRuleFactory factory;
@Parameterized.Parameter(1)
public String fileExtension;
@Test @Test
public void testRulesCreation() throws Exception { public void testRulesCreation() throws Exception {
// given // given
File rulesDescriptor = new File("src/test/resources/rules.json"); File rulesDescriptor = new File("src/test/resources/rules." + fileExtension);
// when // when
Rules rules = factory.createRules(new FileReader(rulesDescriptor)); Rules rules = factory.createRules(new FileReader(rulesDescriptor));
@ -76,7 +94,7 @@ public class SpELJsonRuleFactoryTest {
@Test @Test
public void testRuleCreationFromFileReader() throws Exception { public void testRuleCreationFromFileReader() throws Exception {
// given // given
Reader adultRuleDescriptorAsReader = new FileReader("src/test/resources/adult-rule.json"); Reader adultRuleDescriptorAsReader = new FileReader("src/test/resources/adult-rule." + fileExtension);
// when // when
Rule adultRule = factory.createRule(adultRuleDescriptorAsReader); Rule adultRule = factory.createRule(adultRuleDescriptorAsReader);
@ -90,7 +108,8 @@ public class SpELJsonRuleFactoryTest {
@Test @Test
public void testRuleCreationFromStringReader() throws Exception { public void testRuleCreationFromStringReader() throws Exception {
// given // given
Reader adultRuleDescriptorAsReader = new StringReader(new String(Files.readAllBytes(Paths.get("src/test/resources/adult-rule.json")))); Path ruleDescriptor = Paths.get("src/test/resources/adult-rule." + fileExtension);
Reader adultRuleDescriptorAsReader = new StringReader(new String(Files.readAllBytes(ruleDescriptor)));
// when // when
Rule adultRule = factory.createRule(adultRuleDescriptorAsReader); Rule adultRule = factory.createRule(adultRuleDescriptorAsReader);
@ -104,7 +123,7 @@ public class SpELJsonRuleFactoryTest {
@Test @Test
public void testRuleCreationFromFileReader_withCompositeRules() throws Exception { public void testRuleCreationFromFileReader_withCompositeRules() throws Exception {
// given // given
File rulesDescriptor = new File("src/test/resources/composite-rules.json"); File rulesDescriptor = new File("src/test/resources/composite-rules." + fileExtension);
// when // when
Rules rules = factory.createRules(new FileReader(rulesDescriptor)); Rules rules = factory.createRules(new FileReader(rulesDescriptor));
@ -132,7 +151,7 @@ public class SpELJsonRuleFactoryTest {
// given // given
expectedException.expect(IllegalArgumentException.class); expectedException.expect(IllegalArgumentException.class);
expectedException.expectMessage("Invalid composite rule type, must be one of [UnitRuleGroup, ConditionalRuleGroup, ActivationRuleGroup]"); expectedException.expectMessage("Invalid composite rule type, must be one of [UnitRuleGroup, ConditionalRuleGroup, ActivationRuleGroup]");
File rulesDescriptor = new File("src/test/resources/composite-rule-invalid-composite-rule-type.json"); File rulesDescriptor = new File("src/test/resources/composite-rule-invalid-composite-rule-type." + fileExtension);
// when // when
Rule rule = factory.createRule(new FileReader(rulesDescriptor)); Rule rule = factory.createRule(new FileReader(rulesDescriptor));
@ -146,7 +165,7 @@ public class SpELJsonRuleFactoryTest {
// given // given
expectedException.expect(IllegalArgumentException.class); expectedException.expect(IllegalArgumentException.class);
expectedException.expectMessage("Composite rules must have composing rules specified"); expectedException.expectMessage("Composite rules must have composing rules specified");
File rulesDescriptor = new File("src/test/resources/composite-rule-invalid-empty-composing-rules.json"); File rulesDescriptor = new File("src/test/resources/composite-rule-invalid-empty-composing-rules." + fileExtension);
// when // when
Rule rule = factory.createRule(new FileReader(rulesDescriptor)); Rule rule = factory.createRule(new FileReader(rulesDescriptor));
@ -160,7 +179,7 @@ public class SpELJsonRuleFactoryTest {
// given // given
expectedException.expect(IllegalArgumentException.class); expectedException.expect(IllegalArgumentException.class);
expectedException.expectMessage("Non-composite rules cannot have composing rules"); expectedException.expectMessage("Non-composite rules cannot have composing rules");
File rulesDescriptor = new File("src/test/resources/non-composite-rule-with-composing-rules.json"); File rulesDescriptor = new File("src/test/resources/non-composite-rule-with-composing-rules." + fileExtension);
// when // when
Rule rule = factory.createRule(new FileReader(rulesDescriptor)); Rule rule = factory.createRule(new FileReader(rulesDescriptor));

171
easy-rules-spel/src/test/java/org/jeasy/rules/spel/SpELYamlRuleFactoryTest.java
Unescape Escape View File

@ -1,171 +0,0 @@
/*
* The MIT License
*
* Copyright (c) 2020, Mahmoud Ben Hassine (mahmoud.benhassine@icloud.com)
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/
package org.jeasy.rules.spel;
import org.jeasy.rules.api.Rule;
import org.jeasy.rules.api.Rules;
import org.jeasy.rules.support.composite.UnitRuleGroup;
import org.jeasy.rules.support.reader.YamlRuleDefinitionReader;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import java.io.File;
import java.io.FileReader;
import java.io.Reader;
import java.io.StringReader;
import java.nio.file.Files;
import java.nio.file.Paths;
import java.util.Iterator;
import static org.assertj.core.api.Assertions.assertThat;
// TODO use parametrized test to merge this test class with SpELJsonRuleFactoryTest
public class SpELYamlRuleFactoryTest {
@org.junit.Rule
public ExpectedException expectedException = ExpectedException.none();
private SpELRuleFactory factory = new SpELRuleFactory(new YamlRuleDefinitionReader());
@Test
public void testRulesCreation() throws Exception {
// given
File rulesDescriptor = new File("src/test/resources/rules.yml");
// when
Rules rules = factory.createRules(new FileReader(rulesDescriptor));
// then
assertThat(rules).hasSize(2);
Iterator<Rule> iterator = rules.iterator();
Rule rule = iterator.next();
assertThat(rule).isNotNull();
assertThat(rule.getName()).isEqualTo("adult rule");
assertThat(rule.getDescription()).isEqualTo("when age is greater than 18, then mark as adult");
assertThat(rule.getPriority()).isEqualTo(1);
rule = iterator.next();
assertThat(rule).isNotNull();
assertThat(rule.getName()).isEqualTo("weather rule");
assertThat(rule.getDescription()).isEqualTo("when it rains, then take an umbrella");
assertThat(rule.getPriority()).isEqualTo(2);
}
@Test
public void testRuleCreationFromFileReader() throws Exception {
// given
Reader adultRuleDescriptorAsReader = new FileReader("src/test/resources/adult-rule.yml");
// when
Rule adultRule = factory.createRule(adultRuleDescriptorAsReader);
// then
assertThat(adultRule.getName()).isEqualTo("adult rule");
assertThat(adultRule.getDescription()).isEqualTo("when age is greater than 18, then mark as adult");
assertThat(adultRule.getPriority()).isEqualTo(1);
}
@Test
public void testRuleCreationFromStringReader() throws Exception {
// given
Reader adultRuleDescriptorAsReader = new StringReader(new String(Files.readAllBytes(Paths.get("src/test/resources/adult-rule.yml"))));
// when
Rule adultRule = factory.createRule(adultRuleDescriptorAsReader);
// then
assertThat(adultRule.getName()).isEqualTo("adult rule");
assertThat(adultRule.getDescription()).isEqualTo("when age is greater than 18, then mark as adult");
assertThat(adultRule.getPriority()).isEqualTo(1);
}
@Test
public void testRuleCreationFromFileReader_withCompositeRules() throws Exception {
// given
File rulesDescriptor = new File("src/test/resources/composite-rules.yml");
// when
Rules rules = factory.createRules(new FileReader(rulesDescriptor));
// then
assertThat(rules).hasSize(2);
Iterator<Rule> iterator = rules.iterator();
Rule rule = iterator.next();
assertThat(rule).isNotNull();
assertThat(rule.getName()).isEqualTo("Movie id rule");
assertThat(rule.getDescription()).isEqualTo("description");
assertThat(rule.getPriority()).isEqualTo(1);
assertThat(rule).isInstanceOf(UnitRuleGroup.class);
rule = iterator.next();
assertThat(rule).isNotNull();
assertThat(rule.getName()).isEqualTo("weather rule");
assertThat(rule.getDescription()).isEqualTo("when it rains, then take an umbrella");
assertThat(rule.getPriority()).isEqualTo(1);
}
@Test
public void testRuleCreationFromFileReader_withInvalidCompositeRuleType() throws Exception {
// given
expectedException.expect(IllegalArgumentException.class);
expectedException.expectMessage("Invalid composite rule type, must be one of [UnitRuleGroup, ConditionalRuleGroup, ActivationRuleGroup]");
File rulesDescriptor = new File("src/test/resources/composite-rule-invalid-composite-rule-type.yml");
// when
Rule rule = factory.createRule(new FileReader(rulesDescriptor));
// then
// expected exception
}
@Test
public void testRuleCreationFromFileReader_withEmptyComposingRules() throws Exception {
// given
expectedException.expect(IllegalArgumentException.class);
expectedException.expectMessage("Composite rules must have composing rules specified");
File rulesDescriptor = new File("src/test/resources/composite-rule-invalid-empty-composing-rules.yml");
// when
Rule rule = factory.createRule(new FileReader(rulesDescriptor));
// then
// expected exception
}
@Test
public void testRuleCreationFromFileReader_withNonCompositeRuleDeclaresComposingRules() throws Exception {
// given
expectedException.expect(IllegalArgumentException.class);
expectedException.expectMessage("Non-composite rules cannot have composing rules");
File rulesDescriptor = new File("src/test/resources/non-composite-rule-with-composing-rules.yml");
// when
Rule rule = factory.createRule(new FileReader(rulesDescriptor));
// then
// expected exception
}
}
Write Preview
Loading…
Cancel
Save