github-forks
/
easy-rules
mirror of https://github.com/j-easy/easy-rules.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Move common rule factories code in an abstract class

Browse Source
pull/210/head
Mahmoud Ben Hassine 6 years ago
parent 4b3f7aea61
commit 05e063ba6b
3 changed files with 92 additions and 90 deletions
Show Stats Download Patch File Download Diff File

50
easy-rules-mvel/src/main/java/org/jeasy/rules/mvel/MVELRuleFactory.java
Unescape Escape View File

@ -29,7 +29,6 @@ import org.jeasy.rules.support.*;
import org.mvel2.ParserContext;
import java.io.Reader;
import java.util.Arrays;
import java.util.List;
/**
@ -37,16 +36,10 @@ import java.util.List;
*
* @author Mahmoud Ben Hassine (mahmoud.benhassine@icloud.com)
*/
public class MVELRuleFactory {
public class MVELRuleFactory extends AbstractRuleFactory<ParserContext> {
private RuleDefinitionReader reader;
private static final List<String> ALLOWED_COMPOSITE_RULE_TYPES = Arrays.asList(
UnitRuleGroup.class.getSimpleName(),
ConditionalRuleGroup.class.getSimpleName(),
ActivationRuleGroup.class.getSimpleName()
);
/**
* Create a new {@link MVELRuleFactory} with a given reader.
*
@ -105,22 +98,14 @@ public class MVELRuleFactory {
*/
public Rules createRules(Reader rulesDescriptor, ParserContext parserContext) throws Exception {
Rules rules = new Rules();
List<RuleDefinition> ruleDefinition = reader.read(rulesDescriptor);
for (RuleDefinition mvelRuleDefinition : ruleDefinition) {
rules.register(createRule(mvelRuleDefinition, parserContext));
List<RuleDefinition> ruleDefinitions = reader.read(rulesDescriptor);
for (RuleDefinition ruleDefinition : ruleDefinitions) {
rules.register(createRule(ruleDefinition, parserContext));
}
return rules;
}
private static Rule createRule(RuleDefinition ruleDefinition, ParserContext context) {
if (ruleDefinition.isCompositeRule()) {
return createCompositeRule(ruleDefinition, context);
} else {
return createSimpleRule(ruleDefinition, context);
}
}
private static Rule createSimpleRule(RuleDefinition ruleDefinition, ParserContext parserContext) {
protected Rule createSimpleRule(RuleDefinition ruleDefinition, ParserContext parserContext) {
MVELRule mvelRule = new MVELRule()
.name(ruleDefinition.getName())
.description(ruleDefinition.getDescription())
@ -132,29 +117,4 @@ public class MVELRuleFactory {
return mvelRule;
}
private static Rule createCompositeRule(RuleDefinition ruleDefinition, ParserContext parserContext) {
CompositeRule compositeRule;
String name = ruleDefinition.getName();
switch (ruleDefinition.getCompositeRuleType()) {
case "UnitRuleGroup":
compositeRule = new UnitRuleGroup(name);
break;
case "ActivationRuleGroup":
compositeRule = new ActivationRuleGroup(name);
break;
case "ConditionalRuleGroup":
compositeRule = new ConditionalRuleGroup(name);
break;
default:
throw new IllegalArgumentException("Invalid composite rule type, must be one of " + ALLOWED_COMPOSITE_RULE_TYPES);
}
compositeRule.setDescription(ruleDefinition.getDescription());
compositeRule.setPriority(ruleDefinition.getPriority());
for (RuleDefinition composingRuleDefinition : ruleDefinition.getComposingRules()) {
compositeRule.addRule(createRule(composingRuleDefinition, parserContext));
}
return compositeRule;
}
}

50
easy-rules-spel/src/main/java/org/jeasy/rules/spel/SpELRuleFactory.java
Unescape Escape View File

@ -30,7 +30,6 @@ import org.springframework.expression.ParserContext;
import org.springframework.expression.common.TemplateParserContext;
import java.io.Reader;
import java.util.Arrays;
import java.util.List;
/**
@ -38,16 +37,10 @@ import java.util.List;
*
* @author Mahmoud Ben Hassine (mahmoud.benhassine@icloud.com)
*/
public class SpELRuleFactory {
public class SpELRuleFactory extends AbstractRuleFactory<ParserContext> {
private RuleDefinitionReader reader;
private static final List<String> ALLOWED_COMPOSITE_RULE_TYPES = Arrays.asList(
UnitRuleGroup.class.getSimpleName(),
ConditionalRuleGroup.class.getSimpleName(),
ActivationRuleGroup.class.getSimpleName()
);
/**
* Create a new {@link SpELRuleFactory} with a given reader.
*
@ -106,22 +99,14 @@ public class SpELRuleFactory {
*/
public Rules createRules(Reader rulesDescriptor, ParserContext parserContext) throws Exception {
Rules rules = new Rules();
List<RuleDefinition> ruleDefinition = reader.read(rulesDescriptor);
for (RuleDefinition spelRuleDefinition : ruleDefinition) {
rules.register(createRule(spelRuleDefinition, parserContext));
List<RuleDefinition> ruleDefinitions = reader.read(rulesDescriptor);
for (RuleDefinition ruleDefinition : ruleDefinitions) {
rules.register(createRule(ruleDefinition, parserContext));
}
return rules;
}
private static Rule createRule(RuleDefinition ruleDefinition, ParserContext context) {
if (ruleDefinition.isCompositeRule()) {
return createCompositeRule(ruleDefinition, context);
} else {
return createSimpleRule(ruleDefinition, context);
}
}
private static Rule createSimpleRule(RuleDefinition ruleDefinition, ParserContext parserContext) {
protected Rule createSimpleRule(RuleDefinition ruleDefinition, ParserContext parserContext) {
SpELRule spELRule = new SpELRule()
.name(ruleDefinition.getName())
.description(ruleDefinition.getDescription())
@ -133,29 +118,4 @@ public class SpELRuleFactory {
return spELRule;
}
private static Rule createCompositeRule(RuleDefinition ruleDefinition, ParserContext parserContext) {
CompositeRule compositeRule;
String name = ruleDefinition.getName();
switch (ruleDefinition.getCompositeRuleType()) {
case "UnitRuleGroup":
compositeRule = new UnitRuleGroup(name);
break;
case "ActivationRuleGroup":
compositeRule = new ActivationRuleGroup(name);
break;
case "ConditionalRuleGroup":
compositeRule = new ConditionalRuleGroup(name);
break;
default:
throw new IllegalArgumentException("Invalid composite rule type, must be one of " + ALLOWED_COMPOSITE_RULE_TYPES);
}
compositeRule.setDescription(ruleDefinition.getDescription());
compositeRule.setPriority(ruleDefinition.getPriority());
for (RuleDefinition composingRuleDefinition : ruleDefinition.getComposingRules()) {
compositeRule.addRule(createRule(composingRuleDefinition, parserContext));
}
return compositeRule;
}
}

82
easy-rules-support/src/main/java/org/jeasy/rules/support/AbstractRuleFactory.java
Unescape Escape View File

@ -0,0 +1,82 @@
/**
* The MIT License
*
* Copyright (c) 2019, Mahmoud Ben Hassine (mahmoud.benhassine@icloud.com)
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/
package org.jeasy.rules.support;
import org.jeasy.rules.api.Rule;
import java.util.Arrays;
import java.util.List;
/**
* Base class for rule factories.
*
* @param <C> parser context type
*
* @author Mahmoud Ben Hassine (mahmoud.benhassine@icloud.com)
*/
public abstract class AbstractRuleFactory<C> {
private static final List<String> ALLOWED_COMPOSITE_RULE_TYPES = Arrays.asList(
UnitRuleGroup.class.getSimpleName(),
ConditionalRuleGroup.class.getSimpleName(),
ActivationRuleGroup.class.getSimpleName()
);
protected Rule createRule(RuleDefinition ruleDefinition, C context) {
if (ruleDefinition.isCompositeRule()) {
return createCompositeRule(ruleDefinition, context);
} else {
return createSimpleRule(ruleDefinition, context);
}
}
protected abstract Rule createSimpleRule(RuleDefinition ruleDefinition, C parserContext);
protected Rule createCompositeRule(RuleDefinition ruleDefinition, C parserContext) {
CompositeRule compositeRule;
String name = ruleDefinition.getName();
switch (ruleDefinition.getCompositeRuleType()) {
case "UnitRuleGroup":
compositeRule = new UnitRuleGroup(name);
break;
case "ActivationRuleGroup":
compositeRule = new ActivationRuleGroup(name);
break;
case "ConditionalRuleGroup":
compositeRule = new ConditionalRuleGroup(name);
break;
default:
throw new IllegalArgumentException("Invalid composite rule type, must be one of " + ALLOWED_COMPOSITE_RULE_TYPES);
}
compositeRule.setDescription(ruleDefinition.getDescription());
compositeRule.setPriority(ruleDefinition.getPriority());
for (RuleDefinition composingRuleDefinition : ruleDefinition.getComposingRules()) {
compositeRule.addRule(createRule(composingRuleDefinition, parserContext));
}
return compositeRule;
}
}
Write Preview
Loading…
Cancel
Save