potential NPE in Base64Command (#1993)

3 years ago · d88a2e93d1
parent da0ab96ea8
commit d88a2e93d1
1 changed files with 7 additions and 2 deletions
--- a/core/src/main/java/com/taobao/arthas/core/command/basic1000/Base64Command.java
+++ b/core/src/main/java/com/taobao/arthas/core/command/basic1000/Base64Command.java
@ -87,8 +87,13 @@ public class Base64Command extends AnnotatedCommand {
        }

        // 确认输入
-        if (file == null && this.input != null) {
-            file = input;
+        if (file == null) {
+            if (this.input != null) {
+                file = input;
+            } else {
+                process.end(-1, ": No file, nor input");
+                return;
+            }
        }

        File f = new File(file);