Commit Graph

5085 Commits (bf50fce5bd2bcd58582e6768350de96aeb881d90)
 

Author SHA1 Message Date
neil bf50fce5bd fix https://github.com/acmesh-official/acme.sh/issues/4470 2 years ago
neil 8718b156c4
Merge pull request #4471 from vladislav-sharapov/patch-1
fix(dns_openstack): fix argparse error
2 years ago
Vladislav Sharapov 7bbdd1f839 fix(dns_openstack): fix argparse error
Add equal sign to '--record' option to fix argparse error
occurring when ACME token starts with '-'.
2 years ago
neil ffed1a4afa
Merge pull request #4468 from DreamOfIce/master
Update deploy script for gcore
2 years ago
冰雪殇璃陌梦 1bfd3642e8
Update gcore_cdn.sh 2 years ago
neil 577f4e0cc3
Merge pull request #4430 from zpeschke/gd_grammar
Minor grammar fixes for gd
2 years ago
neil e2f05f3fc9
Merge pull request #4413 from trulyliu/dev
Add gcore dns support.
2 years ago
Gavin Leo 27f30631ed Add gcore dns support.
https://apidocs.gcore.com/dns
2 years ago
neil a2c64e79ff fix for openbsd 2 years ago
neil 7b623f85cd minor 2 years ago
neil 75d2898efd
Merge pull request #4441 from plummer86/bugfix/_wget_out_fix
Fix assignment: _wget_out
2 years ago
plummer86 764a4c99fa Fix assignment to _wget_out 2 years ago
Zachary Peschke 160513c671 Minor grammar fixes for gd 2 years ago
neil a2af26635f use ecc cert 2 years ago
neil 63869deeb2
Merge pull request #4091 from PMExtra/feature/ssh_scp
Refact ssh hook to use deploy config, support scp and support specifying port
2 years ago
neil 699d2b7e7e
Merge pull request #4409 from hatamiarash7/patch-1
Update ArvanCloud API URL - Security & CI problem
2 years ago
Arash Hatami 257de15c73
Fix export problems 2 years ago
Arash Hatami 5a0225d033
Fix export problem for special values 2 years ago
Arash Hatami 0c0d1d4e52
Update duplicate message 2 years ago
Arash Hatami eab9603921
Fix SH format 2 years ago
Arash Hatami c07db3aa14
add 'Accept' header 2 years ago
neil a19f7481b2
Merge pull request #4410 from kirisakow/patch-1
Trim trailing slash in `--home` argument's value from the get-go to avoid that subsequently created paths contain two adjacent slashes in the middle
2 years ago
Kiril Isakov 264b9819ff
Replace the BASH parameter substitution mechanism (unsupported by sh) with standard commands (supported by sh) 2 years ago
Arash Hatami 4610204c83
Test CI 2 years ago
neil ecf1f17cf4 update key type 2 years ago
Kiril Isakov 9f942a6b65
Trim trailing slash in `--home` argument's value
# What's expected

Since in `acme.sh` path strings are concatenated with a hardcoded slash in between, the left operand must never end with a trailing slash for the resulting path to be valid. Otherwise, obviously, the resulting path will have two adjacent slashes in the middle and will not be valid.

# What actually happens

Even though I cannot tell for each of the input params, I know this for sure for the the `--home` argument's value.

If I run `acme.sh` with `--home` argument's value being a path ending in a trailing slash,

```sh
acme.sh ... --debug ... --home /some/path/ ... -d somedomainna.me ...
```

I get the following (distinct) occurrencies of resulting invalid paths containing two adjacent slashes:

```
[...] Using config home:/some/path/

[...] DOMAIN_PATH='/some/path//somedomainna.me'

[...] _CURL='curl --silent --dump-header /some/path//http.header  -L  -g '

[...] The domain key is here: /some/path//somedomainna.me/somedomainna.me.key

[...] _CURL='curl --silent --dump-header /some/path//http.header  -L  -g  -I  '

[...] Your cert is in: /some/path//somedomainna.me/somedomainna.me.cer

[...] Your cert key is in: /some/path//somedomainna.me/somedomainna.me.key

[...] The intermediate CA cert is in: /some/path//somedomainna.me/ca.cer

[...] And the full chain certs is there: /some/path//somedomainna.me/fullchain.cer

```

# Suggested fix

Trim trailing slash in `--home` argument's value from the get-go.
2 years ago
Arash Hatami f4ed1b32b8
Update dns_arvan.sh
Update API URL
2 years ago
neil ec0e871592 Use ec-256 as default key length
fix https://github.com/acmesh-official/acme.sh/issues/2350#issuecomment-1324029469
2 years ago
neil 7a756ebc4d start v3.0.6 2 years ago
neil 16dc21afff
Merge pull request #4406 from acmesh-official/dev
sync
2 years ago
neil 3a1c6d84f0 fix shellcheck warnings 2 years ago
neil e684abdacd fix checkout 2 years ago
neil e275cb1efd fix shellcheck warnings 2 years ago
neil 60315e5b91 fix shellcheck warnings 2 years ago
neil 43b1a4bf5a
Merge pull request #4405 from acmesh-official/dev
sync
2 years ago
neil cdb238e41c fix cf-tunnel 2 years ago
neil 3871e44d9c
Merge pull request #4400 from waja/docker_alpine_update
Docker alpine update
2 years ago
Jan Wagner 5a51454d13 Update Alpine to 1.16.3
With #4399 applied we can pick minor versions safely.
2 years ago
neil d102943a32 upgrade actions/checkout@v3 2 years ago
neil a0b27ddbd8
Merge pull request #4372 from PeterDaveHello/speedup-ci
Reduce `acmetest` `git clone` depth to speed up CI pipeline
2 years ago
neil b950b04e89
Merge pull request #4371 from PeterDaveHello/use-https
Use encrypted https instead of plain-text http when we can
2 years ago
neil c9a55f395b fix doh
https://github.com/acmesh-official/acme.sh/issues/4369
2 years ago
Peter Dave Hello 424da01878 Reduce acmetest git clone depth to speed up CI pipeline 2 years ago
Peter Dave Hello 3c933158c8 Use encrypted https instead of plain-text http when we can 2 years ago
neil 7221d488e5
Merge pull request #4365 from acmesh-official/dev
sync
2 years ago
neil 1c16931e26 add Le_Next_Domain_Key for tlsa
fix https://github.com/acmesh-official/acme.sh/issues/3096
Usage: https://github.com/acmesh-official/acme.sh/wiki/tlsa-next-key
2 years ago
neil 0a4b70dbd2
Merge pull request #4349 from tcx4c70/fix/save-conf
Fix error during saving conf
2 years ago
Adam Tao 666c716bda Fix error during saving conf
There might be '|' in __val (e.g., SYNO_Password), which will cause that
all content of the conf file is cleared. Fix it by escaping '|'
manually.

Signed-off-by: Adam Tao <tcx4c70@gmail.com>
2 years ago
neil be477d7ae3
Merge pull request #4259 from Mon-ius/master
fix a issue, when profile not end with newline
2 years ago
neil 6c8a623b88
Merge pull request #4329 from lippertmarkus/patch-1
[Deploy: synology_dsm] Make usage of DID with 2FA working for DSM 7
2 years ago