Commit Graph

5107 Commits (ba9d146d6c615ab5ec4ede949602880246d17d05)
 

Author SHA1 Message Date
neilpang ba9d146d6c fix https://github.com/acmesh-official/acme.sh/issues/992
neilpang 01249d0cb9 fix warning
neilpang aa9cbf7c55 fix https://github.com/acmesh-official/acme.sh/issues/992
neilpang 2690c05781 fix format
neilpang e3b688c9d8 fix format
neilpang 41b6f18a5d fix format
neilpang 5a59c39036 fix format
neil a02dd18ad7
Merge pull request from beartom/master
Update truenas.sh to deploy certificate for TrueCharts
neil 16bdc7d0a3 fix from OpenAI https://github.com/acmesh-official/acme.sh/issues/992
https://github.com/acmesh-official/acme.sh/pull/2609
neil 40002e8040
Merge pull request from PMExtra/feature/vault
improve vault and vault_cli deployhooks
neil 6748c55c04 fix stepca
neil deb63b4adf fix stepca
neil 015a9b9271 fix notify
neil ab2305e259 fix stepca
neil b99c998057 fix https://github.com/acmesh-official/acme.sh/issues/4463
neil 6c0a7144f6 fix https://github.com/acmesh-official/acme.sh/issues/4445
neil bf50fce5bd fix https://github.com/acmesh-official/acme.sh/issues/4470
neil 8718b156c4
Merge pull request from vladislav-sharapov/patch-1
fix(dns_openstack): fix argparse error
Vladislav Sharapov 7bbdd1f839 fix(dns_openstack): fix argparse error
Add equal sign to '--record' option to fix argparse error
occurring when ACME token starts with '-'.
neil ffed1a4afa
Merge pull request from DreamOfIce/master
Update deploy script for gcore
冰雪殇璃陌梦 1bfd3642e8
Update gcore_cdn.sh
neil 577f4e0cc3
Merge pull request from zpeschke/gd_grammar
Minor grammar fixes for gd
neil e2f05f3fc9
Merge pull request from trulyliu/dev
Add gcore dns support.
Gavin Leo 27f30631ed Add gcore dns support.
https://apidocs.gcore.com/dns
PMExtra 1ccfa96c2e improve logging
neil a2c64e79ff fix for openbsd
neil 7b623f85cd minor
PMExtra ed63eb6833 migrate FABIO to VAULT_FABIO_MODE and persist it
PMExtra b8d0d3c242 improve chain.pem exists evaluating
PMExtra fe1bfe9ae1 improve vault and vault_api deployhooks
neil 75d2898efd
Merge pull request from plummer86/bugfix/_wget_out_fix
Fix assignment: _wget_out
plummer86 764a4c99fa Fix assignment to _wget_out
Zachary Peschke 160513c671 Minor grammar fixes for gd
neil a2af26635f use ecc cert
neil 63869deeb2
Merge pull request from PMExtra/feature/ssh_scp
Refact ssh hook to use deploy config, support scp and support specifying port
neil 699d2b7e7e
Merge pull request from hatamiarash7/patch-1
Update ArvanCloud API URL - Security & CI problem
Arash Hatami 257de15c73
Fix export problems
Arash Hatami 5a0225d033
Fix export problem for special values
beartom bd2d0e6ad3
Format
Format
Arash Hatami 0c0d1d4e52
Update duplicate message
Arash Hatami eab9603921
Fix SH format
Arash Hatami c07db3aa14
add 'Accept' header
neil a19f7481b2
Merge pull request from kirisakow/patch-1
Trim trailing slash in `--home` argument's value from the get-go to avoid that subsequently created paths contain two adjacent slashes in the middle
beartom 04a5d794ac
Update truenas.sh for certificate in chart release
Update certificate in chart release of TrueCharts if any chart release Apps is using the same certificate as TrueNAS web UI.
Kiril Isakov 264b9819ff
Replace the BASH parameter substitution mechanism (unsupported by sh) with standard commands (supported by sh)
Arash Hatami 4610204c83
Test CI
neil ecf1f17cf4 update key type
Kiril Isakov 9f942a6b65
Trim trailing slash in `--home` argument's value
# What's expected

Since in `acme.sh` path strings are concatenated with a hardcoded slash in between, the left operand must never end with a trailing slash for the resulting path to be valid. Otherwise, obviously, the resulting path will have two adjacent slashes in the middle and will not be valid.

# What actually happens

Even though I cannot tell for each of the input params, I know this for sure for the the `--home` argument's value.

If I run `acme.sh` with `--home` argument's value being a path ending in a trailing slash,

```sh
acme.sh ... --debug ... --home /some/path/ ... -d somedomainna.me ...
```

I get the following (distinct) occurrencies of resulting invalid paths containing two adjacent slashes:

```
[...] Using config home:/some/path/

[...] DOMAIN_PATH='/some/path//somedomainna.me'

[...] _CURL='curl --silent --dump-header /some/path//http.header  -L  -g '

[...] The domain key is here: /some/path//somedomainna.me/somedomainna.me.key

[...] _CURL='curl --silent --dump-header /some/path//http.header  -L  -g  -I  '

[...] Your cert is in: /some/path//somedomainna.me/somedomainna.me.cer

[...] Your cert key is in: /some/path//somedomainna.me/somedomainna.me.key

[...] The intermediate CA cert is in: /some/path//somedomainna.me/ca.cer

[...] And the full chain certs is there: /some/path//somedomainna.me/fullchain.cer

```

# Suggested fix

Trim trailing slash in `--home` argument's value from the get-go.
Arash Hatami f4ed1b32b8
Update dns_arvan.sh
Update API URL
neil ec0e871592 Use ec-256 as default key length
fix https://github.com/acmesh-official/acme.sh/issues/2350#issuecomment-1324029469