4e0fcb11d1
Update for Micrometer.rc3 ( #1016 )
7 years ago
ea69484991
Fix javadoc
7 years ago
0ba37fc796
Fix javadoc
7 years ago
06e0cf6cf5
Update to match Micrometer updated RC api ( #1002 )
8 years ago
4b796b5209
Clean up and better JavaDoc.
8 years ago
5e508962a0
Fixes #1003 add SQL State 0A000 to eviction list.
8 years ago
8ec0c63282
test that FastList#clear() sets all elements to null ( #1001 )
8 years ago
4d484ea635
Rename copyState to copyStateTo ( #991 )
...
Fixes #892 and should prevent further confusion.
8 years ago
d6a9cd435c
Fixes #983 fix logic that determines how many idle connections can be removed, without violating the minimumIdle contract.
8 years ago
6735fcfe3a
Closes #989 Merged the parts I agree with.
8 years ago
e3ed1350d7
Minor cleanup.
8 years ago
8ec60dcde8
Fallback to four digit random pool name and log INFO
8 years ago
7cf6673f48
Add the thread name to potential leak detection warnings. ( #987 )
...
* Added thread name to leak detection warnings.
* Changed message 'from thread' to 'on thread'.
8 years ago
2a9e0185e4
Fix NPE caused by merge.
8 years ago
43b423cc5a
Log better message when connection was evicted or dead. ( #977 )
8 years ago
63f6ff371f
Fixed ClassNotFoundException when com.codahale.metrics.MetricRegistry is not in the classpath ( #984 )
...
* Fixed ClassNotFoundException when com.codahale.metrics.MetricRegistry is not in the classpath
* Changed equals to contains to handle CompositeMeterRegistry
8 years ago
238041f9e5
Fix test case failure.
8 years ago
3dc9b19c17
Fixes #982 attempt driver class load from thread context classloader first.
8 years ago
f8cc907f24
Test for javassist code generation.
8 years ago
f75b0896de
Fixes #967 incorrect bitwise operator value in ConcurrentBag.requite method intended to cause parkNanos() to be called every 256 iterations. Thanks to @ztkmkoo for finding this.
8 years ago
ac9f53ee9e
Fixes #968 Wrong label order in MicrometerMetricsTracker for the connection usage metric.
8 years ago
1528a10fc8
Alpha-level support for micrometer metrics
8 years ago
051f78c276
Alpha-level support for micrometer metrics
8 years ago
186455d8f2
Remove unused dependency.
8 years ago
57acec1bcf
fixes #955 fix possible race condition when Statements are closed on different threads from which they were created.
8 years ago
78d12ea0cf
Fix Prometheus metric collector for multiple data config ( #940 )
8 years ago
47b827d11e
Fixes #929 length the shutdown timeouts to 10 seconds. Beyond this,
...
user's need to poll the pool themselves if they want to wait for all the
connections to disappear.
8 years ago
ff95f480aa
Fixes #941 add support for specifying a default schema.
8 years ago
fc3a9eecb2
Mask password in JDBC URL ( #905 )
8 years ago
2a0a065b24
Introduce factory for leak detection tasks ( #943 )
...
This change splits off a ProxyLeakTaskFactory from the ProxyLeakTask class
so that scheduling the task is done after its constructor completes. This
prevents publishing the tasks "this" reference during construction.
See "Safe construction techniques" by Brian Goetz.
8 years ago
ae9d52a362
Fixes #878 Searching for driverClass in both hikari class classloader and Thread Context ClassLoader ( #902 )
8 years ago
fa79e4ece0
Fix prometheus metrics to support multiple hikaricp pools ( #890 )
8 years ago
3d53056583
Fix braces style ( #888 )
8 years ago
61be9b923d
Fixes #880 Fix race condition caused by sorting collection
...
while the condition of sort can change.
8 years ago
b626396496
Added support for non-default Prometheus CollectorRegistry ( #876 )
...
* Added support for using a Prometheus CollectorRegistry other than the default one
* Fixed a broken test
8 years ago
e62e85cee8
Extend timeout for Java 9. Will investigate why it is
...
necessary on travis-ci later.
8 years ago
04f6d4a2bd
Make test resilient to fluctuating pool names, caused by
...
reuse or non-reuse of forks during testing.
8 years ago
f1f7873432
Resolve unit test failures.
8 years ago
8db418f969
Reset log levels reliably.
8 years ago
25fde9c11d
Suppress tests currently untestable under Java 9 (when building on Java 9).
8 years ago
9e9a97508c
Comment #867 Support network timeout even for Connection.isValid().
8 years ago
f9ee36e339
Fixes #866 mark commit state dirty when Connection.getMetaData() is called.
8 years ago
304ca41775
Add additional MBean test.
8 years ago
15df8ba563
Fixes #835 reduce spinning on connection return when the pool is
...
saturated by introducing a ~10 microsecond sleep every 256
iterations, otherwise yield() is used, which introduces an approx.
300ns delay.
8 years ago
3150673da8
Fixes #835 new change to reduce spinning on connection return
...
when the pool is saturated.
8 years ago
db0db670b4
Fixes#835 prevent barging when the pool is saturated
8 years ago
0b5650bde7
Unit test for over-saturated pool with traffic dropping to agreement
...
with capacity.
8 years ago
65171205d6
Unit test for over-saturated pool with traffic dropping to agreement
...
with capacity.
8 years ago
e7a3e39f9b
Better place to capture pool.Wait metric ( #831 )
...
@wvuong Thanks. Yes, that is better.
8 years ago
1a6dc211dd
Fixes#821 If a disconnection class exception is thrown, do not set the flag that
...
indicates that checkDriverSupport() is complete.
8 years ago
41900e07aa
Fix PrometheusMetricsTrackerTest
8 years ago
d875e838c3
pool.Wait metric doesn't include timed out requests
...
We noticed that the pool.Wait metric only captured the timings for successful connection requests and doesn't capture when a connection request times out.
I didn't want to mess with IMetricsTrackerDelegate.recordBorrowStats() so I created a recordBorrowTimeoutStats() and implementation in MetricsTrackerDelegate instead. Feel free to tweak to your liking.
8 years ago
5c8b359b17
Add warning suppression.
8 years ago
2f31939cae
Add warning suppression.
8 years ago
0ab35e7445
Minor cleanup.
8 years ago
2414ebdaa4
Queue immediate replacement of retired maxLifetime connection.
8 years ago
8c7033a335
Fixes #742 Add MXBean accessors to HikariDataSource to facilitate
...
implementation of "graceful" shutdown when JMX is not enabled.
8 years ago
ef7da7dad4
Minor cleanup.
8 years ago
b2cd44f97d
Remove deprecated method call.
8 years ago
ea3043dea2
Fixes #817 restore former failfast=false behavior by completely
...
bypassing the connection validation if initializationFailTimeout is
negative.
8 years ago
8433e8bd53
Remove unused classes.
8 years ago
243490773b
Move TestFastList, add iterator test.
8 years ago
1587198e6a
Change the internal handling of the initializationFailTimeout.
8 years ago
a2717e565b
Fix race condition edge case.
8 years ago
d9cc246342
Minor cleanup.
8 years ago
75b697a25c
Cleanup.
8 years ago
b06eb02b6d
MetricsTracker refactor.
8 years ago
8bb6d1e525
DRY.
8 years ago
907da6a2cc
Fixes #793 introduce new methods for scheduled executor service that
...
takes/returns ScheduledExecutorService interface instances.
8 years ago
b932b67ddb
Fixes #803 Fix javadoc and re-signal interrupted flag.
8 years ago
033855209e
ClockSource cleanup (Java 8'ification); makes everything more readable
...
due to static import ability.
8 years ago
eedaf8c13f
Minor cleanup.
8 years ago
ae553ceee4
Remove unneeded check, total connections are now calculated
...
differently.
8 years ago
72e862d298
Fix race condition regression in ConcurrentBag and various other cleanup.
8 years ago
f0b3c520c9
Great simplification of the ConcurrentBag using a direct handoff queue
...
(SynchronousQueue) with a huge performance win (1.8x) for contended
pool access and at least 25% for non-contended access.
8 years ago
9efa2f7098
Add a Tomcat web application ClassLoader/ThreadLocal leak detection test.
8 years ago
5544a7113f
Improved ThreadLocal handling using Java 8 Supplier for initial value.
...
Hope this does not trigger Tomcat’s ClassLoader leak detection.
8 years ago
a3386d080e
Performance tweak, only signal if there are threads waiting.
8 years ago
4a454a4e9e
Fixes #614 Add the connection created during checkFailFast() to the pool
...
unless minimumIdle=0.
8 years ago
becaae4554
Unit test cleanup (lots of static imports). Also, the pool name will be set to the
...
method name of the test automatically (where possible).
8 years ago
61ddcb41eb
Additional unit test.
8 years ago
1cf7457168
Remove unneeded code. This is now handled in PoolBase.newConnection().
8 years ago
ceffabb39f
Cleaner pool configuration debug logging.
8 years ago
c3ef9ba062
Close#801 Additional changes, including eliding the submission of a new
...
PoolEntryCreator to the addConnectionExecutor when there are
already enough queued tasks to cover number of pending waiters.
8 years ago
f75f0e353a
#776 re-introduce the check on number of waiters just before connection creation time
8 years ago
f0bc58279d
#776 updated thread vs connection test to gather total and maxActive when there is no work to do to verify that we don't add any extra connections
8 years ago
8f84e1fb12
Fix build break.
8 years ago
45d33c0345
Build break fix
8 years ago
657de54b48
Change to bound check instead of exception trap
8 years ago
393ca0a7e6
Recycle connection if thread is interrupted after acquisition.
8 years ago
a3173c51ca
Handle all exception types.
8 years ago
bfcb95ae75
Remove deprecated API usage
8 years ago
c2f1a40a1d
Fixes #791 fix interrupted thread handling
8 years ago
579597aae9
Fixes #770 #786 added additional handling in HikariDataSource.getConnection(),
...
and added unit test.
8 years ago
df2d3e66a1
Fixes #770 added additional handling in HikariDataSource.getConnection()
...
and improved JavaDoc.
8 years ago
5c1bbe6bc9
Cleanup registration of Prometheus metrics (by unregistering on close()).
8 years ago
14b11c025c
Cleanup Java IDE warnings in tests.
8 years ago
fbe1006486
Fixes #770 by adding a new property initializationFailTimeout and deprecating
...
initializationFailFast.
8 years ago
980d8dc2e0
Fixed #781 Log before and after startup/shutdown.
8 years ago
9cc1fbcfca
Remove unused code from interim development.
8 years ago
346a2f5977
Fix bug introduced by f129797, plus some minor cleanup.
8 years ago
18077768d1
add a "Connect" histogram metric for tracking how many and how long connections are taking #518 and #769
8 years ago
f129797b8b
Fixes #774 Merged changes from @samhendley with modifications.
8 years ago
7bab1a8ccd
Fixes #770 by adding a new property initializationFailTimeout and deprecating
...
initializationFailFast.
8 years ago
e3b79ee044
Fixes #770 by adding a new property initializationFailTimeout and deprecating
...
initializationFailFast. Exception path still needs some work… coming in the
next commit.
8 years ago
1bd23423b9
Cancel HouseKeeper task on pool shutdown ( #741 )
...
Periodic house-keeping task is scheduled during construction of
HikariPool. The resulting scheduled task is not stored and therefore it
is not cancelled during pool shutdown.
With standard behaviour, when executor is managed by HikariPool itself,
it is not an issue, because the executor is shut down on pool shutdown.
But when a custom (long running) scheduled executor is supplied via
setScheduledExecutorService, tasks are kept indefinitely causing a
memory leak.
9 years ago
8361cf5afe
Fix stability of HikariCPCollectorTest for travis-ci build
9 years ago
ac08f5c16b
Cleaner pool size accounting.
9 years ago
b84f0df071
Minor cleanup
9 years ago
9b7cdb849b
Check the correct sql state and error code when unwrapping the exception chain. ( #724 )
9 years ago
135fb0bc5d
Unwrap chained exceptions. ( #723 )
...
good catch
9 years ago
5e05adcd27
Fixes #719 only reset lastConnectionFailure after a successful dataSource.getConnection() call.
9 years ago
6bff298316
Provisional fix for #714
9 years ago
20e6a5d923
Fixes #716 do not scan deeper than 10 nested SQLExceptions, it's typically a trap ... a chain that never terminates.
9 years ago
15ef1bd290
Misc. compiler warning cleanups. Still quite a few remaining in the tests...
9 years ago
d16f4eee5b
Fix test failure caused by reformatting code
9 years ago
d5cb614639
Fix test failure caused by reformatting code
9 years ago
b343eb8ae1
Remove compiler warnings
9 years ago
115453a282
Change what character is used for microseconds ( #707 )
...
Currently, it uses GREEK SMALL LETTER MU (U+03BC), which doesn't display in the command prompt on Windows. After this commit, it uses MICRO SIGN (U+00B5).
9 years ago
a8a926be09
Closes #701 Ensure the exception type is the same as 2.3.x
9 years ago
bb86c38ac1
Add comment re: issue #701 to prevent accidental breakage of Spring Boot's FailureAnalyzer.
9 years ago
53d479cf03
added remove of ConnectionTimeoutRate and refactored metric names into constants ( #698 )
9 years ago
5f3c97702f
Handle non-string properties
9 years ago
aabc47737f
Minor Java 8 changes
9 years ago
6c3957b04b
Minor cleanup
9 years ago
52d1c9fb52
Minor Java 8 changes
9 years ago
cce7c9133d
Prepare 2.5.0 release (Java 8 only)
9 years ago
03122e85b4
Fixes #696 use iteration instead of recursion to avoid a stack overflow with deeply nested SQLExceptions
9 years ago
6edaa336a6
CHANGES log and cleanup.
9 years ago
97057a1696
Fixes #694 report if a previously reported leaked connection is returned to the pool
9 years ago
c295eae960
Fixes #689 log a warning if default transaction isolation level cannot be detected.
9 years ago
6f81b02b32
Workaround for Apache Derby bug where the connection cannot be closed while a transaction is active.
9 years ago
fa0a3e3b6f
resolved #691 Remove additional check.
9 years ago
60224a0399
Fixes #674 fix regression caused by pull request #450 (overzealous optimisation)
9 years ago
ddfe0ab6cb
Add license headers ( #688 )
9 years ago
e6ece36c32
Merge commit '953b0be06d7517e63eebb6ef61c6d734621eae1e' into dev
9 years ago
ed2cce6eda
Ignoring test that is redundant for com.zaxxer.hikari.pool.TestConnectionTimeoutRetry.testConnectionRetries ( #678 )
9 years ago
3bf8356b8d
Implement List directly instead of extending ArrayList. ( #680 )
...
* Implement List directly instead of extending ArrayList.
* Remove transient dependencies.
* Support serialization.
9 years ago
953b0be06d
test for failure in case of InitializationFailFast
9 years ago
54c1cbaeae
Fix incorrect parameter order in thread starvation warning.
9 years ago
15468fb4bd
fix comments
9 years ago
3716edfa57
fix test
9 years ago
9a868bd4b0
consistency cleanup, renamed requite and releaseConnection to recycle
9 years ago
eb65b1b233
Fixes #664 do not recycle (requite) PoolEntrys that have been closed.
9 years ago
fb95531f07
Update ProxyConnection.java
...
Fixes #661 add error code
9 years ago
dd0c82613c
Minor cleanup.
9 years ago
21eedd5502
Fixes #650 detect Amazon Redshift connection refused error code.
9 years ago
211bcd4657
Specify floating point accuracy.
9 years ago
5cbb9351f8
Cherry-picked pull requests, added better Java 8+ detection.
9 years ago
76cf343c8b
Add prometheus support ( #632 )
9 years ago
7d1fb2ea3a
PropertyBeanSetter uses default locale ( #643 )
...
Motivation:
toUpperCase works according to Locale settings, for example if your computer locale is Turkish, "idleTimeout" property turns into "setİdleTime" beacuse upper "i" is "İ" in Turkish.
Modifications:
Invoke toUpperCase with Locale.ENGLISH.
Result:
Fixes #641 .
PropertyBeanSetter should work with Turkish locale.
9 years ago
88e6c7b580
Shutdown will throw NPE if invoked from checkFailFast ( #621 )
...
Motivation:
Shutdown may be invoked as a result of checkFailFast failing resulting in an NPE as the executors are setup later in the constructor.
Modifications:
Add null checks before trying to shutdown the executors.
Result:
"Graceful" shutdown.
9 years ago
8dde168adb
Possibly Fixes #606 Fixes ##610 housekeeper was running before all class members were initialised leading to an NPE in the housekeeper. Whether or not a particular VM would recover depends somewhat on its memory model. The pool on OS X did recover after the initial failure.
9 years ago
50ce1a1acc
Add ORA-02399: exceeded maximum connect time to SQL_ERRORS.
...
Not handling it avoids eviction of the connection and corrupts the pool.
For example the following NullPointerException is thrown when trying to use the pool afterwards:
java.lang.NullPointerException at com.zaxxer.hikari.pool.PoolBase.isConnectionAlive(PoolBase.java:128)
at com.zaxxer.hikari.pool.HikariPool.getConnection(HikariPool.java:171)
at com.zaxxer.hikari.pool.HikariPool.getConnection(HikariPool.java:147)
at com.zaxxer.hikari.HikariDataSource.getConnection(HikariDataSource.java:99)
.......
9 years ago
a10034ca43
Merge branch 'dev' of https://github.com/brettwooldridge/HikariCP into dev
9 years ago
668315c5de
Fixes #596
9 years ago
db989fff2d
Merge pull request #590 from mtambara/concurrent
...
Add test to demonstrate concurrency problem
9 years ago
610ea712ef
Fixes #594 store unique pool number as a String in the global system properties.
9 years ago
ed60109dcc
Fixes #594 store unique pool number as a String in the global system properties.
9 years ago
09ab4fbfa7
Fixes #594 store unique pool number as a String in the global system properties.
9 years ago
15037cc156
time-out was too tight and causing sporadic travis-ci failures.
9 years ago
5c8248732b
Paternalistic fix for developers with a weak grasp of resource ownership.
9 years ago
5eebe56dd1
Fixes #591 Synchronise the track statement method, and clearing of the tracked statement list.
9 years ago
21357a6b08
Fixes #591 Synchronise the untrack statement method to ensure that Statements are independently thread-safe.
9 years ago
bd96f1cca4
Fixes #593 This is a very common condition rather than an "exceptional" one, so log at information level and do not classify as a "failure".
9 years ago
d59771cd16
Add test to demonstrate concurrency problem
9 years ago
6ed3b18591
small but important fixes
...
removed var
removed resetting, delink validationTimeout from connectionTimeout
one less ref per leak task. renamed start() to schedule()
made some fields final
init of leakDetectionThreshold is not required for other instances
toString using elapsedDisplayString
fix: update poolEntry.lastBorrowed in case NopMetricsTrackerDelegate
fix tests.. try1
setting isCommitStateDirty conditionally in setAutoCommit()
again, avoid calling getNextException :)
setting lastAccess in close()
setting lastAccess required only in ctor and close
removed borrowed time from PoolEntry#toString()
now that lastAccess is moved to close(), moved condition too
one less call to System.nanoTime()
fix. using toNanos()
reverted toNanos() change, got too cumbersome
removed two calls to system time
timeout is not clock time :)
only one call saved but precise 'time taken to borrow'
unlink validation of connectionTimeout with maxLifetime
Merge
Revert
9 years ago
fc1aea9609
Merge branch 'dev' of https://github.com/nitincchauhan/HikariCP into dev
9 years ago
e4b91287cb
simplified call to executeSql()
9 years ago
c7e3a8f6cc
moved validateNumerics(), last in validation and is not throwing any
...
exception
9 years ago
bf83c624ed
IntelliJ inspections fixes, Maven dependencies and plugins updated to latest stable.
9 years ago
1b1b63fb3e
renamed ProxyLeakTask as it has nothing to do with 'proxy'
9 years ago
a6486c6417
fix: set last access even for readonly and set isCommitStateDirty wisely
9 years ago
4065283619
better variation
9 years ago
9d34443031
bug fix: do not call next exception if delegate == closed
9 years ago
1a9494596f
test failure fix 3
9 years ago
5a41fee89b
test failure fix 2
9 years ago
5238d2d4c4
fix test failure
9 years ago
bd3e570192
added, corrected validation and test
9 years ago
3095b6dc9e
avoid re-setting twice in validation
9 years ago
7b1301eeec
removed unused import
9 years ago
47ac982cc3
create leak task first and reverted long to int change
9 years ago
2e5dd85133
replaced volatile long with int and import static TimeUnit.*
9 years ago
0f75311732
using UNINITIALIZED
9 years ago
2b6da07d26
cleanup
9 years ago
82f7c15ace
changes as suggested
9 years ago
838d929067
using 'Failed' like every where else, instead of 'Unable'.
9 years ago
6436870bea
separate validationTimeout and connectionTimeout and validation, init
...
networkTimeout only once.
9 years ago
6e06620976
I didn't like this change, but missed it in the review. Readability over performance in this case. Not to mention that the JVM is likely to hoist the instanceof check and cast out of the loop because it is final invariant.
9 years ago
1f244af32f
Issue #547 Cleanup and additional logging.
9 years ago
fb09f10298
Log a warning (once) when it is not possible to honor a validation timeout of less than 1 second.
9 years ago
0e3677afa3
Use same terminology as other validation log messages, ie. "is less than" or "is more than".
9 years ago
6b535d542d
Merge branch 'dev' of github.com:nitincchauhan/HikariCP into dev
9 years ago
e46034f56d
bugfix: calling sValid() with 0 is infinite. made minimum 1sec
9 years ago
62fdb2c6c3
Merge pull request #567 from nitincchauhan/dev
...
avoid 'more' exceptions after 'un-recoverable' exception thrown before for the connection
9 years ago
e7da3f5dc7
reverted as suggested
9 years ago
0d0eec16ea
moved check to call(), start thread in other loop
9 years ago
14ceda3b0c
for re-throwing exception, setting log level to error
9 years ago
4c2486e4a0
removed static log, like parent PoolBase. checking instanceof out of
...
loop
9 years ago
a007e730be
race test: exit loop on exception
9 years ago
checketts
Brett Wooldridge
testingsavvy
Fred Deschenes
Garrick Olson
r1chl
Johno Crawford
Arthur Gavlyukovskiy
cenk akın
Daisuke Taniwaki
Andreas Brenk
Uday Shankar
bluehallu
Lorenzo Lucherini
will vuong
Will Vuong
shendley
Martin Stříž
ams2990
Jack
puntogil
TestSuiteReductionResearch
Nitin
Tokuhiro Matsuno
Emilio Lopez Gabeiras
Matthew Tambara
Guido Medina