Rename copyState to copyStateTo (#991)

Fixes #892 and should prevent further confusion.

src/main/java/com/zaxxer/hikari/HikariConfig.java

@@ -1043,7 +1043,26 @@ public class HikariConfig implements HikariConfigMXBean
       }
    }
 
+   /**
+    * Deprecated, use {@link #copyStateTo(HikariConfig)}.
+    * <p>
+    * Copies the state of {@code this} into {@code other}.
+    *</p>
+    *
+    * @param other Other {@link HikariConfig} to copy the state to.
+    */
+   @Deprecated
    public void copyState(HikariConfig other)
+   {
+      copyStateTo(other);
+   }
+
+   /**
+    * Copies the state of {@code this} into {@code other}.
+    *
+    * @param other Other {@link HikariConfig} to copy the state to.
+    */
+   public void copyStateTo(HikariConfig other)
    {
       for (Field field : HikariConfig.class.getDeclaredFields()) {
          if (!Modifier.isFinal(field.getModifiers())) {

src/main/java/com/zaxxer/hikari/HikariDataSource.java

@@ -66,7 +66,7 @@ public class HikariDataSource extends HikariConfig implements DataSource, Closea
    public HikariDataSource(HikariConfig configuration)
    {
       configuration.validate();
-      configuration.copyState(this);
+      configuration.copyStateTo(this);
 
       LOGGER.info("{} - Starting...", configuration.getPoolName());
       pool = fastPathPool = new HikariPool(this);

src/test/java/com/zaxxer/hikari/pool/HouseKeeperCleanupTest.java

@@ -62,7 +62,7 @@ public class HouseKeeperCleanupTest
       config.setScheduledExecutor(executor);
 
       HikariConfig config2 = newHikariConfig();
-      config.copyState(config2);
+      config.copyStateTo(config2);
 
       try (
          final HikariDataSource ds1 = new HikariDataSource(config);