5eebe56dd1
Fixes #591 Synchronise the track statement method, and clearing of the tracked statement list.
9 years ago
21357a6b08
Fixes #591 Synchronise the untrack statement method to ensure that Statements are independently thread-safe.
9 years ago
bd96f1cca4
Fixes #593 This is a very common condition rather than an "exceptional" one, so log at information level and do not classify as a "failure".
9 years ago
d59771cd16
Add test to demonstrate concurrency problem
9 years ago
6ed3b18591
small but important fixes
...
removed var
removed resetting, delink validationTimeout from connectionTimeout
one less ref per leak task. renamed start() to schedule()
made some fields final
init of leakDetectionThreshold is not required for other instances
toString using elapsedDisplayString
fix: update poolEntry.lastBorrowed in case NopMetricsTrackerDelegate
fix tests.. try1
setting isCommitStateDirty conditionally in setAutoCommit()
again, avoid calling getNextException :)
setting lastAccess in close()
setting lastAccess required only in ctor and close
removed borrowed time from PoolEntry#toString()
now that lastAccess is moved to close(), moved condition too
one less call to System.nanoTime()
fix. using toNanos()
reverted toNanos() change, got too cumbersome
removed two calls to system time
timeout is not clock time :)
only one call saved but precise 'time taken to borrow'
unlink validation of connectionTimeout with maxLifetime
Merge
Revert
9 years ago
fc1aea9609
Merge branch 'dev' of https://github.com/nitincchauhan/HikariCP into dev
9 years ago
e4b91287cb
simplified call to executeSql()
9 years ago
c7e3a8f6cc
moved validateNumerics(), last in validation and is not throwing any
...
exception
9 years ago
bf83c624ed
IntelliJ inspections fixes, Maven dependencies and plugins updated to latest stable.
9 years ago
1b1b63fb3e
renamed ProxyLeakTask as it has nothing to do with 'proxy'
9 years ago
a6486c6417
fix: set last access even for readonly and set isCommitStateDirty wisely
9 years ago
4065283619
better variation
9 years ago
9d34443031
bug fix: do not call next exception if delegate == closed
9 years ago
1a9494596f
test failure fix 3
9 years ago
5a41fee89b
test failure fix 2
9 years ago
5238d2d4c4
fix test failure
9 years ago
bd3e570192
added, corrected validation and test
9 years ago
3095b6dc9e
avoid re-setting twice in validation
9 years ago
7b1301eeec
removed unused import
9 years ago
47ac982cc3
create leak task first and reverted long to int change
9 years ago
2e5dd85133
replaced volatile long with int and import static TimeUnit.*
9 years ago
0f75311732
using UNINITIALIZED
9 years ago
2b6da07d26
cleanup
9 years ago
82f7c15ace
changes as suggested
9 years ago
838d929067
using 'Failed' like every where else, instead of 'Unable'.
9 years ago
6436870bea
separate validationTimeout and connectionTimeout and validation, init
...
networkTimeout only once.
9 years ago
6e06620976
I didn't like this change, but missed it in the review. Readability over performance in this case. Not to mention that the JVM is likely to hoist the instanceof check and cast out of the loop because it is final invariant.
9 years ago
1f244af32f
Issue #547 Cleanup and additional logging.
9 years ago
fb09f10298
Log a warning (once) when it is not possible to honor a validation timeout of less than 1 second.
9 years ago
0e3677afa3
Use same terminology as other validation log messages, ie. "is less than" or "is more than".
9 years ago
6b535d542d
Merge branch 'dev' of github.com:nitincchauhan/HikariCP into dev
9 years ago
e46034f56d
bugfix: calling sValid() with 0 is infinite. made minimum 1sec
9 years ago
62fdb2c6c3
Merge pull request #567 from nitincchauhan/dev
...
avoid 'more' exceptions after 'un-recoverable' exception thrown before for the connection
9 years ago
e7da3f5dc7
reverted as suggested
9 years ago
0d0eec16ea
moved check to call(), start thread in other loop
9 years ago
14ceda3b0c
for re-throwing exception, setting log level to error
9 years ago
4c2486e4a0
removed static log, like parent PoolBase. checking instanceof out of
...
loop
9 years ago
a007e730be
race test: exit loop on exception
9 years ago
d3bc0a155a
it is 1 thread so have queue size that mostly do not require to queue
...
jobs on caller
9 years ago
3610590d64
poolName was missing in few logs
9 years ago
ba09a68fe1
better thread names and log in validateNumerics() with poolName
9 years ago
f46fc1e9e5
setting allowCoreThreadTimeOut first
9 years ago
8bece2de76
consistent name for threads
9 years ago
c2523133d4
over-riding method instead of passing true as default from other places
9 years ago
2bc3d98901
unique 'closing' reason for each situation
9 years ago
76d490d2de
removed explicit call to fillInStackTrace()
9 years ago
ce03fc68c9
removed word 'pool' from thread name
9 years ago
e156b0d719
removed misleading 'extra' comma
9 years ago
9936e95afe
moved log 'closed' at the very end
9 years ago
f23f358ad4
avoid 'more' exceptions after connection is detected throwing
...
un-recoverable exception
9 years ago
e350d1f15f
Issue #566 Remove separate Counter metric for timeouts, count is implicitly captured and available from the new Meter metric for timeout rates.
9 years ago
85a298ccc6
Add metric for recording count and rate of connection timeouts
9 years ago
65e23b102a
Merge pull request #550 from ash2k/improvements2
...
Improvements2
9 years ago
4a5ffcdd05
Merge pull request #556 from Shredder121/timing-windows
...
Skip the `testMetricUsage` test on Windows
9 years ago
68a52f1431
Merge branch 'dev' of https://github.com/nitincchauhan/HikariCP into dev
9 years ago
6f49960d13
Spelling and naming.
9 years ago
852bbff2ad
Minor logging changes.
9 years ago
91ad77b142
Don't assume 'now' is in milliseconds ... it's probably nanoseconds on most platforms.
9 years ago
7dfdf597e2
Because housekeeper runs immediately now, 'previous' timestamp must be initialised as if it has run before, otherwise retrograde detection triggers.
9 years ago
e2f1974dc9
Add null check.
9 years ago
69dbe20cff
Issue #559 Adjust illegal clock motion detection, use scheduleWithFixedDelay() for housekeeper, and enlarge closeConnectionExecutor queue.
9 years ago
b78fde9121
full stop :)
9 years ago
96c91d549a
disable leakDetectionThreshold if not valid.
9 years ago
0e3f0eb0f6
leakDetectionThreshold should be less than maxLifetime
9 years ago
d4d6d759de
Issue #547 Decreased allowable minimum connectionTimeout and validationTimeout to 250ms.
9 years ago
bd7e3ba6db
Issue #563 Do not start the house-keeping thread until after pool initialisation has completed.
9 years ago
2b0e3f7553
changed log level: warn instead of debug, during driver support check
...
(logs only once)
9 years ago
f7c8118a86
Issue #559 cap the number of connections added by fillPool() if there are already pending tasks to do so.
9 years ago
91dbe31ff2
Fixes #559 improve logging of time shifts, allow retrograde time adjustments
9 years ago
4f865cabb5
do not set maxLifetime when disabling idle timeout
9 years ago
f40a13b5be
added synchronized to getObjectInstance()
9 years ago
a40e4856c9
renamed method to checkDriverSupport() and query driver default
...
transaction isolation once
9 years ago
8adf36bc3d
Skip the `testMetricUsage` test on Windows
...
My 75th percentile is indeed 250ms, but _sometimes_ returns 249ms
9 years ago
c0bd8bfeac
Fixes #555 check for default method is not longer needed because proxy generation is performed at build-time not run-time now.
9 years ago
99cacb33b2
changes as suggested. reverted resetBits and method.getParameterCount()
9 years ago
73491abb31
Fixes #555 check for default method is not longer needed because proxy generation is performed at build-time not run-time now.
9 years ago
573660dfe1
future safe from statement reorder
9 years ago
64dd93fe8f
minor
9 years ago
85e41abf10
context.close is correct. 542 may have other reason/s!
9 years ago
b525e0f7ef
set maxPoolSize = minIdle only if undefined, consistent error messages
9 years ago
ad754d085b
made transactionIsolation final
9 years ago
fde88d0659
if user specified, set transaction isolation level
9 years ago
ce50c2cfd6
removed resetBits. setting transaction isolation level like readonly &
...
autocommit.
9 years ago
c8cd7ab1bb
swap test condition
9 years ago
9a63ebf876
replaced getParameterTypes().length with getParameterCount()
9 years ago
743dc09d9a
Slightly improve generics
9 years ago
a30dcd87b8
Cache volatile reads in local variables
...
Avoid unnecessary read memory barriers
9 years ago
c3dcb08023
Preserve tread interrupted status
9 years ago
aa90bd62e0
close statement before commit/rollback
9 years ago
6769539f10
close ds
9 years ago
23b4909155
sizing queue for connection closing proportionally
9 years ago
c362e8bb35
fixed test
9 years ago
9daa51313f
I've added context.close() before but not sure anymore! see 542
9 years ago
87757fcd0a
keeping connectionBag.remove and totalConnections.decrementAndGet()
...
close by
9 years ago
5f851a4cfb
reverted. using cachedExecutor for setting network timeout as before
9 years ago
c9ad521660
cleanup + rearrange statements
9 years ago
2f3a1079ed
merged DefaultThreadFactory with UtilityElf
9 years ago
cf1b7738c0
unused import
9 years ago
a56f5dcb2d
removed ThreadPoolExecutor for use with setNetworkTimeout
9 years ago
1a64ab2357
This change in incorrect. Even the pure JDBC4 isValid() check can execute a query, and it is known that some drivers do so.
9 years ago
77e5972005
Fix for Java 7.
9 years ago
a270577dc3
Merge branch 'dev1' of https://github.com/nitincchauhan/HikariCP into dev
9 years ago
5c39c0a462
cache and refresh 'volatile' validationTimeout too
9 years ago
c7652d6ef9
optimize isConnectionAlive() replaced getAndSetNetworkTimeout with
...
setNetworkTimeout
9 years ago
6124110d86
revert to setting network time out in try. in case it throws
9 years ago
fd02583e47
minor tweaks
9 years ago
787bd979eb
better property logging
9 years ago
211e8e5d50
special treatment for password
9 years ago
d3d5dd6414
null check with instanceof is redundant
9 years ago
9bb262cb23
reverted nullifying
9 years ago
705c9e7db5
nullify in condition
9 years ago
ce4ff9255b
fixed NPE in tests
9 years ago
3d2a082da8
do NOT recycle connection that is evicted in checkException()
9 years ago
5321da3f50
better closure reason
9 years ago
9168b83377
false warning, removed.
9 years ago
60e272614e
re-setting isIsolateInternalQueries if not required
9 years ago
2bd02091b4
reverted: setting lastConnectionFailure to null
9 years ago
48a8afd141
Fixes #495 implement iterator for Tomcat leak detection.
9 years ago
926167598a
Fixed Test
9 years ago
1e24d50f97
make sure pool is ready before reseting counter
9 years ago
4ec2e80c1e
reset StubConnection.count after pool initialization
9 years ago
b88b314adc
fixed tests :)
9 years ago
18c0e2d6b0
assertion with text
9 years ago
af93c99019
set Sleepbackoff time to maximum 10 seconds
9 years ago
cd24a1e024
fixed errors
9 years ago
60b58ad63d
minor cleanup in tests
9 years ago
95b237a07f
more debug
9 years ago
625b9d77dd
added poolname to debug
9 years ago
fc09055538
minor cleanup
9 years ago
8277a55c58
fixed test
9 years ago
5ff7a72127
fixed tests
9 years ago
cb16120753
fixed test failures
9 years ago
b60f166681
minor cleanup
9 years ago
8908411e41
for initializationFailFast, fail asap, not wait till connectionTimeout
9 years ago
5a2d40879e
keep lastConnectionFailure till getAndSet
9 years ago
4b2e1d9ea5
removed explicit use of iterator
9 years ago
54cd9d9685
sleep intelligence :)
9 years ago
ccfb1dbe8b
warn and reset too
9 years ago
c731ff88b5
log property value as is. 'null' too
9 years ago
a9f7e65b0a
sleep min 250 ms - max 7 sec
9 years ago
bc450c6c25
warn for timeouts in config
9 years ago
a265641ea7
warn for wrong timeouts in config:
...
http://stackoverflow.com/questions/33887002
9 years ago
6eb0d93985
sleep for 200ms for minimum 1s, 6s for default 30s connectionTimeout.
9 years ago
8eaaa7fdcd
sleep reasonably, fix possible negative lifetime
9 years ago
cfd5e4d054
removed log
9 years ago
541322a579
added warning too
9 years ago
74c6f6e2b5
fix test
9 years ago
7cbdb602a2
check and throw exceptions as before
9 years ago
2980c99bd6
fix tests
9 years ago
7027f23ead
clear/simplified validation in sync with initializeDataSource() and
...
DriverDataSource()
9 years ago
Brett Wooldridge
Matthew Tambara
Nitin
Guido Medina
Will Vuong
Ruben Dijkstra
Mikhail Mazurskiy