6bff298316
Provisional fix for #714
9 years ago
20e6a5d923
Fixes #716 do not scan deeper than 10 nested SQLExceptions, it's typically a trap ... a chain that never terminates.
9 years ago
15ef1bd290
Misc. compiler warning cleanups. Still quite a few remaining in the tests...
9 years ago
d16f4eee5b
Fix test failure caused by reformatting code
9 years ago
d5cb614639
Fix test failure caused by reformatting code
9 years ago
b343eb8ae1
Remove compiler warnings
9 years ago
115453a282
Change what character is used for microseconds ( #707 )
...
Currently, it uses GREEK SMALL LETTER MU (U+03BC), which doesn't display in the command prompt on Windows. After this commit, it uses MICRO SIGN (U+00B5).
9 years ago
a8a926be09
Closes #701 Ensure the exception type is the same as 2.3.x
9 years ago
bb86c38ac1
Add comment re: issue #701 to prevent accidental breakage of Spring Boot's FailureAnalyzer.
9 years ago
53d479cf03
added remove of ConnectionTimeoutRate and refactored metric names into constants ( #698 )
9 years ago
5f3c97702f
Handle non-string properties
9 years ago
aabc47737f
Minor Java 8 changes
9 years ago
6c3957b04b
Minor cleanup
9 years ago
52d1c9fb52
Minor Java 8 changes
9 years ago
cce7c9133d
Prepare 2.5.0 release (Java 8 only)
9 years ago
03122e85b4
Fixes #696 use iteration instead of recursion to avoid a stack overflow with deeply nested SQLExceptions
9 years ago
6edaa336a6
CHANGES log and cleanup.
9 years ago
97057a1696
Fixes #694 report if a previously reported leaked connection is returned to the pool
9 years ago
c295eae960
Fixes #689 log a warning if default transaction isolation level cannot be detected.
9 years ago
6f81b02b32
Workaround for Apache Derby bug where the connection cannot be closed while a transaction is active.
9 years ago
fa0a3e3b6f
resolved #691 Remove additional check.
9 years ago
60224a0399
Fixes #674 fix regression caused by pull request #450 (overzealous optimisation)
9 years ago
ddfe0ab6cb
Add license headers ( #688 )
9 years ago
e6ece36c32
Merge commit '953b0be06d7517e63eebb6ef61c6d734621eae1e' into dev
9 years ago
ed2cce6eda
Ignoring test that is redundant for com.zaxxer.hikari.pool.TestConnectionTimeoutRetry.testConnectionRetries ( #678 )
9 years ago
3bf8356b8d
Implement List directly instead of extending ArrayList. ( #680 )
...
* Implement List directly instead of extending ArrayList.
* Remove transient dependencies.
* Support serialization.
9 years ago
953b0be06d
test for failure in case of InitializationFailFast
9 years ago
54c1cbaeae
Fix incorrect parameter order in thread starvation warning.
9 years ago
15468fb4bd
fix comments
9 years ago
3716edfa57
fix test
9 years ago
9a868bd4b0
consistency cleanup, renamed requite and releaseConnection to recycle
9 years ago
eb65b1b233
Fixes #664 do not recycle (requite) PoolEntrys that have been closed.
9 years ago
fb95531f07
Update ProxyConnection.java
...
Fixes #661 add error code
9 years ago
dd0c82613c
Minor cleanup.
9 years ago
21eedd5502
Fixes #650 detect Amazon Redshift connection refused error code.
9 years ago
211bcd4657
Specify floating point accuracy.
9 years ago
5cbb9351f8
Cherry-picked pull requests, added better Java 8+ detection.
9 years ago
76cf343c8b
Add prometheus support ( #632 )
9 years ago
7d1fb2ea3a
PropertyBeanSetter uses default locale ( #643 )
...
Motivation:
toUpperCase works according to Locale settings, for example if your computer locale is Turkish, "idleTimeout" property turns into "setİdleTime" beacuse upper "i" is "İ" in Turkish.
Modifications:
Invoke toUpperCase with Locale.ENGLISH.
Result:
Fixes #641 .
PropertyBeanSetter should work with Turkish locale.
9 years ago
88e6c7b580
Shutdown will throw NPE if invoked from checkFailFast ( #621 )
...
Motivation:
Shutdown may be invoked as a result of checkFailFast failing resulting in an NPE as the executors are setup later in the constructor.
Modifications:
Add null checks before trying to shutdown the executors.
Result:
"Graceful" shutdown.
9 years ago
8dde168adb
Possibly Fixes #606 Fixes ##610 housekeeper was running before all class members were initialised leading to an NPE in the housekeeper. Whether or not a particular VM would recover depends somewhat on its memory model. The pool on OS X did recover after the initial failure.
9 years ago
50ce1a1acc
Add ORA-02399: exceeded maximum connect time to SQL_ERRORS.
...
Not handling it avoids eviction of the connection and corrupts the pool.
For example the following NullPointerException is thrown when trying to use the pool afterwards:
java.lang.NullPointerException at com.zaxxer.hikari.pool.PoolBase.isConnectionAlive(PoolBase.java:128)
at com.zaxxer.hikari.pool.HikariPool.getConnection(HikariPool.java:171)
at com.zaxxer.hikari.pool.HikariPool.getConnection(HikariPool.java:147)
at com.zaxxer.hikari.HikariDataSource.getConnection(HikariDataSource.java:99)
.......
9 years ago
a10034ca43
Merge branch 'dev' of https://github.com/brettwooldridge/HikariCP into dev
9 years ago
668315c5de
Fixes #596
9 years ago
db989fff2d
Merge pull request #590 from mtambara/concurrent
...
Add test to demonstrate concurrency problem
9 years ago
610ea712ef
Fixes #594 store unique pool number as a String in the global system properties.
9 years ago
ed60109dcc
Fixes #594 store unique pool number as a String in the global system properties.
9 years ago
09ab4fbfa7
Fixes #594 store unique pool number as a String in the global system properties.
9 years ago
15037cc156
time-out was too tight and causing sporadic travis-ci failures.
9 years ago
5c8248732b
Paternalistic fix for developers with a weak grasp of resource ownership.
9 years ago
5eebe56dd1
Fixes #591 Synchronise the track statement method, and clearing of the tracked statement list.
9 years ago
21357a6b08
Fixes #591 Synchronise the untrack statement method to ensure that Statements are independently thread-safe.
9 years ago
bd96f1cca4
Fixes #593 This is a very common condition rather than an "exceptional" one, so log at information level and do not classify as a "failure".
9 years ago
d59771cd16
Add test to demonstrate concurrency problem
9 years ago
6ed3b18591
small but important fixes
...
removed var
removed resetting, delink validationTimeout from connectionTimeout
one less ref per leak task. renamed start() to schedule()
made some fields final
init of leakDetectionThreshold is not required for other instances
toString using elapsedDisplayString
fix: update poolEntry.lastBorrowed in case NopMetricsTrackerDelegate
fix tests.. try1
setting isCommitStateDirty conditionally in setAutoCommit()
again, avoid calling getNextException :)
setting lastAccess in close()
setting lastAccess required only in ctor and close
removed borrowed time from PoolEntry#toString()
now that lastAccess is moved to close(), moved condition too
one less call to System.nanoTime()
fix. using toNanos()
reverted toNanos() change, got too cumbersome
removed two calls to system time
timeout is not clock time :)
only one call saved but precise 'time taken to borrow'
unlink validation of connectionTimeout with maxLifetime
Merge
Revert
9 years ago
fc1aea9609
Merge branch 'dev' of https://github.com/nitincchauhan/HikariCP into dev
9 years ago
e4b91287cb
simplified call to executeSql()
9 years ago
c7e3a8f6cc
moved validateNumerics(), last in validation and is not throwing any
...
exception
9 years ago
bf83c624ed
IntelliJ inspections fixes, Maven dependencies and plugins updated to latest stable.
9 years ago
1b1b63fb3e
renamed ProxyLeakTask as it has nothing to do with 'proxy'
9 years ago
a6486c6417
fix: set last access even for readonly and set isCommitStateDirty wisely
9 years ago
4065283619
better variation
9 years ago
9d34443031
bug fix: do not call next exception if delegate == closed
9 years ago
1a9494596f
test failure fix 3
9 years ago
5a41fee89b
test failure fix 2
9 years ago
5238d2d4c4
fix test failure
9 years ago
bd3e570192
added, corrected validation and test
9 years ago
3095b6dc9e
avoid re-setting twice in validation
9 years ago
7b1301eeec
removed unused import
9 years ago
47ac982cc3
create leak task first and reverted long to int change
9 years ago
2e5dd85133
replaced volatile long with int and import static TimeUnit.*
9 years ago
0f75311732
using UNINITIALIZED
9 years ago
2b6da07d26
cleanup
9 years ago
82f7c15ace
changes as suggested
9 years ago
838d929067
using 'Failed' like every where else, instead of 'Unable'.
9 years ago
6436870bea
separate validationTimeout and connectionTimeout and validation, init
...
networkTimeout only once.
9 years ago
6e06620976
I didn't like this change, but missed it in the review. Readability over performance in this case. Not to mention that the JVM is likely to hoist the instanceof check and cast out of the loop because it is final invariant.
9 years ago
1f244af32f
Issue #547 Cleanup and additional logging.
9 years ago
fb09f10298
Log a warning (once) when it is not possible to honor a validation timeout of less than 1 second.
9 years ago
0e3677afa3
Use same terminology as other validation log messages, ie. "is less than" or "is more than".
9 years ago
6b535d542d
Merge branch 'dev' of github.com:nitincchauhan/HikariCP into dev
9 years ago
e46034f56d
bugfix: calling sValid() with 0 is infinite. made minimum 1sec
9 years ago
62fdb2c6c3
Merge pull request #567 from nitincchauhan/dev
...
avoid 'more' exceptions after 'un-recoverable' exception thrown before for the connection
9 years ago
e7da3f5dc7
reverted as suggested
9 years ago
0d0eec16ea
moved check to call(), start thread in other loop
9 years ago
14ceda3b0c
for re-throwing exception, setting log level to error
9 years ago
4c2486e4a0
removed static log, like parent PoolBase. checking instanceof out of
...
loop
9 years ago
a007e730be
race test: exit loop on exception
9 years ago
d3bc0a155a
it is 1 thread so have queue size that mostly do not require to queue
...
jobs on caller
9 years ago
3610590d64
poolName was missing in few logs
9 years ago
ba09a68fe1
better thread names and log in validateNumerics() with poolName
9 years ago
f46fc1e9e5
setting allowCoreThreadTimeOut first
9 years ago
8bece2de76
consistent name for threads
9 years ago
c2523133d4
over-riding method instead of passing true as default from other places
9 years ago
2bc3d98901
unique 'closing' reason for each situation
9 years ago
76d490d2de
removed explicit call to fillInStackTrace()
9 years ago
ce03fc68c9
removed word 'pool' from thread name
9 years ago
e156b0d719
removed misleading 'extra' comma
9 years ago
9936e95afe
moved log 'closed' at the very end
9 years ago
f23f358ad4
avoid 'more' exceptions after connection is detected throwing
...
un-recoverable exception
9 years ago
Brett Wooldridge
ams2990
Jack
puntogil
TestSuiteReductionResearch
Johno Crawford
Nitin
Tokuhiro Matsuno
Emilio Lopez Gabeiras
Matthew Tambara
Guido Medina