bcde774078
check readonly on rollback
9 years ago
10b0547ab7
comment corrected
9 years ago
63c0fcb893
removed unused method
9 years ago
b7c32b2bb2
Merge remote-tracking branch 'brett/dev' into dev
9 years ago
87fa34af15
init 'other' vars too for proxy connection
9 years ago
ba4b600db0
Merge pull request #449 from nitincchauhan/dev
...
final
9 years ago
3bf2525262
Merge remote-tracking branch 'brett/dev' into dev
9 years ago
e74639c418
Fix bug uncovered during live DB testing. If the database is autoCommit=true we were trying to rollback because ProxyConnection.isAutoCommit was never initialized to true.
9 years ago
dcd8fdb3a9
final
9 years ago
476180b0bc
Merge pull request #448 from nitincchauhan/dev
...
using Throwable, better for backport too
9 years ago
0218ed14b5
format
9 years ago
1daf44b754
using Throwable, better for backport too
9 years ago
b08f693d9c
Merge pull request #446 from jack-kerouac/set-login-timeout-unsupported
...
do not fail if setLoginTimeout on delegate data source is not supported
9 years ago
678b2ce139
use multi-catch statement
...
I was not aware that this feature is available in JDK7 already and the README specifies that JDK7 is required only.
9 years ago
4e1aaa1802
Prepare for 2.4.2 release candidate.
9 years ago
8a7901f292
do not fail if setLoginTimeout on delegate data source is not supported
...
Some `DataSource` implementations (like [`BasicDataSource`](https://commons.apache.org/proper/commons-dbcp/api-1.4/org/apache/commons/dbcp/BasicDataSource.html ) or [`DriverManagerDataSource`](https://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/jdbc/datasource/DriverManagerDataSource.html ) do not support setting a login timeout. `UnsupportedOperationException` is thrown in these cases.
When a delegate `dataSource` is set for the HikariCP, it tries to invoke this method on the delegate. Only log a warning in this case instead of failing to initialize the HikariCP in this case.
This is amongst others relevant for using HikariCP in Grails, which creates instances of `org.springframework.jdbc.datasource.DriverManagerDataSource` (at least in version 2.2.4).
9 years ago
c0c6daf93d
Fixed #401 log warning when both dataSourceClassName and jdbcUrl are specified.
9 years ago
23c1b80bfd
Tighten bypass window. May tighten further to 250ms later.
9 years ago
efa9726835
Adjust test timeout to try to address travis-ci transient failures.
9 years ago
ea680f7ff5
Merge commit '49be257130ba7bc3080f5bc8a0f191db86f23394' into dev
...
* commit '49be257130ba7bc3080f5bc8a0f191db86f23394':
commented log & added changes removed from old commit
align log with 'Before cleanup'
9 years ago
49be257130
commented log & added changes removed from old commit
9 years ago
716dd345cd
Fixed issue with proxy generation
9 years ago
0da14c8ce9
align log with 'Before cleanup'
9 years ago
19e0c5d575
Merge pull request #440 from nitincchauhan/dev
...
removed old call to close statements
9 years ago
1c2f1c13a5
loop is required
9 years ago
c3482cde10
removed redundant loop, addItem() is actually adding itemS
9 years ago
f9d493a7d8
checking evict only when required
9 years ago
285157c335
removed old call
9 years ago
5553fe5dcf
Merge pull request #438 from nitincchauhan/dev
...
removed isClosed() check.
9 years ago
c37a6cb20a
removed isClosed(), why trip to check when close() is no-op if already
...
closed, moreover isClosed() was not guarded by network timeout. mostly
call to close would be once anyway.
9 years ago
03aad4ea35
minor cleanup
9 years ago
3c3a14bd3f
Merge pull request #437 from nitincchauhan/dev
...
minor cleanup
9 years ago
6137805ab3
minor cleanup
9 years ago
4ae5c69eae
Shorten some tests timeouts to speed-up build.
9 years ago
410f240c0a
Merge branch 'dev' of https://github.com/brettwooldridge/HikariCP into dev
9 years ago
31447dd1e2
Evict connection immediately upon broken state detection.
9 years ago
2362af9e14
Update CHANGES
9 years ago
79386c6487
Fixes #432 improve accuracy of elapsed time calculation to account for time spent in isConnectionAlive() call.
9 years ago
b2cfd09998
Fix timing sensitive test that often fails on travis-ci
9 years ago
e125d509fe
Cleanup. Former code would remove N elements if PoolEntries were unreservable. Additionally, I'd like to see stats every 30 seconds, as long as idleTimeout is enabled, regardless of idle removable (because connection attrition occurs by other means as well.
10 years ago
d954f46f05
Merge pull request #430 from nitincchauhan/dev
...
sort before closing idle connections
10 years ago
a2593599d6
sort before closing idle connections
10 years ago
cb8d1bf775
Merge pull request #428 from nitincchauhan/dev
...
renamed method/var names, moved toString() to PoolBase, checking for
10 years ago
298bf85c36
renamed method/var names, moved toString() to PoolBase, checking for
...
'readonly' before commit/rollback.
10 years ago
64ac691c7f
Merge pull request #427 from kschmit90/dev
...
Typo fix
10 years ago
11252bd7ad
Undo my own typo
10 years ago
9fce5de138
Typo
10 years ago
295ff59ab7
Fixes #425 a low impact change to satisfy an edge-case.
...
Still, relying on object identities from getResultSet() is an extremely bad idea, regardless of how some drivers seem to implement it. Relying on that implementation artifact is contrary to the Statement interface documentation, and likely to fail in a variety of environments. HikariCP itself does not and will not guarantee the future behaviour of this method.
10 years ago
3bb13c03db
More refactors to isolate metrics from internal pool classes
10 years ago
eaa5ca879e
More metrics refactor. Isolate poolEntry from metrics package, reinstate no-op class to allow JIT to DCE the code.
10 years ago
Nitin
Brett Wooldridge
Florian Rampp
Kyle