31447dd1e2
Evict connection immediately upon broken state detection.
10 years ago
79386c6487
Fixes #432 improve accuracy of elapsed time calculation to account for time spent in isConnectionAlive() call.
10 years ago
b2cfd09998
Fix timing sensitive test that often fails on travis-ci
10 years ago
c399b46551
Merge branch 'dev' of github.com-brettwooldridge:brettwooldridge/HikariCP into experimental
10 years ago
e125d509fe
Cleanup. Former code would remove N elements if PoolEntries were unreservable. Additionally, I'd like to see stats every 30 seconds, as long as idleTimeout is enabled, regardless of idle removable (because connection attrition occurs by other means as well.
10 years ago
a2593599d6
sort before closing idle connections
10 years ago
298bf85c36
renamed method/var names, moved toString() to PoolBase, checking for
...
'readonly' before commit/rollback.
10 years ago
295ff59ab7
Fixes #425 a low impact change to satisfy an edge-case.
...
Still, relying on object identities from getResultSet() is an extremely bad idea, regardless of how some drivers seem to implement it. Relying on that implementation artifact is contrary to the Statement interface documentation, and likely to fail in a variety of environments. HikariCP itself does not and will not guarantee the future behaviour of this method.
10 years ago
3bb13c03db
More refactors to isolate metrics from internal pool classes
10 years ago
eaa5ca879e
More metrics refactor. Isolate poolEntry from metrics package, reinstate no-op class to allow JIT to DCE the code.
10 years ago
e50be62d4f
More metrics refactor. Isolate poolEntry from metrics package, reinstate no-op class to allow JIT to DCE the code.
10 years ago
cc3f8614af
more cleanup
10 years ago
ff8e54c56f
correct time
10 years ago
eaaf64f93f
renamed and removed volatile from lastBorrowed and cleanup
10 years ago
e3167d40a6
protect pool entry
10 years ago
ca0464d659
Tweaks to investigate Windows infinite loop and/or spurious wakeup.
10 years ago
0069a4eff8
duplicate2
10 years ago
d0f84e101d
cleanup
10 years ago
fc32b4de73
removed redundant creationTime. lastAceess is initialized at creation as
...
well.
10 years ago
9226660ce7
clear param
10 years ago
02122fc5e8
Minor cleanup.
10 years ago
aca80d3ed9
Full refactor.
10 years ago
0e6a595612
Move stuff around
10 years ago
53287cd101
changes as suggested
10 years ago
1e55190ed4
Merge remote-tracking branch 'brett/dev' into dev
10 years ago
dbeb5ab1cb
Remove Method.getParameterCount() because it is only available in Java 8. Use getParameterTypes().length instead.
10 years ago
1e8ea2b3e2
Remove Method.getParameterCount() because it is only available in Java 8. Use getParameterTypes().length instead.
10 years ago
0698d8f761
Correct unit test.
10 years ago
e2763a48f6
renamed poolEntry.returnPoolEntry() to poolEntry.close()
10 years ago
1b5ecf8b2a
Mediator: simplified check of validation modes
...
ConnectionProxy: made memebers private, added missing methods of
connectionState. not sure why ide does not complain !
10 years ago
b145a385c6
#415 removed unused API
10 years ago
afe1527039
Use laxySet() when returning pool entries.
10 years ago
4639ca0bfb
Fixes #415 missed commit. Don't use java.beans
10 years ago
e0039464eb
Null checks. Now back to work.
10 years ago
eb3adb7faf
Fixes #406 execute validation query during connection setup to make sure its ... um ... valid.
10 years ago
8df62e3bf1
Mediator refactor
10 years ago
caa4b0d0bc
Fixes #400 make getters public
10 years ago
e91059f320
fix test
10 years ago
dd6fdae57e
do not call set for TRANSACTION_NONE
10 years ago
480fd309d2
do not call set if default is same as user specified
10 years ago
af4f8a991c
do not set connection with property that user have not specified.
10 years ago
b8d2077869
Even more correct lastAccess tracking.
10 years ago
891b5cd930
moved closeStatements()
10 years ago
8d1ba093b1
missed one
10 years ago
8f61b1781c
unintentional logging
10 years ago
000654e737
remove resetPoolEntry(), calling individual method if changed
10 years ago
d362ed52df
set lastAccess only if rolled back
...
closeStatements() already caches sqlexception
10 years ago
ee8025e99c
fix javadoc error
10 years ago
dbe9320924
Back-out deoptimization. Benchmark shows degradation, which makes sense because
...
of a new conditional in close() -- the return value of closeOpenStatements() -- which is
'true' 99.999% of the time and therefore the conditional is merely overhead.
10 years ago
182c8c58ab
Opps, forgot to flip the conditional.
10 years ago
4fbc2aa94b
Minor formatting change.
10 years ago
442bbc6362
Merge branch 'dev' of https://github.com/nitincchauhan/HikariCP into dev
10 years ago
78034f7e45
changes as suggested
10 years ago
ae4dbf916d
removed PoolBagEntry.aborted ...always had same 'value' as evicted
...
renamed PoolBagEntry.evicted to PoolBagEntry.evict
10 years ago
19896c0619
if connection is marked for eviction, bypass reset state etc and close
...
it.
10 years ago
ad9f5e6a19
fixed comment
...
ClassLoader.getResourceAsStream() and Class.getResourceAsStream() are
different. Refer to http://stackoverflow.com/a/1464366/524588
10 years ago
fb50c8108c
Merge pull request #384 from yaojuncn/dev
...
revise connection pool cleanup logic by reducing unncessary loop,
10 years ago
7ad2e94ed4
revise housekeeper log
10 years ago
01a9a09778
Revert fix #340 see discussion in issue tracker
10 years ago
93bbb25d15
change removable check
10 years ago
6cc3b278b4
fix the removable check; revise space style
10 years ago
9613b63a43
Fixed #380 housekeeper was not being scheduled in the case of a user specified ScheduledExecutorService.
10 years ago
cbb1e1cc93
revise connection pool cleanup logic by reducing unncessary loop,
...
some details from
https://github.com/brettwooldridge/HikariCP/issues/379
based on original pull request
https://github.com/brettwooldridge/HikariCP/pull/383
10 years ago
2a90f26145
log /creation cleanup
10 years ago
c4b0ac352c
housekeeper should close evicted connections... but forget it :)
10 years ago
7685f10303
check for evicted should not depend on removable
10 years ago
5004e1f463
setting evicted was 'little' more aggressive
10 years ago
6a2bfb758c
for closing connection, reserve entry only when it is past idle time or
...
evicted, not otherwise
10 years ago
ebe5868fd1
changes as suggested
...
align log stats
10 years ago
d04f4dd3f1
log actual error message instead of 'Exception during pool'
...
name 'PoolInitializationException' is descriptive enough
10 years ago
cefc2af679
level up
10 years ago
616a8321ab
break loop
10 years ago
6cee92a300
removed closing evicted connections from housekeeper
10 years ago
9489dda6c0
reverted as per discussion
10 years ago
8cc1214007
close connections marked for eviction first
10 years ago
a286c264cc
change as suggested
10 years ago
1137ed1e40
implemented suggestion from 379
10 years ago
265ee41e70
tweak isConnectionAlive and few other
10 years ago
e789d03571
Fix Issue 375 ..restore thing that was not broken
...
Fixed Readme ...added missing changes from master
10 years ago
7efb9c0c57
keeping change in state/value of member internal
10 years ago
05a4193b38
reverted connectionproxy
10 years ago
34fa30254f
removed wrong use of clocksource
10 years ago
5d1a63e78b
better add, undone close
10 years ago
fa0b6644b2
keeping test and assignment close in con.close()
10 years ago
31ddd3d9db
smart idleTimeout
10 years ago
a0ebf35d91
Merge remote-tracking branch 'brettwooldridge/HikariCP/dev' into dev
10 years ago
c1ee0b0ce8
fix argument to log
10 years ago
53e7427e63
Eliminates questions from developers running tests in the IDE...
10 years ago
2cf1446fdd
Merge pull request #347 from nitincchauhan/dev
...
HikariPool: Log consitency
10 years ago
a31c2df6b7
Fixed #361 Merge branch '2.3.x' into dev
10 years ago
82536c0fe6
Make ResultSet.getStatement() return the StatementProxy instead of the delegate.
10 years ago
a4d1156d08
Fixed #359 allow altering the username/password through JMX at runtime. See javadoc for HikariConfigMXBean.
10 years ago
9e4466776d
Minor cleanup.
10 years ago
62ec9cd5f2
Javadoc fixes.
10 years ago
b0b53dc607
Minor logging tweaks.
10 years ago
428e2b56c8
Fix #354 always set previous timestamp
10 years ago
9136e8e6dd
removed else
10 years ago
31113bf0d9
try 2 fixed test
10 years ago
0dbdc47f05
fixed test
10 years ago
8eb6b76534
done now.
...
please see changes together here:
https://github.com/brettwooldridge/HikariCP/pull/347/files
10 years ago
f6e9793034
2nd try. not sure why the whole file shown in diff before
10 years ago
acb7d41961
done
...
However, Doc for setTransactionIsolation() says:
(Note that Connection.TRANSACTION_NONE cannot be used because it
specifies that transactions are not supported.)
10 years ago
dc5b484f52
better fix
10 years ago
07ca37e7a4
minor save
10 years ago
285bcfc415
suggestion to fix issue 349
10 years ago
c406837755
few more
10 years ago
ee043a3031
better
10 years ago
e313835b94
changes as suggested
10 years ago
384667e2a0
Add more information to logging of broken connections discovered in the proxy path.
10 years ago
7bb009be24
2nd try
10 years ago
8fd73d2501
HikariPool: Log consitency
...
PoolElf: I think two more round trips to db/driver is overkill (for pool
to support bad driver) especially jdbc spec reads 'closing statement
must close any current result set'. It is already slow (compare to
others) having network timeout as well as query timeout to validate
connection!
10 years ago
234d213cef
Minor cleanup.
10 years ago
21ce05a962
Efficient debug logging for state resets.
10 years ago
256fe1d4bd
Logging consistency
10 years ago
9c7581d48d
Fix #346 handle closing (possible) ResultSet in a better way.
10 years ago
18320f2e4c
Further normalise logging.
10 years ago
b857c83bd1
Further normalise logging.
10 years ago
2498612194
Fix resolving property files
10 years ago
65adba0541
Fix bug where at pool shutdown we erroneously shutdown a shared ScheduledExecutorService
10 years ago
f063801c48
Minor logging cleanup.
10 years ago
251d01f70a
Somewhere along the line clear got dropped. Reinstate it.
10 years ago
120744049f
Logging format changes.
10 years ago
c87c002ceb
Performance tweak
10 years ago
73cf8d0b13
Cleanup
10 years ago
4f5abd1318
Remove runtime dependencies on Codahale and generally make things a bit cleaner.
10 years ago
18b9f8c1b6
Formatting
10 years ago
4eb7874690
Merge pull request #331 from arthurdandrea/dev
...
Allow the use of a user provided MetricsTracker
10 years ago
b18c786e1d
Minor bugfixes.
10 years ago
2a2561e52f
Implement injection of MetricsTracker using a MetricsTrackerFactory
...
Allows the use of user provided MetricsTracker that can collect metrics
using a library different from Dropwizard Metrics.
10 years ago
7dfcb265e4
Minor bugfix
10 years ago
fab78c4449
Make poolName a member just for the sake of readability.
10 years ago
163e6172fc
Fix issues with leakDetectionThreshold changes through the HikariConfigMXBean. Thx, Nitin.
10 years ago
287f4d748d
Adhere to same MBean naming convention as the HikariPoolMXBean ... out of convention.
10 years ago
bc3424575c
Fix #334 caused by moving the ``HikariPoolMBean`` into the ``com.zaxxer.hikari`` package. Classes with the ``xxxMBean`` naming convention must reside in the same package. Renaming the class to ``xxxMXBean`` allows it to reside anywhere.
10 years ago
cf2a9d3aef
Fix overwrite of networkTimeout (harmless, but inefficient).
10 years ago
1eae36cf1d
Merge fix from 2.3.9
10 years ago
2ac1c8b0e7
Revert/cleanup network timeout executor creation/shutdown.
10 years ago
68a09a882e
Update leak detection threshold if it is changed by MBean at runtime.
10 years ago
2b674b40ce
Handle null netTimeoutExecutor.
10 years ago
086ee72652
Minor bugfixes.
10 years ago
cda1d6e7c6
Minor cleanup
10 years ago
5062bd142b
Significant state ownership refactor following class relationship analysis. Probably a bit more to be done here, but better than it was.
10 years ago
bd0d3aa01e
Minor cleanup
10 years ago
83289b1e45
Following up on the idea that the "public interface" to HikariCP should be though of as residing in the base of the package.
10 years ago
66f14b08ec
Minor cleanup
10 years ago
1571049ec0
Move interfaces.
10 years ago
cd8c4d578a
Move CloseSource implementations into interface, co-resident with factory.
10 years ago
b249a03a6f
Rename PoolUtilities to PoolElf ... following our *Elf naming convention (eg. UtilityElf)
10 years ago
052a86a76e
Rename PropertyBeanSetter to PropertyElf
10 years ago
1e4f078d5d
Remove code meant to handle what is not believed to be a non-existent race condition.
10 years ago
f5c248c4f4
Cleanup
10 years ago
3b0cf24e5c
Reformatting
10 years ago
aaa58a548b
If we're on Java 7, and Dropwizard metrics core happens to be present, use their LongAdder rather than falling back to the Java 7 AtomicLong.
10 years ago
b0df3a82c7
JavaDoc and method renaming
10 years ago
2f303973ec
Remove getConfiguration() accessor
10 years ago
851b92736c
Rename configuration member to config.
10 years ago
04fb8b646a
Rename configuration member to config.
10 years ago
a9aa10095f
Handle case where connectionTimeout or validationTimeout are set by HikariConfigMBean (after the validateNumerics() method has already been called), ensure validationTimeout stays sane.
10 years ago
4cb8d4d7d8
Minor cleanup
10 years ago
8993f4d0be
Minor cleanup suggested by Nitin
10 years ago
c6830d3708
Rename method
10 years ago
1bb1f60548
Minor refactor.
10 years ago
cb50434e73
fix unit test
10 years ago
afc13ee150
Store the network timeout captured at addConnection()-time and use it to reset the network timeout at connection close if the network timeout has been altered by the user.
10 years ago
27b7f5a34e
Revert "If the user is calling setNetworkTImeout() and specifying their own Executor instance, we need to "restore" their Executor instance whenever we "reset" the network timeout after modifying it for the duration of HikariCP internal methods (for example in the isConnectionAlive() check)."
...
This reverts commit 8ad630643b
10 years ago
b7253d18ed
Fix inconsistency in clock calculations.
10 years ago
678cb55fd5
Pin the ThreadPoolExecutor keepAliveTime at 15 seconds, this should allow for reasonable reuse while not keeping idle threads around indefinitely.
10 years ago
8ad630643b
If the user is calling setNetworkTImeout() and specifying their own Executor instance, we need to "restore" their Executor instance whenever we "reset" the network timeout after modifying it for the duration of HikariCP internal methods (for example in the isConnectionAlive() check).
10 years ago
31695bd4a0
Minor cleanup. Remove unused parameter.
10 years ago
f601f48900
Minor cleanup.
10 years ago
e9294f7b84
Minor cleanup.
10 years ago
dbe40c1870
Minor cleanup.
10 years ago
df02830e66
Minor cleanup.
10 years ago
40c59e61e3
Minor cleanup.
10 years ago
67b2f81aec
Fix boolean operator.
10 years ago
ef57e116a7
Minor cleanup.
10 years ago
00cb517958
Minor cleanup.
10 years ago
4cc0c8af7b
Minor cleanup.
10 years ago
bab38c14c6
Minor cleanup.
10 years ago
8ac410976b
Improve test coverage.
10 years ago
ab5f9a7faf
HikariDataSource already guards against multiple invocations.
10 years ago
baee923a48
Move utility method into JavassistProxyFactory
10 years ago
b74d708302
Remove unused class
10 years ago
242a3ef141
Pre-generate proxy classes, removing runtime dependency on Javassist.
10 years ago
dcaa5ac3f9
Pre-generate proxy classes, removing runtime dependency on Javassist.
10 years ago
74a78beab7
Reduce overhead and accuracy of Dropwizard gauges.
10 years ago
6b3a689cea
Comment #318 add check to avoid instantiation of mbean server in the case that registration is disabled.
10 years ago
8d45526f4d
Allow (undocumented/unsupported) overriding the use of WeakReferences.
10 years ago
2e84909a63
Allow setting the ScheduledThreadPoolExecutor.
10 years ago
ab901f544d
Minor cleanup
10 years ago
dd095f61f2
Declaring fields final prevents the copyState() method from working.
10 years ago
29351e811e
Merged #316 selective merge
10 years ago
61d07c24e2
Remove our "ported" Java 8 LongAdder and Striped64.
10 years ago
385da61360
Merge branch 'dev' of https://github.com/brettwooldridge/HikariCP into dev
...
* 'dev' of https://github.com/brettwooldridge/HikariCP :
Suppress unchecked warning
10 years ago
230c019e61
Remove our "ported" Java 8 LongAdder and Striped64.
10 years ago
e52ccc2dd2
Suppress unchecked warning
10 years ago
c9041c83f2
Fixes #307 implement a ClockSource that is backed by either System.currentTimeMillis() or System.nanoTime() depending on the platform.
10 years ago
53fe3b5b51
Fixes #229 suppress debug log at shutdown
10 years ago
be60783476
Hasten shutdown
10 years ago
72710b0f06
Allow the user to control whether WeakReference objects are used within ThreadLocals or not (default is not).
10 years ago
f3aee853c0
Abandon the WeakReference model ... this was just for Tomcat, and Tomcat can handle it (even though it logs a stupid severe warning).
10 years ago
bf011686eb
nanoTime() rollbacks
10 years ago
f65585b9f7
Java 7/8 cleanup
10 years ago
acc322ee1b
Remove staggling nanoTime() calls.
10 years ago
b135955bf8
Remove staggling nanoTime() calls.
10 years ago
cb37a6d730
Merge branch 'experimental' into dev
...
* experimental:
Add retrograde time motion detection, with soft-eviction.
Fix unit test breakage and warnings.
FastList reuse and other minor optimizations.
10 years ago
6988df815a
Add retrograde time motion detection, with soft-eviction.
10 years ago
c8adf48b2d
Fix unit test breakage and warnings.
10 years ago
54c70c7c6b
FastList reuse and other minor optimizations.
10 years ago
dbdc196a24
Selective merge of dev changes.
10 years ago
84a0b48d92
Selective merge of dev changes.
10 years ago
0aa8dbe961
#307 use System.nanoTime() most places that matter.
10 years ago
173b8d53d4
#307 use System.nanoTime() most places that matter.
10 years ago
6811e36741
Somewhat mitigate minor performance regression.
10 years ago
e25b4ace4c
Minor cleanup and comments.
10 years ago
e156d71693
Fix unsafe accessor.
10 years ago
fcd99ad97c
Include Java 8 classes in util so we can run on Java 7.
10 years ago
dd7c9a9add
Include Java 8 classes in util so we can run on Java 7.
10 years ago
7611d661d5
ConcurrentBag optimisations to streamline the requite() path, as well as the borrow() contended path.
10 years ago
142aa6e35e
Just experimenting...
10 years ago
1aef63a1f7
Merge branch '2.3.x' into dev
...
* 2.3.x:
Update release version
[maven-release-plugin] prepare for next development iteration
[maven-release-plugin] prepare release HikariCP-2.3.7
Update change log.
Escew fastpath if there are pending threads waiting to avoid starvation of those threads.
10 years ago
ef43827a7b
Fix mis-merge.
10 years ago
ccdeeb0746
Merge selected parts of pull request.
10 years ago
0837a818bb
Merge branch 'experimental' into dev
...
* experimental:
Experimental concurrentbag fairness changes. Starvation was observed under high load.
10 years ago
d8954d92b6
Merge commit 'ace24b3b9cdff86c40ec2c90ab48a28f2e29a69e' into dev
...
* commit 'ace24b3b9cdff86c40ec2c90ab48a28f2e29a69e':
Prevent race in close()
Make sure temporary pool is shut down
Fix some issues found by Idea inspections
Reuse pool name
Fix JavaDoc
Use path API
10 years ago
120b2deeba
Merge branch '2.3.x' into dev
...
* 2.3.x:
A race condition was observed under high load when a lot of connections expire at the same time, causing the pool to spike unnecessarily high.
10 years ago
56016a99cc
Merge branch '2.3.x' into dev
...
* 2.3.x:
Fix invalid JNDI test
Allow a specifically set DataSource to override other settings. Also, in the case of a driver-based config, we were not initialising the network timeout executor property.
Fixed #308 try harder at resolving the driver by various means when driverClassName and jdbcUrl are both specified.
Fixed #308 try harder at resolving the driver by various means when driverClassName and jdbcUrl are both specified.
10 years ago
2f5ea9073b
Better.
10 years ago
dc91fcc1b9
More concurrency tests.
10 years ago
b24cc00f05
Improvements. Performance still off of where it needs to be in unconstrained pools.
10 years ago
ace24b3b9c
Prevent race in close()
10 years ago
8da7ced9a8
Make sure temporary pool is shut down
10 years ago
ed09efc652
Fix some issues found by Idea inspections
10 years ago
6ab6954641
Reuse pool name
10 years ago
f338545783
Fix JavaDoc
10 years ago
3dc3f619b4
Use System.nanoTime() to measure time intervals
10 years ago
72b92390bf
Experimental concurrentbag fairness changes. Starvation was observed under high load.
10 years ago
9479273470
Use path API
10 years ago
7f50428eff
merge
10 years ago
a0e954f858
Additional test ... not run during unit test, but useful for stressing the pool
10 years ago
06996380b5
Eliminate some String.format() calls. Left one I like for readability.
10 years ago
779770c2c8
Eliminate some String.format() calls. Left one I like for readability.
10 years ago
9353ed1c29
Add log to inform users of Hibernate 4.3.6+ support.
10 years ago
c5b80d4665
Just a little nicer to read.
10 years ago
5ff480a62e
Remove the only String.format() call that could possibly have any effect on performance. Left the others, they're more readable.
10 years ago
ac8cb59256
Remove dead code
10 years ago
be26c1cf71
Scrub, scrub ... clean the code
10 years ago
d569a62316
Allow setNetworkTimeout() to throw, and be handled upstream.
10 years ago
0742d3181c
Cleanup suggested by Nitin
10 years ago
234328e0de
More teImprove test coverage.
10 years ago
Brett Wooldridge
Nitin
Hugh Lee
yaojuncn
Ruben Dijkstra
Arthur D'Andréa Alemar
Mikhail Mazurskiy