Commit Graph

142 Commits (98810d9251f9170364f8001df63510c09b9885d3)

Author SHA1 Message Date
Brett Wooldridge e94d920595 Fixes #512 back port to 2.3.x stream. 9 years ago
Brett Wooldridge f0ba4b7188 Fixed issue with new proxy class generation whereby Java 6 classes were generated as extending java.lang.AutoClosable, which was not introduced until Java 7. 9 years ago
Brett Wooldridge 2c632e7566 Fixes major class version number for generated proxy classes. 9 years ago
Brett Wooldridge 33a4bbe54a Back port build-time javassist proxy generation from 2.4.x to 2.3.x. 10 years ago
David Schlosnagle 5323c1adbb Move internal private method, make statement final
Address code review comments
10 years ago
David Schlosnagle e19c687443 Ensure closed connections returned to pool
If an exception occurs while closing a connection's open statements
(e.g. NullPointerException due to concurrent close of statement with
connection), the connection was not returned to the pool.

We now check for this possibility and ensure the connection is returned
to the pool.
10 years ago
Brett Wooldridge ada15b63d6 Logging useful to troubleshoot slow pool cycling. 10 years ago
Brett Wooldridge 0d245bf1f8 Fix #338 duplicate SQLState from cause into our SQLTimeoutException 10 years ago
Brett Wooldridge e51cd98d06 Fix #340 ignore exception setting read only 10 years ago
Brett Wooldridge 60e0eb1b8b Fix #334 caused by moving the ``HikariPoolMBean`` into the ``com.zaxxer.hikari`` package. Classes with the ``xxxMBean`` naming convention must reside in the same package. Renaming the class to ``xxxMXBean`` allows it to reside anywhere. 10 years ago
Brett Wooldridge 276b919e04 Add driver.acceptsUrl() check. 10 years ago
Brett Wooldridge 24d03706e2 Add driver.acceptsUrl() check. 10 years ago
Brett Wooldridge 46669f70d0 Merge improved close connection debug logging into 2.3.x branch. 10 years ago
Brett Wooldridge 7caebb13a2 Fixes #318 add check to avoid instantiation of mbean server in the case that registration is disabled. 10 years ago
Brett Wooldridge d4e426ba48 Fixes #229 suppress debug log at shutdown 10 years ago
Brett Wooldridge 11aab3db51 Escew fastpath if there are pending threads waiting to avoid starvation of those threads. 10 years ago
Brett Wooldridge 43910e61df A race condition was observed under high load when a lot of connections expire at the same time, causing the pool to spike unnecessarily high. 10 years ago
Brett Wooldridge 04a2234fec Fix invalid JNDI test 10 years ago
Brett Wooldridge 20f47c337b Allow a specifically set DataSource to override other settings. Also, in the case of a driver-based config, we were not initialising the network timeout executor property. 10 years ago
Brett Wooldridge fc23bccf01 Fixed #308 try harder at resolving the driver by various means when driverClassName and jdbcUrl are both specified. 10 years ago
Brett Wooldridge 9c80913d1f Fixed #308 try harder at resolving the driver by various means when driverClassName and jdbcUrl are both specified. 10 years ago
Brett Wooldridge cd457367f7 Fix #289 fixed issue where a connection that was checked-out, never used for longer than the DB connection timeout, and then returned to the pool could bypass the aliveness check and be given to another caller of getConnection(). 10 years ago
Brett Wooldridge c94a20e187 Comment #289 Hasten garbage collection of Connections after close 10 years ago
Brett Wooldridge 76f80fd51f Fix #288 allow explicit definition of driverClassName to override DriverManager.getDriver(url) located driver. 10 years ago
Brett Wooldridge 2cabded7f4 Fix #286 fix regression in Dropwizard runtime dependency 10 years ago
Brett Wooldridge e68bb6e833 Adjust the leak task stacktrace to eliminate HikariCP from the leak stacktrace. 10 years ago
Brett Wooldridge 538546e630 Move LeakTask into pool package 10 years ago
Brett Wooldridge 3ca1d0b3f1 Fix #285 ensure all properties are Strings when passed to driver's connect method 10 years ago
Brett Wooldridge 46b7589026 Improve leak logging 10 years ago
Brett Wooldridge 0e242affc0 Fixes #279 allow Dropwizard MetricTracker and HealthCheckTracker to be set after pool startup (one time). 10 years ago
Brett Wooldridge d3bff837b7 Remove connectionInitSql deprecation. 10 years ago
Brett Wooldridge f82a5afe2d Fixes #280 make logger non-static and use getClass() 10 years ago
Brett Wooldridge f7df7cd0b0 Fixes #275 make global lock non-static 10 years ago
Thies Edeling 59bc166268 #273, special case for when called to unwrap a DataSource, copying the same behavior as the ConnectionProvider implementations by Hibernate. 10 years ago
Brett Wooldridge 6833c25ab6 Merge branch '2.3.x' of github.com-brettwooldridge:brettwooldridge/HikariCP into 2.3.x
# By Brett Wooldridge (1) and johnon (1)
* '2.3.x' of github.com-brettwooldridge:brettwooldridge/HikariCP:
  Fix #269 Guard against drivers that construct an SQLException where the 'cause' is self-referential.  Hopefully the cycle is not multi-layers deep, because this check will only guard against one "loop".
  Allows Hikari to look up an arbitary JNDI resource name for the metric registry
10 years ago
Brett Wooldridge 9804b8602e Fixes #272 Throw a typed exception for pool initialization failures. 10 years ago
Brett Wooldridge a310df95d7 Fix #269 Guard against drivers that construct an SQLException where the 'cause' is self-referential. Hopefully the cycle is not multi-layers deep, because this check will only guard against one "loop". 10 years ago
johnon 701517d3b8 Allows Hikari to look up an arbitary JNDI resource name for the metric registry 10 years ago
Brett Wooldridge 196632b82e Experimental change for #260 to allow looking up Dropwizard MetricRegistry or HealthCheckRegistry via JNDI (for example in Tomcat). 10 years ago
Brett Wooldridge dd87bbde86 fixes #247 add additional check to quietlyCloseConnection(), demote some logging to debug so as not to freakout users 10 years ago
Brett Wooldridge 885b807ebb fixes #242 add message to leak exception. 10 years ago
Brett Wooldridge 66b64153e1 #241 add Dropwizard HealthCheck support. Still needs documentation. 10 years ago
Brett Wooldridge 778ff0650f Remove the Codahale shiim 10 years ago
Brett Wooldridge 0ffb90d97d Add additional debug-level logging. 10 years ago
Brett Wooldridge ea3eb38533 Fix maxIdleTime validation 10 years ago
Brett Wooldridge 6fd7b8a2c8 Fixed#245 allow a maxLifetime of 30 seconds 10 years ago
Brett Wooldridge 317c966e11 Fix #240 correct error message 10 years ago
Brett Wooldridge 2667687180 Fixed#233 shutdown the pool during fail-fast initialisation on failure. 10 years ago
Brett Wooldridge 5e3cb6865b timeoutMs parameter no longer needed with addition of validationTimeout 10 years ago
Brett Wooldridge 80a2442d96 timeoutMs parameter no longer needed with addition of validationTimeout 10 years ago