Fixes #272 Throw a typed exception for pool initialization failures.

hikaricp-common/src/main/java/com/zaxxer/hikari/pool/BaseHikariPool.java

@@ -497,7 +497,7 @@ public abstract class BaseHikariPool implements HikariPoolMBean, IBagStateListen
             try {
                if (!addConnection()) {
                   shutdown();
-                  throw new RuntimeException("Fail-fast during pool initialization", lastConnectionFailure.getAndSet(null));
+                  throw new PoolInitializationException(lastConnectionFailure.getAndSet(null));
                }
    
                ConnectionProxy connection = (ConnectionProxy) getConnection();
@@ -506,11 +506,11 @@ public abstract class BaseHikariPool implements HikariPoolMBean, IBagStateListen
             }
             catch (SQLException e) {
                shutdown();
-               throw new RuntimeException("Fail-fast during pool initialization", e);
+               throw new PoolInitializationException(e);
             }
          }
          catch (InterruptedException ie) {
-            throw new RuntimeException("Fail-fast during pool initialization", ie);
+            throw new PoolInitializationException(ie);
          }
       }
 
@@ -531,16 +531,6 @@ public abstract class BaseHikariPool implements HikariPoolMBean, IBagStateListen
       return configuration.getConnectionCustomizer();
    }
 
-   /**
-    * @param healthCheckRegistry
-    */
-   private void registerHealthChecks(Object healthCheckRegistry)
-   {
-      if (healthCheckRegistry != null) {
-         
-      }
-   }
-
    public final void logPoolState(String... prefix)
    {
       if (LOGGER.isDebugEnabled()) {

hikaricp-common/src/main/java/com/zaxxer/hikari/pool/PoolInitializationException.java

@@ -0,0 +1,35 @@
+/*
+ * Copyright (C) 2015 Brett Wooldridge
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.zaxxer.hikari.pool;
+
+/**
+ * A custom exception thrown if pool initialization fails.
+ *
+ * @author Brett Wooldridge
+ */
+public class PoolInitializationException extends RuntimeException
+{
+   private static final long serialVersionUID = 929872118275916520L;
+
+   /**
+    * Construct an exception, possibly wrapping the provided Throwable as the cause.
+    */
+   public PoolInitializationException(Throwable t)
+   {
+      super("Exception during pool initialization", t);
+   }
+}