Commit Graph

328 Commits (8f9c0b5935f90e89caef131f3dda1148d2bc600f)

Author SHA1 Message Date
Manabu Matsuzaki 4852678a7b `mockMeterRegistry#find(String)` doesn't seem to return null (#1113) 7 years ago
Brett Wooldridge 7bff6723c1 Fixes #1095 fix breakage caused by sealed configuration with respect to special handling
for the metricsRegistry and metricsTrackerFactory properties, which are allowed to be
altered *once* after the pool has started.
7 years ago
NersesAM 91bd7dfb33 Allowing anonymous subclasses of MetricRegistry. Also changing checks for metrics libraries from classname contains to assignableFrom the metrics class (#1089) 7 years ago
Brett Wooldridge 90f1887b4d Fix bug in sealed configuration. 7 years ago
Brett Wooldridge 64d91e8ea3 Fixes #1060 (Really) support experimental throw-if-suspended functionality. 7 years ago
Stanislav Savulchik 18379538fb Enable quantiles calculation in prometheus metrics (#1058) 7 years ago
Brett Wooldridge 5ba71e0e83 Minor cleanup. 7 years ago
stepbeekio a3637fb945 Fixes #1061 HikariProxyStatement.GetGeneratedKeys does not return ProxyResultSet. (#1062) 7 years ago
Brett Wooldridge c3ab0aa0ca Fixes #1053 seal the HikariDataSource after the pool is started. Improve constructor documentation. 7 years ago
Stephan Schroevers 4a4c139654 Fix Java file permissions (#1015)
Some files were inadvertently marked executable.
7 years ago
testingsavvy 8ec0c63282 test that FastList#clear() sets all elements to null (#1001) 7 years ago
Fred Deschenes 4d484ea635 Rename copyState to copyStateTo (#991)
Fixes #892 and should prevent further confusion.
8 years ago
Brett Wooldridge 238041f9e5 Fix test case failure. 8 years ago
Brett Wooldridge f8cc907f24 Test for javassist code generation. 8 years ago
Brett Wooldridge 051f78c276 Alpha-level support for micrometer metrics 8 years ago
cenk akın 78d12ea0cf Fix Prometheus metric collector for multiple data config (#940) 8 years ago
cenk akın fa79e4ece0 Fix prometheus metrics to support multiple hikaricp pools (#890) 8 years ago
Brett Wooldridge 61be9b923d Fixes #880 Fix race condition caused by sorting collection
while the condition of sort can change.
8 years ago
Lorenzo Lucherini b626396496 Added support for non-default Prometheus CollectorRegistry (#876)
* Added support for using a Prometheus CollectorRegistry other than the default one

* Fixed a broken test
8 years ago
Brett Wooldridge e62e85cee8 Extend timeout for Java 9. Will investigate why it is
necessary on travis-ci later.
8 years ago
Brett Wooldridge 04f6d4a2bd Make test resilient to fluctuating pool names, caused by
reuse or non-reuse of forks during testing.
8 years ago
Brett Wooldridge f1f7873432 Resolve unit test failures. 8 years ago
Brett Wooldridge 8db418f969 Reset log levels reliably. 8 years ago
Brett Wooldridge 25fde9c11d Suppress tests currently untestable under Java 9 (when building on Java 9). 8 years ago
Brett Wooldridge 304ca41775 Add additional MBean test. 8 years ago
Brett Wooldridge 0b5650bde7 Unit test for over-saturated pool with traffic dropping to agreement
with capacity.
8 years ago
Brett Wooldridge 65171205d6 Unit test for over-saturated pool with traffic dropping to agreement
with capacity.
8 years ago
Will Vuong 41900e07aa Fix PrometheusMetricsTrackerTest 8 years ago
Will Vuong d875e838c3 pool.Wait metric doesn't include timed out requests
We noticed that the pool.Wait metric only captured the timings for successful connection requests and doesn't capture when a connection request times out.

I didn't want to mess with IMetricsTrackerDelegate.recordBorrowStats() so I created a recordBorrowTimeoutStats() and implementation in MetricsTrackerDelegate instead.  Feel free to tweak to your liking.
8 years ago
Brett Wooldridge 0ab35e7445 Minor cleanup. 8 years ago
Brett Wooldridge b2cd44f97d Remove deprecated method call. 8 years ago
Brett Wooldridge 243490773b Move TestFastList, add iterator test. 8 years ago
Brett Wooldridge 1587198e6a Change the internal handling of the initializationFailTimeout. 8 years ago
Brett Wooldridge 033855209e ClockSource cleanup (Java 8'ification); makes everything more readable
due to static import ability.
8 years ago
Brett Wooldridge 72e862d298 Fix race condition regression in ConcurrentBag and various other cleanup. 8 years ago
Brett Wooldridge 9efa2f7098 Add a Tomcat web application ClassLoader/ThreadLocal leak detection test. 8 years ago
Brett Wooldridge 4a454a4e9e Fixes #614 Add the connection created during checkFailFast() to the pool
unless minimumIdle=0.
8 years ago
Brett Wooldridge becaae4554 Unit test cleanup (lots of static imports). Also, the pool name will be set to the
method name of the test automatically (where possible).
8 years ago
Brett Wooldridge 61ddcb41eb Additional unit test. 8 years ago
Brett Wooldridge ceffabb39f Cleaner pool configuration debug logging. 8 years ago
Brett Wooldridge c3ef9ba062 Close#801 Additional changes, including eliding the submission of a new
PoolEntryCreator to the addConnectionExecutor when there are
already enough queued tasks to cover number of pending waiters.
8 years ago
shendley f0bc58279d #776 updated thread vs connection test to gather total and maxActive when there is no work to do to verify that we don't add any extra connections 8 years ago
Brett Wooldridge bfcb95ae75 Remove deprecated API usage 8 years ago
Brett Wooldridge 579597aae9 Fixes #770 #786 added additional handling in HikariDataSource.getConnection(),
and added unit test.
8 years ago
Brett Wooldridge 14b11c025c Cleanup Java IDE warnings in tests. 8 years ago
Brett Wooldridge 346a2f5977 Fix bug introduced by f129797, plus some minor cleanup. 8 years ago
shendley 18077768d1 add a "Connect" histogram metric for tracking how many and how long connections are taking #518 and #769 8 years ago
shendley f129797b8b Fixes #774 Merged changes from @samhendley with modifications. 8 years ago
Brett Wooldridge 7bab1a8ccd Fixes #770 by adding a new property initializationFailTimeout and deprecating
initializationFailFast.
8 years ago
Brett Wooldridge e3b79ee044 Fixes #770 by adding a new property initializationFailTimeout and deprecating
initializationFailFast.  Exception path still needs some work… coming in the
next commit.
8 years ago
Martin Stříž 1bd23423b9 Cancel HouseKeeper task on pool shutdown (#741)
Periodic house-keeping task is scheduled during construction of
HikariPool. The resulting scheduled task is not stored and therefore it
is not cancelled during pool shutdown.

With standard behaviour, when executor is managed by HikariPool itself,
it is not an issue, because the executor is shut down on pool shutdown.
But when a custom (long running) scheduled executor is supplied via
setScheduledExecutorService, tasks are kept indefinitely causing a
memory leak.
9 years ago
Brett Wooldridge 8361cf5afe Fix stability of HikariCPCollectorTest for travis-ci build 9 years ago
Brett Wooldridge ac08f5c16b Cleaner pool size accounting. 9 years ago
Brett Wooldridge 15ef1bd290 Misc. compiler warning cleanups. Still quite a few remaining in the tests... 9 years ago
Brett Wooldridge d16f4eee5b Fix test failure caused by reformatting code 9 years ago
Brett Wooldridge d5cb614639 Fix test failure caused by reformatting code 9 years ago
Brett Wooldridge b343eb8ae1 Remove compiler warnings 9 years ago
ams2990 115453a282 Change what character is used for microseconds (#707)
Currently, it uses GREEK SMALL LETTER MU (U+03BC), which doesn't display in the command prompt on Windows. After this commit, it uses MICRO SIGN (U+00B5).
9 years ago
Jack 53d479cf03 added remove of ConnectionTimeoutRate and refactored metric names into constants (#698) 9 years ago
Brett Wooldridge 6edaa336a6 CHANGES log and cleanup. 9 years ago
puntogil ddfe0ab6cb Add license headers (#688) 9 years ago
Brett Wooldridge e6ece36c32 Merge commit '953b0be06d7517e63eebb6ef61c6d734621eae1e' into dev 9 years ago
TestSuiteReductionResearch ed2cce6eda Ignoring test that is redundant for com.zaxxer.hikari.pool.TestConnectionTimeoutRetry.testConnectionRetries (#678) 9 years ago
Nitin 953b0be06d test for failure in case of InitializationFailFast 9 years ago
Nitin 3716edfa57 fix test 9 years ago
Tokuhiro Matsuno 76cf343c8b Add prometheus support (#632) 9 years ago
Brett Wooldridge 8dde168adb Possibly Fixes #606 Fixes ##610 housekeeper was running before all class members were initialised leading to an NPE in the housekeeper. Whether or not a particular VM would recover depends somewhat on its memory model. The pool on OS X did recover after the initial failure. 9 years ago
Brett Wooldridge db989fff2d Merge pull request #590 from mtambara/concurrent
Add test to demonstrate concurrency problem
9 years ago
Brett Wooldridge 15037cc156 time-out was too tight and causing sporadic travis-ci failures. 9 years ago
Matthew Tambara d59771cd16 Add test to demonstrate concurrency problem 9 years ago
Nitin 6ed3b18591 small but important fixes
removed var

removed resetting, delink validationTimeout from connectionTimeout

one less ref per leak task. renamed start() to schedule()

made some fields final

init of leakDetectionThreshold is not required for other instances

toString using elapsedDisplayString

fix: update poolEntry.lastBorrowed in case NopMetricsTrackerDelegate

fix tests.. try1

setting isCommitStateDirty conditionally in setAutoCommit()

again, avoid calling getNextException :)

setting lastAccess in close()

setting lastAccess required only in ctor and close

removed borrowed time from PoolEntry#toString()

now that lastAccess is moved to close(), moved condition too

one less call to System.nanoTime()

fix. using toNanos()

reverted toNanos() change, got too cumbersome

removed two calls to system time

timeout is not clock time :)

only one call saved but precise 'time taken to borrow'

unlink validation of connectionTimeout with maxLifetime

Merge

Revert
9 years ago
Brett Wooldridge fc1aea9609 Merge branch 'dev' of https://github.com/nitincchauhan/HikariCP into dev 9 years ago
Guido Medina bf83c624ed IntelliJ inspections fixes, Maven dependencies and plugins updated to latest stable. 9 years ago
Nitin 1b1b63fb3e renamed ProxyLeakTask as it has nothing to do with 'proxy' 9 years ago
Nitin 1a9494596f test failure fix 3 9 years ago
Nitin 5a41fee89b test failure fix 2 9 years ago
Nitin bd3e570192 added, corrected validation and test 9 years ago
Nitin 47ac982cc3 create leak task first and reverted long to int change 9 years ago
Nitin 2e5dd85133 replaced volatile long with int and import static TimeUnit.* 9 years ago
Nitin 2b6da07d26 cleanup 9 years ago
Nitin 0d0eec16ea moved check to call(), start thread in other loop 9 years ago
Nitin a007e730be race test: exit loop on exception 9 years ago
Nitin 76d490d2de removed explicit call to fillInStackTrace() 9 years ago
Brett Wooldridge 4a5ffcdd05 Merge pull request #556 from Shredder121/timing-windows
Skip the `testMetricUsage` test on Windows
9 years ago
Brett Wooldridge 68a52f1431 Merge branch 'dev' of https://github.com/nitincchauhan/HikariCP into dev 9 years ago
Brett Wooldridge 6f49960d13 Spelling and naming. 9 years ago
Brett Wooldridge d4d6d759de Issue #547 Decreased allowable minimum connectionTimeout and validationTimeout to 250ms. 9 years ago
Brett Wooldridge 91dbe31ff2 Fixes #559 improve logging of time shifts, allow retrograde time adjustments 9 years ago
Ruben Dijkstra 8adf36bc3d Skip the `testMetricUsage` test on Windows
My 75th percentile is indeed 250ms, but _sometimes_ returns 249ms
9 years ago
Nitin 6769539f10 close ds 9 years ago
Nitin c362e8bb35 fixed test 9 years ago
Nitin a56f5dcb2d removed ThreadPoolExecutor for use with setNetworkTimeout 9 years ago
Brett Wooldridge a270577dc3 Merge branch 'dev1' of https://github.com/nitincchauhan/HikariCP into dev 9 years ago
Brett Wooldridge 48a8afd141 Fixes #495 implement iterator for Tomcat leak detection. 9 years ago
Nitin 926167598a Fixed Test 9 years ago
Nitin 1e24d50f97 make sure pool is ready before reseting counter 9 years ago
Nitin 4ec2e80c1e reset StubConnection.count after pool initialization 9 years ago
Nitin b88b314adc fixed tests :) 9 years ago
Nitin 18c0e2d6b0 assertion with text 9 years ago
Nitin af93c99019 set Sleepbackoff time to maximum 10 seconds 9 years ago