Commit Graph

240 Commits (877e451daed20eabd796cdfa33f0bb252399e9f4)

Author SHA1 Message Date
Brett Wooldridge 0999b831d5 Revert double-check locking for cleaner memory-fence based code. 10 years ago
Brett Wooldridge 01221526f8 Forget about accounting sanity checks when the pool is going down (who cares?). Prevent connections from being added when the pool is suspended. Remove eviction from from abortActiveConnections() as it is already done in softEvictConnections(). "break" in abort method should have been continue. 10 years ago
Brett Wooldridge ad3f9eaa55 Go ahead and implement double-checked locking, this is a low traffic method. 10 years ago
Brett Wooldridge d71db82715 Fix #198 improve shutdown handling with respect to asynchronous close() calls that might be occurring. 10 years ago
Brett Wooldridge d097828d9d Fix #198 back out original optimisation as it masks application errors. 10 years ago
Brett Wooldridge 7485e2dd8b Fix #199 fix possible race, while avoiding heavy weight synchronisation 10 years ago
Brett Wooldridge dda85af7d6 Make isClosed volatile for cross-thread visibility. 10 years ago
Brett Wooldridge 29629e5468 Try to fix intermittent timeout in tests 10 years ago
Brett Wooldridge 24995e3cba cleanup 10 years ago
Guillaume Smet db0231ee5b Fix copy of properties when using a jdbc url.
Constructor Properties(Properties properties) is not a copy constructor.
10 years ago
Guillaume Smet 2b1e0f77bb Fix copy of properties when using a jdbc url.
Constructor Properties(Properties properties) is not a copy constructor.
10 years ago
Brett Wooldridge bbb5061130 Cleanup. Minor API change for new feature. 10 years ago
Brett Wooldridge 7604d30434 Fix #181 implement pool suspend/resume for use in failover 10 years ago
Brett Wooldridge 48e0acb982 Fix a bug reported on Stackoverflow. 10 years ago
Brett Wooldridge 4c0c9711e1 Fix #187 only set transaction isolation if it differs from the default. 10 years ago
Brett Wooldridge 04e48feb30 Set IS_JDBC41 flag if the call to setNetworkTimeout() succeeds. 10 years ago
Brett Wooldridge c1efc19c76 Remove isUseNetworkTimeout member. 10 years ago
Brett Wooldridge ca054975da Minor cleanup (removal of redundant code). Testing JDBC 4.1 via getNetworkTimeout() is not viable on some drivers, but checking setNetworkTimeout() is. 10 years ago
Brett Wooldridge 546230c3bd Fix #185 additional checks for AbstractMethodError 10 years ago
Brett Wooldridge 1a1cf87c0e Tighten-up code. 10 years ago
Brett Wooldridge 5880aac801 Fix #183 use propertyNames() enumeration to ensure picking up default properties. 10 years ago
Brett Wooldridge 5b6d846a3c Remove calls to getConnectionTimeout(), rely on the member variable which is refreshed every 30 seconds. 10 years ago
Brett Wooldridge 2fdf515164 Fix #183 use propertyNames() enumeration to ensure picking up default properties. 10 years ago
Brett Wooldridge 6758ae4447 Improve readability a fraction. 10 years ago
Brett Wooldridge 0fe4e4a0f1 Tighten-up code. 10 years ago
Brett Wooldridge f53592a9ce Exclude proxies from coverage after adding a bundle of trivial methods (where writing tests just for coverage would be pointless) 10 years ago
Brett Wooldridge df8a3ba2be Minor test cleanup. 10 years ago
Brett Wooldridge ea4777d8fb Fix #178 rename closeIdleConnections() to softEvictConnections() and support "evict on return" 10 years ago
Brett Wooldridge 22389819d5 Fix #177 implement full transaction state tracking 10 years ago
Brett Wooldridge 28662ee045 Minor cleanup. 10 years ago
Brett Wooldridge 95d0e2494f Auto-commit init SQL (was broken after previous code re-ordering) 10 years ago
Brett Wooldridge 920873390d just code cleanup 10 years ago
Brett Wooldridge 9b7dfd2edb just code cleanup 10 years ago
Brett Wooldridge 1d0879c0ee Fix #175 add additional SQLFeatureNotSupportedException detection for misbehaved MariaDB driver 10 years ago
Brett Wooldridge 37e24d630a Fix #176 take the timeout value at face-value 10 years ago
Brett Wooldridge 3cc501ee3c Fix #172 Further shadow runtime dependency on Codahale metrics from reflection performed by Spring and other IoC containers. 10 years ago
Brett Wooldridge f619fbfb06 Move code from static initializer into invocable static method. 10 years ago
Brett Wooldridge 55fd70c097 Minor cleanup. 10 years ago
Brett Wooldridge 4132322201 Rename metrics. 10 years ago
Brett Wooldridge 267005cd9d Fixed #174. Move pool filling code to after the housekeeping thread has started. 10 years ago
Brett Wooldridge 05fcb3d00d Log a debug level message when codahale metrics is not found and we generate a stub. 10 years ago
Brett Wooldridge b64dc6fbf0 Revert over-aggressive optimization, and various cleanup. 10 years ago
Brett Wooldridge 3b83896e68 Remove dead code, fix-up excludes. 10 years ago
Brett Wooldridge b4558ee30e Log warning for deprecated property. 10 years ago
Brett Wooldridge 35a9e92ff0 Fix sporadic build failure after fillPool() changes. 10 years ago
Brett Wooldridge ab98b611f8 Initialize the codahale shim in the JNDI factory 10 years ago
Brett Wooldridge 82bb7c118f Remove (@Deprecate) jdbcConnectionTest property ... auto-detect it. Specification of connection test query overrides it. 10 years ago
Brett Wooldridge fcec343d4f Fix transient build failure caused by new asynchronous pool filling. 10 years ago
Brett Wooldridge cc736bb346 Some additional metrics. 10 years ago
Brett Wooldridge 7e04d7a422 Improve code coverage. 10 years ago
Brett Wooldridge 017044a5cf Improve code coverage. 10 years ago
Brett Wooldridge c2334a96cd Cleanup metrics more. Add CodaHale metrics tests. 10 years ago
Brett Wooldridge 0aa14d1d9b Start rework of metrics handling. 10 years ago
Brett Wooldridge 82474b9024 Fix logic error and update tests to accomodate new fill behavior. 10 years ago
Brett Wooldridge dc7cb59dc7 Code formatting. 10 years ago
Brett Wooldridge 9335e31f12 Only validate the first connection during fillPool() if initializationFailFast is true (which it is now by default). 10 years ago
Brett Wooldridge 7f9734e025 Minor code cleanup. 10 years ago
Brett Wooldridge 7297633894 Minor code cleanup. 10 years ago
Brett Wooldridge 0874952b9c Fix timeout seconds calculation bug, and minor cleanup. 10 years ago
Brett Wooldridge 1dab1f1be4 If available, apply networkTimeout to addConnection() as well. Plus other minor cleanup. 10 years ago
Brett Wooldridge da07a6c8b7 Remove debugging code and add coverage test for property setter. 11 years ago
Brett Wooldridge 57ae67a08a Improve test coverage. 11 years ago
Brett Wooldridge 8b96191726 Improve test coverage. 11 years ago
Brett Wooldridge c5a8e4786e Fix #167 by added special detection for whether query timeout is supported by the driver. 11 years ago
Brett Wooldridge 9cdcf2fd87 Add a configurable constant for the sleep bypass window. Still undocumented, considred internal. 11 years ago
Brett Wooldridge 073bea9f94 Minor test speedup 11 years ago
Brett Wooldridge b6eadf4c26 Log actual timeout milliseconds taken. 11 years ago
Brett Wooldridge 94bb1e5443 base DataSource.setLoginTimeout() off of connectionTimeout. Rather not introduce another pool property at this point. 11 years ago
Brett Wooldridge 04b3fe42cd Minor cleanup. May still change... 11 years ago
Brett Wooldridge d6652ee53b Minor cleanup. 11 years ago
Brett Wooldridge be99efba1d Fix #163 validation was incorrect 11 years ago
Brett Wooldridge ca9b82970c Exploit Connection network timeout if available. 11 years ago
Brett Wooldridge 9ba1f277cc Minor cleanup. 11 years ago
Brett Wooldridge 0b5dcd9353 Clean-up warnings, add addition check for idleTimeout > maxLifetime. 11 years ago
Brett Wooldridge f96f515cfe Fixed#163 do not require driver class name when JDBC URL is specified, newer drivers following the service registration model will be automatically located by the DriverManager. 11 years ago
Brett Wooldridge 89b3ce00ee Fixed#163 do not require driver class name when JDBC URL is specified, newer drivers following the service registration model will be automatically located by the DriverManager. 11 years ago
Brett Wooldridge bb33d91e15 Cleaner LeakTask internals. 11 years ago
Brett Wooldridge 50fbad2e8f Eliminate unnecessary null check. 11 years ago
Brett Wooldridge f8c0295a50 Cleaner LeakTask internals. 11 years ago
Brett Wooldridge b4df420781 remove inaccurate comment 11 years ago
Brett Wooldridge 872e9d642a Logging message correction, additional javadoc. 11 years ago
Brett Wooldridge ec91bff331 More code coverage tests. 11 years ago
Brett Wooldridge b140c9ed68 Change rejected handler policy for closeConnectionExecutor to CallRunsPolicy. 11 years ago
Brett Wooldridge 16dbc953d1 Remove unnecessary check. 11 years ago
Brett Wooldridge 2d7ff2e02b Little by little, more coverage -- up to 86% 11 years ago
Brett Wooldridge 558f18a8e3 ConcurrentBag tests, more correct DriverDataSource. 11 years ago
Brett Wooldridge 264e0bb3ca Remove redundant code from LeakTask 11 years ago
Brett Wooldridge 586c68b64d Hibernate test. 11 years ago
Brett Wooldridge 250581cef3 Move logger initialization. 11 years ago
Brett Wooldridge 1c010938a4 Remove MiscTest from hikaricp-java6 until we can figure out the sporadic failures on travis-ci. 11 years ago
Brett Wooldridge 8f24815a4a Trying to fix travis-ci failure, works locally. Not occasionally fails, seems to be timing sensitive. 11 years ago
Brett Wooldridge 681a7e515f Trying to fix travis-ci failure, works locally. 11 years ago
Brett Wooldridge a9bf05f5e1 Trying to fix travis-ci failure, works locally. 11 years ago
Brett Wooldridge 682826efe5 Try alternative class loader. 11 years ago
Brett Wooldridge ed67c24665 Test leak detection. 11 years ago
Brett Wooldridge aea7b69e9c Test leak detection. 11 years ago
Brett Wooldridge 9bd925a885 More coverage tests and redundant code removal. 11 years ago
Brett Wooldridge b47d1dc105 Remove redundant code. 11 years ago
Brett Wooldridge cb38844e8a DataSource unwrap tests. 11 years ago
Brett Wooldridge 14387d258e Additional shutdown tests. 11 years ago