6811e36741
Somewhat mitigate minor performance regression.
10 years ago
e25b4ace4c
Minor cleanup and comments.
10 years ago
e156d71693
Fix unsafe accessor.
10 years ago
fcd99ad97c
Include Java 8 classes in util so we can run on Java 7.
10 years ago
dd7c9a9add
Include Java 8 classes in util so we can run on Java 7.
10 years ago
7611d661d5
ConcurrentBag optimisations to streamline the requite() path, as well as the borrow() contended path.
10 years ago
142aa6e35e
Just experimenting...
10 years ago
1aef63a1f7
Merge branch '2.3.x' into dev
...
* 2.3.x:
Update release version
[maven-release-plugin] prepare for next development iteration
[maven-release-plugin] prepare release HikariCP-2.3.7
Update change log.
Escew fastpath if there are pending threads waiting to avoid starvation of those threads.
10 years ago
ef43827a7b
Fix mis-merge.
10 years ago
ccdeeb0746
Merge selected parts of pull request.
10 years ago
0837a818bb
Merge branch 'experimental' into dev
...
* experimental:
Experimental concurrentbag fairness changes. Starvation was observed under high load.
10 years ago
d8954d92b6
Merge commit 'ace24b3b9cdff86c40ec2c90ab48a28f2e29a69e' into dev
...
* commit 'ace24b3b9cdff86c40ec2c90ab48a28f2e29a69e':
Prevent race in close()
Make sure temporary pool is shut down
Fix some issues found by Idea inspections
Reuse pool name
Fix JavaDoc
Use path API
10 years ago
120b2deeba
Merge branch '2.3.x' into dev
...
* 2.3.x:
A race condition was observed under high load when a lot of connections expire at the same time, causing the pool to spike unnecessarily high.
10 years ago
56016a99cc
Merge branch '2.3.x' into dev
...
* 2.3.x:
Fix invalid JNDI test
Allow a specifically set DataSource to override other settings. Also, in the case of a driver-based config, we were not initialising the network timeout executor property.
Fixed #308 try harder at resolving the driver by various means when driverClassName and jdbcUrl are both specified.
Fixed #308 try harder at resolving the driver by various means when driverClassName and jdbcUrl are both specified.
10 years ago
2f5ea9073b
Better.
10 years ago
dc91fcc1b9
More concurrency tests.
10 years ago
b24cc00f05
Improvements. Performance still off of where it needs to be in unconstrained pools.
10 years ago
ace24b3b9c
Prevent race in close()
10 years ago
8da7ced9a8
Make sure temporary pool is shut down
10 years ago
ed09efc652
Fix some issues found by Idea inspections
10 years ago
6ab6954641
Reuse pool name
10 years ago
f338545783
Fix JavaDoc
10 years ago
3dc3f619b4
Use System.nanoTime() to measure time intervals
10 years ago
72b92390bf
Experimental concurrentbag fairness changes. Starvation was observed under high load.
10 years ago
9479273470
Use path API
10 years ago
7f50428eff
merge
10 years ago
a0e954f858
Additional test ... not run during unit test, but useful for stressing the pool
10 years ago
06996380b5
Eliminate some String.format() calls. Left one I like for readability.
10 years ago
779770c2c8
Eliminate some String.format() calls. Left one I like for readability.
10 years ago
9353ed1c29
Add log to inform users of Hibernate 4.3.6+ support.
10 years ago
c5b80d4665
Just a little nicer to read.
10 years ago
5ff480a62e
Remove the only String.format() call that could possibly have any effect on performance. Left the others, they're more readable.
10 years ago
ac8cb59256
Remove dead code
10 years ago
be26c1cf71
Scrub, scrub ... clean the code
10 years ago
d569a62316
Allow setNetworkTimeout() to throw, and be handled upstream.
10 years ago
0742d3181c
Cleanup suggested by Nitin
10 years ago
234328e0de
More teImprove test coverage.
10 years ago
7b393ac6f1
More teImprove test coverage.
10 years ago
edbe8f1d14
Improve test coverage.
10 years ago
f8de75b9f4
Improve test coverage.
10 years ago
9fa55d074d
Improve test coverage.
10 years ago
ae90802bc4
Improve test coverage.
10 years ago
5707921c6c
Remove warning suppression
10 years ago
f3f04f23fe
Change wording.
10 years ago
05454f7ae9
Minor cleanup.
10 years ago
0b7fa4382f
Minor cleanup.
10 years ago
d538f9864c
Fix build break caused by NPE ... dereferencing member before it is initialized.
10 years ago
2e916531d4
Fixed #299 disallow colon character in poolName when JMX MBean registration is enabled.
10 years ago
4d20b0aa07
Fix #300 add isClosed() method to HikariDataSource
10 years ago
bd5233b022
Fix exception message
10 years ago
f57de95b7e
Deprecate shutdown() on the datasource in favor of close()
10 years ago
9fb07a8724
Stronger deprecation.
10 years ago
61224ec672
Additional null check to avoid NPE during shutdown after initialisation failure
10 years ago
4a1a7785fe
Fix conditional.
10 years ago
084b2ae787
Cleanup suggested by Nitin
10 years ago
0b71a5f68a
Cleaner aesthetic
10 years ago
482c585e13
Merge branch '2.3.x' into dev
...
* 2.3.x:
Fix #289 fixed issue where a connection that was checked-out, never used for longer than the DB connection timeout, and then returned to the pool could bypass the aliveness check and be given to another caller of getConnection().
Update issue stats badge
10 years ago
b6b8ab93a6
Cleanup suggested by Nitin
10 years ago
e682bd79eb
Cleanup suggested by Nitin.
10 years ago
62d3dd4074
Comment #289 Hasten garbage collection of Connections after close
10 years ago
dd371f3572
Merge branch '2.3.x' into dev
...
* 2.3.x:
Comment #289 Hasten garbage collection of Connections after close
Comment #289 Hasten garbage collection of Connections after close
Conflicts:
hikaricp-java6/src/main/java/com/zaxxer/hikari/pool/HikariPool.java
hikaricp/src/main/java/com/zaxxer/hikari/pool/HikariPool.java
10 years ago
37d5cc722e
Merge branch 'master' into dev
...
* master: (40 commits)
Fix test breakage, plus some minor cleanup.
Remove multi-pool (DataSource.getConnection(username, password) support.
Exclude PoolInitializationException from coverage
Update README.md
Added jacoco to pom
Added profile for coveralls
Update .travis.yml
Change travis-ci configuration for master
More improved logging.
If the pool is maxed out, return 'true' from addConnection() so we stop trying to add the connection.
Fix #258 Improve logging of closed connection reason
Recombine into a single Java 7 compatible build.
Update README.md
Fix #288 allow explicit definition of driverClassName to override DriverManager.getDriver(url) located driver.
Mark scope as 'test'
Update README.md
Update CHANGES
[maven-release-plugin] prepare for next development iteration
[maven-release-plugin] prepare release HikariCP-2.3.5
Fix #286 fix regression in Dropwizard runtime dependency
...
Conflicts:
.travis.yml
README.md
hikaricp-common/pom.xml
hikaricp-common/src/main/java/com/zaxxer/hikari/AbstractHikariConfig.java
hikaricp-common/src/main/java/com/zaxxer/hikari/HikariConfig.java
hikaricp-common/src/main/java/com/zaxxer/hikari/proxy/JavassistProxyFactory.java
hikaricp-java6/src/test/java/com/zaxxer/hikari/TestMetrics.java
hikaricp-java7/pom.xml
hikaricp-java7/src/main/java/com/zaxxer/hikari/pool/HikariPool.java
hikaricp-java7/src/main/java/com/zaxxer/hikari/util/Java7ConcurrentBag.java
hikaricp-java7/src/main/resources/META-INF/codex.properties
hikaricp-java7/src/test/java/com/zaxxer/hikari/TestMetrics.java
hikaricp-java7/src/test/java/com/zaxxer/hikari/osgi/OSGiBundleTest.java
hikaricp-java7/src/test/resources/hibernate.properties
hikaricp-java7/src/test/resources/propfile1.properties
hikaricp-java7/src/test/resources/propfile2.properties
hikaricp-java7/src/test/resources/propfile3.properties
hikaricp/pom.xml
hikaricp/src/main/java/com/zaxxer/hikari/pool/HikariPool.java
hikaricp/src/main/java/com/zaxxer/hikari/proxy/JavassistProxyFactory.java
hikaricp/src/main/java/com/zaxxer/hikari/util/Java8ConcurrentBag.java
pom.xml
src/main/java/com/zaxxer/hikari/HikariConfig.java
src/main/java/com/zaxxer/hikari/pool/HikariPool.java
src/main/java/com/zaxxer/hikari/proxy/JavassistProxyFactory.java
src/main/java/com/zaxxer/hikari/util/ConcurrentBag.java
src/test/java/com/zaxxer/hikari/TestConcurrentBag.java
src/test/java/com/zaxxer/hikari/TestMetrics.java
10 years ago
b08b0d7656
Fix test breakage, plus some minor cleanup.
10 years ago
eeb56f36f8
Remove multi-pool (DataSource.getConnection(username, password) support.
10 years ago
ff9d5ff865
More improved logging.
10 years ago
50e1ec24ff
If the pool is maxed out, return 'true' from addConnection() so we stop trying to add the connection.
10 years ago
1ed525d351
Fix #258 Improve logging of closed connection reason
10 years ago
ded61125fe
Recombine into a single Java 7 compatible build.
10 years ago
3451c37445
Prepare for Java 6/7 to Java 8 split.
11 years ago
0f93425d75
Fix javadoc error.
11 years ago
7b8ac64a3e
Minor cleanup.
11 years ago
a7e8852a9f
Minor cleanup.
11 years ago
775cba7db5
Reformatting with new Eclipse formatter settings. Went with a variation of Sun-style, which leads to more compact method bodies, but still white-space to "highlight" class and method declarations.
11 years ago
0486c5904e
Minor cleanup.
11 years ago
d5a5a3e59e
Minor cleanup.
11 years ago
e79b4f7f16
Merge branch 'dev' of github.com:brettwooldridge/HikariCP into dev
...
* 'dev' of github.com:brettwooldridge/HikariCP:
Add IBM DB2 DataSource class to table.
Minor cleanup.
Minor cleanup.
More metrics groundwork.
Revert "Speculative fix for cross-thread visibility issue."
11 years ago
9ab0b17322
Performance optimizations. Remove unnecessary int -> long implicit conversions. These are hidden costs easily missed.
11 years ago
cc1401f5b2
Minor cleanup.
11 years ago
8f74f262fd
Minor cleanup.
11 years ago
8a7461c3dc
More metrics groundwork.
11 years ago
3647ec7fe4
Revert "Speculative fix for cross-thread visibility issue."
...
This reverts commit 5a1e22b711
11 years ago
cf8bb4ff8d
Merge branch 'dev' of github.com:brettwooldridge/HikariCP into dev
...
# By Brett Wooldridge (3) and Guillaume Smet (3)
* 'dev' of github.com:brettwooldridge/HikariCP:
More clean-up/tighten-up of code.
More clean-up/tighten-up of code.
Fix typo: s/&/&&/.
Use entrySet() instead of keySet().
Make leakTrace local as there is no need to make it an attribute.
Use some static imports.
11 years ago
5a1e22b711
Speculative fix for cross-thread visibility issue.
11 years ago
275aeeb19c
More clean-up/tighten-up of code.
11 years ago
bebe95b504
More clean-up/tighten-up of code.
11 years ago
4e26f3e202
Fix typo: s/&/&&/.
11 years ago
34d5f74e0f
Use entrySet() instead of keySet().
11 years ago
b2b07885d8
Make leakTrace local as there is no need to make it an attribute.
11 years ago
6c664407dd
Use some static imports.
11 years ago
cc12165b44
Fix #78 add ability to set an IConnectionCustomizer instance directly on the HikariConfig/HikariDataSource.
11 years ago
0fa08d0011
Minor code cleanup.
11 years ago
262cf1ff92
Log connection pool properties at debug level after validation.
11 years ago
862e06aab5
Add startup/shutdown log.
11 years ago
8cfb7809dc
Use the generic FastList in more places, fix some JavaDoc warnings from Java 8.
11 years ago
59b0ab7197
Make FastStatementList generic -> FastList
11 years ago
02f23eb90e
Performance tweaks to FastStatementList and additional unit tests.
11 years ago
20db89b0df
Remove unused assignment.
11 years ago
c88a1d67e1
Fix all unit tests to cleanly shutdown the pool when they finish.
11 years ago
227cbffc11
minor formatting.
11 years ago
407478e615
Fix javadoc warning.
11 years ago
6c69ce13d7
Made test less timing critical for automated tests (on travis ci).
11 years ago
a89f52c1de
Fix #76 avoid possible thread leak on shutdown
11 years ago
ed7234793b
Minor cleanup.
11 years ago
3118156f22
Use elapsedTime() method.
11 years ago
88473ad07c
Whitespace correction.
11 years ago
719da54897
Minor cleanup.
11 years ago
96a30c2b7d
Fix #76 add more extensive shutdown() code to attempt to close() or abort() all connections in the pool.
11 years ago
f4e28160ce
Performance enhancements.
11 years ago
b5161499b8
Performance optimizations.
11 years ago
11497125f2
Fix #74 add pool name to housekeeping timer thread
11 years ago
81d466bb90
Make some fields final.
11 years ago
2ad5aa680d
Add additional warning.
11 years ago
f0ebabb92e
Remove compile warning about unused import by fully qualifying the class in the JavaDoc instead.
11 years ago
301d5f78a2
Fix #68 correct JavaDoc for HikariConfig.getConnectionTimeout()/setConnectionTimeout().
11 years ago
f0197a6230
Attempt to fix spurious test failures due to timing sensitivities.
11 years ago
22f783067f
Fixed #67 mbean UN-registration
11 years ago
64ca5eefb6
Fixed #66 mbean registration
11 years ago
5d3761ebc7
Remove redundant assignment.
11 years ago
a83c4ab263
Eliminate double-execution of shutdown code.
11 years ago
02de16b42d
Fix typo bug in JNDI factory class ... reflect properties from HikariConfig instead of HikariPool.
11 years ago
77a95bf454
Add a test for PropertyBeanSetter.getPropertyNames().
11 years ago
9a446d62fb
Add a JNDI factory to create datasources for Tomcat users.
11 years ago
cfda5e022c
This fixes #65 as well as correcting OSGi manifest generation warnings by reorganizing the code and packages somewhat to ensure that the publicly exported com.zaxxer.hikari package does not expose any internal classes.
11 years ago
62297a0c88
Merge branch 'dev' of https://github.com/brettwooldridge/HikariCP into dev
...
* 'dev' of https://github.com/brettwooldridge/HikariCP :
Fix issue #63 improper setting of null state during connection failure.
11 years ago
7cd733f901
Fix isConnectionAlive() check when using Connection.isValid(). Clarify logging.
11 years ago
fde0451007
Fix issue #63 improper setting of null state during connection failure.
11 years ago
5e6a026181
Remove chatty logging of connection failures, include "last" connection failure in SQL timeout exception.
11 years ago
ef77b881bc
Remove chatty logging of connection failures, include "last" connection failure in SQL timeout exception.
11 years ago
8ae518e94d
Merge branch 'dev' of github.com-brettwooldridge:brettwooldridge/HikariCP into dev
...
# By Brett Wooldridge (8) and Jared Stehler (2)
# Via Brett Wooldridge (3) and Jared Stehler (2)
* 'dev' of github.com-brettwooldridge:brettwooldridge/HikariCP:
merged
log pool name in warn messages
Update README.md
Update README.md
[maven-release-plugin] prepare for next development iteration
[maven-release-plugin] prepare release HikariCP-1.3.5
Typo
Update README.md
Update README.md
Update README.md
11 years ago
afeba45fb3
Break if we're failing to create connections and there is nobody waiting anymore.
11 years ago
9676c92914
merged
11 years ago
dcba97c3cd
log pool name in warn messages
11 years ago
411792da13
Do not set query timeout when user specifies connectionTimeout of 0.
11 years ago
430c6a4d56
Do not set query timeout when user specifies connectionTimeout of 0.
11 years ago
5e6da1254b
Small tweak to try to fix Javassist/Java8 incompatibility.
11 years ago
43a3663ec3
Fix Java8 JavaDoc errors.
11 years ago
b626016544
Restore max lifetime check to getConnection() rather than only in the
...
housekeeper thread. An extremely active pool may never find an idle
connection in the housekeeper alone.
11 years ago
f059d39aa6
Restore max lifetime check to getConnection() rather than only in the
...
housekeeper thread. An extremely active pool may never find an idle
connection in the housekeeper alone.
11 years ago
cf2f0b0be4
Fixed #51 fix logging string substitution parameter.
11 years ago
8430fce40d
Switch back to setting our own context class loader during code generation.
11 years ago
398acad77a
Change visibility.
11 years ago
b699cbf6e7
Unwrap DataSource test.
11 years ago
37e26d4092
Discourage users from turning on metrics until they do something useful.
11 years ago
a10c5e5b17
Add idle fill test.
11 years ago
d7f7c111ce
Reduce the number of filler threads ... 8 threads is too many on a hyper threaded 4-core CPU.
11 years ago
eeec5415c6
Start implementing [optional] metrics for HikariCP.
11 years ago
4b0cca092c
Additional connection tests.
11 years ago
bffb8b93f6
Merged #48 fix connectionTest validation
11 years ago
84d82b292f
Change defaults.
11 years ago
49a0187b41
Default minIdle the same as maxPoolSize.
11 years ago
16dfabbc9e
Split out stateless utility functions to reduce the weight of the HikariPool class (increases readability).
11 years ago
564a65372f
Rename idleConnectionBag to connectionBag.
11 years ago
eda6aaddac
Change connectionTimeout minimum to 250ms.
11 years ago
9ff609b64b
Fix timing edge case in test.
11 years ago
5ba531c3d4
Check validation error
11 years ago
0abb916c7c
Improve warnings for invalid configuration
11 years ago
e1563e46d6
Use the DriverManager to create connections.
11 years ago
0ccd39f95f
Remove deprecated calls from tests, fix test conditions for new background fill behavior.
11 years ago
8daf9d3005
Implement new background adding of connections to maintain a "minimumIdle" level.
11 years ago
efa2fcc440
Restore former barrow() logic, add getCount() and size)() methods.
11 years ago
bf2872af53
Add eviction method.
11 years ago
a32ec77dc9
Remove acquireRetries and acquireRetryDelay
11 years ago
f2c87b915e
Add a exception log for JavassistProxyFactory static initiaiization.
11 years ago
91e4729b88
Revert "Use our cascading ClassLoader."
...
This reverts commit 183d036173
11 years ago
183d036173
Use our cascading ClassLoader.
11 years ago
d8dbad1ed9
Pull additional hibernate properties over.
11 years ago
0d095fb494
Remove context class loader.
11 years ago
adeae97f3a
Fix NPE.
11 years ago
8ec2953efd
Add username and password properties as well as cleanup validation (not complete).
11 years ago
783bb5ae29
Handle username and password settings, treat the DriverDataSource like other datasources.
11 years ago
14d72a2b29
Handle username and password settings.
11 years ago
e43864f626
Pickup additional parameters from Hibernate.
11 years ago
2dd9c08a3f
Use an object-based key for the multi pool
11 years ago
c4469ce58c
Add support for DataSource.getConnection(username, password).
11 years ago
14a2891ef5
Move configuration validation into the HikariDataSource.
11 years ago
3a2985541e
Fix unit tests to calculate proper times per retry.
11 years ago
3d2300adcf
Fix connectionTimeout calculation.
11 years ago
3c20da2751
DataSource.setLoginTimeout() is in seconds. Make sure the milliseconds passed in to addConnection(timeout) is converted to seconds. Also add a validation to prevent sub-second retries that would be converted to 0 when performing a millisecond to second conversion using TimeUnit.
11 years ago
27cd322fba
Closes#45 if the PropertyBeanSetter fails to find the setter method via "set" + first property character capitalized, try "set" + property fully capitalized. This handles cases where "url" is used as a property but the setter is setURL() rather than setUrl().
11 years ago
b46e484bad
Tighten-up code.
11 years ago
c8c63e8c85
Tighten-up code.
11 years ago
fb69033eb5
Fix tests to use fail fast initialization
11 years ago
ecf531d7f3
Minor code reorganization.
11 years ago
99b2b765ce
closes #44 potential connection leak during connection creation in some failure scenarios.
11 years ago
079bf9e8c2
Fix assertion.
11 years ago
bcfcf71721
Don't log every failed connection attempt, it could flood the log during a
...
database restart on a busy server. Log at most 1 per second. Always
log when debug is enabled.
11 years ago
37c4d20099
Mark useInstrumentation deprecated and log warning.
11 years ago
53558b64d1
Add back java7/8 fairness optimization without breaking Java 6.
11 years ago
41d7750133
Fix connection timeout/retry handling and add tests.
11 years ago
5e1b7be484
Implement unwrap()
11 years ago
4a410d8593
Remove acquireIncrement from tests.
11 years ago
8f280e4d0c
Fix calculation error that would not allow loginTimeout to go to zero.
11 years ago
5adebc96ea
Tighten-up code.
11 years ago
bcab411f4e
Restore shutdown check ... but in a slightly different spot
11 years ago
b7284da738
Remove redundant shutdown check (handled properly by the pool), and unnecessary assignment to null in the case where pool is already null.
11 years ago
04005cf619
fix #43 add null check to shutdown
11 years ago
4dea4c8d41
Add calculated effective acquisition time and inter-attempt delay.
11 years ago
3869ed0edb
Remove unused acquireIncrement
11 years ago
ccd4ddd3ee
Merge branch 'openwide-java-add-override-annotations-where-needed-dev' into dev. However, some of the methods marked @Override are in fact not present in Java6 and so produce errors in the IDE and were therefore removed.
11 years ago
1bca94af9e
Merge branch 'master' into dev
11 years ago
d415ba8353
Add @Override annotation where needed.
...
Starting with Java 6, we can annotate with @Override a class method implementing
a method from an interface.
11 years ago
b4510a50c0
Retire acquireIncrement and acquireRetryDelay properties.
11 years ago
362be9d29d
Javadoc and annotations.
11 years ago
3295443e9b
Clean-up and tighten-up of code.
11 years ago
d8bc281902
Fix incorrect incrementation of totalConnections when there is a retry. It should only be incremented on the first time through the loop.
11 years ago
2112a3470e
Fix typo.
11 years ago
87868ca67b
Update copyright.
11 years ago
c2405e0423
Avoid unnecessary initialization of local variable.
11 years ago
d8126eca81
Add support for DriverManager and JDBC URL-based pool configuration.
11 years ago
af6a7dd430
Add support for DriverManager and JDBC URL-based pool configuration.
11 years ago
6637690f0d
Add to property to control whether internal pool queries are isolated in their own
...
transactions or not.
11 years ago
f1d8d9cfc5
Only set the readOnly() flag at initial construction if it is set to `true` by default.
11 years ago
5765ed2116
Javadoc
11 years ago
6149affd88
Support setting a default readOnly state for connections.
11 years ago
582c7a5e5a
Simplify the modifyProxyFactory() method.
11 years ago
cea6ed453f
Fix broken unit test
11 years ago
80d80e266f
Simplify the setTransactionIsolation() method, perform the check in validate()
11 years ago
62c7bd2a93
Minor cleanup.
11 years ago
4c1bbf4d36
Minor cleanup.
11 years ago
eab48c3a7c
Add ramp-up/ramp-down test.
11 years ago
5e0f13dcd9
Log pool state (debug) at shutdown.
11 years ago
f1e711892b
Cleanup to prevent acquisition overruns.
11 years ago
9cc1eb9dc9
Cleanup to prevent acquisition overruns.
11 years ago
111fbc3b73
Fix max connection overrunning when saturated with getConnection() calls during benchmarking.
11 years ago
d80d793457
ConcurrentBag optimizations.
11 years ago
23fcf89be4
More unit tests
11 years ago
b82dec08b7
Use WeakReferences to avoid Tomcat ThreadLocal leak warning.
11 years ago
d79198e23b
Set/reset connection state at creation time and upon closing connections.
11 years ago
a4b9769de9
Revert "Prevent connections from one pool from bleeding over to threads requesting connections from another pool (stored in ThreadLocal)."
...
This reverts commit 78e1569264
11 years ago
78e1569264
Prevent connections from one pool from bleeding over to threads requesting connections from another pool (stored in ThreadLocal).
11 years ago
8e46211806
Copy state from config.
11 years ago
6865443ddf
Make HikariDataSource inherit from HikariConfig for convenience. This is useful
...
for Spring configuration, for example, because properties can be set directly on
the datasource rather than constructing a separate object.
11 years ago
2bc5b57575
Add catalog to the hikari configuration and into the connection state reset code
11 years ago
aea65f9ccb
Delete performance benchmarks, they are now hosted as a separate github repository.
11 years ago
a447e52fe8
Delete performance benchmarks, they are now hosted as a separate github repository.
11 years ago
63bcfe2cf0
Removed method not available in Java 6.
11 years ago
c6d40199c5
Java 6 compatibility.
11 years ago
07d630de5a
#39 Get rid of anonymous inner class in ThreadLocal as it might possibly trigger a warning in Tomcat.
11 years ago
83b88f675e
Fix backfill test to match new pool behavior.
11 years ago
0aa7bc5a11
Pass default auto commit state into constructor.
11 years ago
ebf68a7176
Remove unused methods from signature
11 years ago
008ea8af45
Remove auto commit reset in alive test (it is done in ConnectionProxy.close() now), change idle connection tracking so as to eliminate the need for counting awaiting threads.
11 years ago
6fdc137566
Make methods final, and reset auto commit in close()
11 years ago
b634085633
Make methods final.
11 years ago
d4e15d097e
Move some connection state reset logic into ConnectionProxy.close() to avoid additional method invocation overhead.
11 years ago
947e787a15
Rollback auto commit optimization, it performed worse.
11 years ago
32eadc1d8c
Improved FastStatementList
11 years ago
9848138faa
Remove blank line
11 years ago
106d5cc27c
Performance tweaks
11 years ago
de4059c0cb
Add close() method that is synonymous with shutdown(), add toString() that prints the datasource including the pool name.
11 years ago
5fc58a2306
Add another exception test
11 years ago
fa26ccc719
Avoid error message on shutdown when MBeans are not registered.
11 years ago
8fd836e657
#37 add sybase exceptions
11 years ago
b81c24d43c
Javadoc, renaming, and cleanup.
11 years ago
ef82b6bf35
Fix FastStatementList unit test failure.
11 years ago
6a8681bc70
Slightly cleaner fix for issue #35
11 years ago
142ae39059
javadoc.
11 years ago
07bc7b8916
Change default size from 16 to 32, and change growth factor from 4x to 2x.
11 years ago
ff12869d4f
Add a pool state log at timeout failure.
11 years ago
9f5ad18f20
Synchronization fixes.
11 years ago
5419073cea
Minor cleanup and javadoc.
11 years ago
86c45dbf24
Refactored SpecializedConcurrentBag for efficiency, moved to util.
11 years ago
3c60b60257
Initialize the concurrent bag with an initial size.
11 years ago
51336d7c74
Cache the hashCode.
11 years ago
372f15f46e
Merged changed from fwbrasil
11 years ago
b2641afe7e
Add license header and class-level javadoc.
11 years ago
ce2d5a3141
Even more detailed log for broken connections
11 years ago
522717f885
New concurrent connection container (moved away from LinkedBlockingQueue and LinkedTransferQueue).
11 years ago
de20a9e71c
Merge commit '4bf148f6d07efb03acc495ff52f1fea9dca649e1' into dev
...
* commit '4bf148f6d07efb03acc495ff52f1fea9dca649e1':
fix fast statement list overflow inconsistency
Update README.md
Update README.md
11 years ago
4bf148f6d0
fix fast statement list overflow inconsistency
11 years ago
e3a3a1ab3d
Start of experimental implementation of a concurrent bag.
...
See http://geekswithblogs.net/simonc/archive/2012/03/26/inside-the-concurrent-collections-concurrentbag.aspx
11 years ago
d403b01afa
Readability improvement.
11 years ago
867fc03003
Added logging for broken connections.
11 years ago
e39fc44ad9
Add log when pool is shutdown.
11 years ago
ca526c2e87
Remove pool size.
11 years ago
c9f4598e53
Add debug log message for connections returned to the pool broken.
11 years ago
2ecedd92ed
Added configuration flags for fail-fast initialization and MBean registration.
11 years ago
555075adec
Minor performance tweak.
11 years ago
0dada599f4
Try LinkedBlockingQueue.
11 years ago
aeb8c91917
Changes to prevent over aggressive optimization by the JIT which was producing
...
incorrect benchmarking results.
11 years ago
e0c216a4c0
Fix unit test failures.
11 years ago
2053fdc973
Remove unnecessary optimisation that the JIT will perform anyway.
11 years ago
cffe33706a
Remove unused import.
11 years ago
1ba9987902
Remove resultset wrapper
11 years ago
2fd99e655d
Log exception message when a connection failure occurs
11 years ago
65010d9487
Unregister MBeans on pool shutdown
11 years ago
f3c0feb15c
Fixed #29 implement clean shutdown
11 years ago
b566002c0e
Fixed bug growing the size of the FastStatementList when the capacity is exceeded.
11 years ago
058b7f0e0e
Rename methods, and cleanup.
11 years ago
95d3fbdf0b
Add short-circuit to aliveness check if connection was used within the last second.
11 years ago
d4caabaa13
More testy stuff.
11 years ago
d417886365
Fixed iteration direction bug, forgot we were iterating backwards.
11 years ago
069713c94f
Use execute() instead of executeQuery() for initSql.
11 years ago
9021e7178d
Fix isolation level dirty detection logic.
11 years ago
eda62f7442
Correct property name.
11 years ago
94aa31510f
Add the ability for the user to customize Connections before they are added to the pool.
11 years ago
a752582368
Implement proper connection unwrapping.
11 years ago
56e97a8e3c
No need to wrap methods that do not throw SQLException with our own try…catch checkException() logic.
11 years ago
b388227dc4
Added query timeout to test query.
11 years ago
128b169f99
Remove unnecessary casts in the generated proxies.
11 years ago
352a269ad8
Replace bound check with try..catch it is faster in the nominal case.
11 years ago
8b440dd79c
Track current transaction isolation level so that we can reset it only when necessary (as it often requires a round trip to the server).
11 years ago
430dd730e7
Demote error log to warn.
11 years ago
395035b5f5
Conditionally reset the transaction isolation level based on whether the user has altered it or not. Turns out it is expensive for some databases.
11 years ago
c6b8d488a4
Conditionally reset the transaction isolation level based on whether the user has altered it or not. Turns out it is expensive for some databases.
11 years ago
04aa65a6d8
Replace ConnectionProxy’s ArrayList<Statement> with a custom class (FastStatementList), replace the singleton generated JavassistProxyFactory with a class that has static methods (so we get invokestatic rather than invokeinterface) in bytecode.
11 years ago
4a6eb29043
Use our own list implementation which does not do bounds checking, among other optimizations.
11 years ago
a754c87c8a
Micro optimization, avoids unnecessary assignment.
11 years ago
93fd7d7330
Fixed #27 set the isClosed flag earlier in the close() method, it was meant to short-circuit the unregisterStatement() call, but was moved later, which broke that behavior.
11 years ago
7235091496
Comment #25 added additional warning if both dataSource and dataSourceClassName are specified.
11 years ago
3861c17b40
Increate timing window to avoid time-sensitive failures in unit tests on slow machines (travis-ci)
11 years ago
1ed2153ab1
Increate timing window to avoid time-sensitive failures in unit tests on slow machines.
11 years ago
ccc2989c72
Remove unused import.
11 years ago
970e3a5092
Increate timing window to avoid time-sensitive failures in unit tests on slow machines.
11 years ago
e35c939ed2
Allow setting the dataSource directly on the HikariConfig.
11 years ago
137c76e589
Restructured pom after removal of instrumentation.
11 years ago
add7af4915
Split HikariCP into two modules: core and agent.
11 years ago
b5101d5e18
Start of rework of instrumentation to support shading.
11 years ago
a326b66457
Set Thread context class loader, fixes issue with Bukkit plugin class loader (and probably other application server class loaders).
11 years ago
9e74d4c7a3
Try to use our own classloader (the one that loaded the proxy factory itself) in the class pool.
11 years ago
292aee2efb
Compose the package and class names to support jar shading.
11 years ago
e88cfcddfe
documentation and code simplification.
11 years ago
d6d2bc8eac
JavaDoc
11 years ago
89a475af14
documentation and dead code removal
11 years ago
84c1474e4d
JavaDoc
11 years ago
fbb3e88788
Improve statement tracking.
11 years ago
7e17dc3d9e
Added HSQLDB to instrumentation codex.
11 years ago
33093708e0
Derby net client added to codex. Also commented out Java 8 classes until we
...
figure out how to annotate the codex for java version-specifics.
11 years ago
e1abe3bbf7
Set instrumentation flag in benchmark … mostly just so it’s easy to set and unset during testing.
11 years ago
7c8d8d071e
Make sure to wrap/inject all ResultSets and set the parent _statement otherwise we get an
...
NPE in _checkException() which needs to bubble-up to the Statement level.
11 years ago
7d066aa63e
Add missing ResultSet classes to codex for PostgreSQL.
11 years ago
e12d84ed82
Use flag to avoid recursive close() calls (encountered in MariaDB).
11 years ago
e621a55d4a
Don’t add try..catch to static methods
11 years ago
51fce05ffc
Add MariaDB to codex.
11 years ago
66a6e8052f
Simplify classes by creating an inheritance hierarchy of the JDBC classes.
11 years ago
dea09c0654
Add option to disable instrumentation.
11 years ago
cc9ce4f874
Additional JDBC drivers added to codex.
11 years ago
560f6d4fd0
Merge branch 'dev' of https://github.com/Brizth/HikariCP into Brizth-dev
11 years ago
83fcef54f9
Reenable
11 years ago
39f74267ac
Mildly more realistic stubs.
11 years ago
60601d4b61
Reduce casting and unnecessary delegation.
11 years ago
28cbc5048f
More work on codex based instrumentation.
11 years ago
63d67dfa19
Fixed an invalid timeout in java.sql.Connection.isValid call
11 years ago
28993fd439
Change to instrumentation classes specified in a codex file. Trying to deduce which
...
classes to instrument via reflection is futile given the bizarre class hierarchies of some
drivers.
11 years ago
8b651d8b78
Refactor experiment.
11 years ago
2bf2269606
Start development on new instrumentation.
11 years ago
81e4e8ffb3
Temporarily disable test.
11 years ago
b905393bb7
Handle inheritance hierarchies better.
11 years ago
315d09d62f
More tests
11 years ago
a2485dfa26
Add more connection pools for testing.
11 years ago
831c1b8f5d
command line parameters.
11 years ago
5e4cf64909
Change checkClosed() method from private to protected for access by Javassist proxies.
11 years ago
2db908d177
Remove unused class.
11 years ago
7560ee2308
Remove unnecessary delegation.
11 years ago
fc08920d6f
Add checkClosed() call to generated Connection proxy methods.
11 years ago
a70c02b2f4
More JIT warmup.
11 years ago
5326e543e7
Correctness
11 years ago
abadd6723a
Fixup null check
12 years ago
8fcbc29ce9
Remove experimental code.
12 years ago
615a74aace
change variable name for clarity
12 years ago
524cea67a0
remove inheritance
12 years ago
a1871abb14
make final
12 years ago
f0f1f1409e
Change factory/constructor signature
12 years ago
52dec2f2f5
Method shrinkage to try to get below inline threshold.
12 years ago
a2eee447b2
More performance tweaks.
12 years ago
69a6ff2fb5
Inject try catch
12 years ago
7233f21a1c
Remove connection url, it is a DataSource property
12 years ago
d20695c2da
Minor tweaks
12 years ago
53376d601e
Eliminate some unneeded casts.
12 years ago
c69e18265e
Fix datasource path after package change.
12 years ago
1f013c3f09
Refactor to allow injection of proxy code into JDBC classes from the user's driver.
12 years ago
0b58689069
Package refactor.
12 years ago
99a3416bd3
Temporarily disable instrumentation during development.
12 years ago
1f5ab6c149
Fleshing out the instrumentation agent.
12 years ago
8a3643d634
More work on class transformer
12 years ago
640321b9ac
Use stub data sour e
12 years ago
648bef1bbe
Moved stubs to mock package
12 years ago
cf1f1286b0
Class transformer
12 years ago
76c9f95573
Remove unused import
12 years ago
c2e939f345
Add a benchmark using hsqldb
12 years ago
805e65b969
Streamline inheritance and proxy generation.
12 years ago
a6b27ef2a3
Add auto commit setting, and population of driver properties.
12 years ago
9ddc7dbc16
Add test
12 years ago
4abc12452b
Rename benchmark
12 years ago
76ca46a90f
Fixed javadoc
12 years ago
cd66ddf269
Fix pool fill error when acquire increment is greater than min pool size.
12 years ago
6e72f1e426
Detect broken connection via SQLException
12 years ago
87f8b663a6
Code comments
12 years ago
ece25c4c83
Code comments
12 years ago
93e88d758b
more proxy cleanup
12 years ago
494ea84b86
Move to ClassLoaderUtils to new package
12 years ago
47b3556c4f
Move to ClassLoaderUtils to new package
12 years ago
6855b82c8a
Move to new package
12 years ago
c22d680224
Remove unused code from proxies since cglib and java.lang.Proxy support was removed.
12 years ago
328017bb43
Repackaging
12 years ago
c967f3778d
API renames.
12 years ago
0fecb47354
Fix idle timeout bug.
12 years ago
8b0911baab
Add MBean support.
12 years ago
169bba9a58
Set the minimum pool size to the max / 2
12 years ago
cd2c769303
Remove java proxy factory ... only support javassist.
12 years ago
2eb52b06b0
Switch from add() method to put() method.
12 years ago
96578be6fd
Remove cglib
12 years ago
c965656643
Switch from HashSet to ArrayList for tracking statements.
12 years ago
1ab5c8fde7
Uncomment benchmarks.
12 years ago
7f76e3b833
Clear the tracking statements before we do anything that might throw an exception.
12 years ago
72d3d38af6
Add code to trap SQLExceptions and call a checkException() method.
12 years ago
03a44b7ab5
During getConnection() only try to fill the pool when it is empty.
12 years ago
4dd5d75bac
Default jdbc4 isValid() connection validation method to true.
12 years ago
f50c652329
Delete unused class.
12 years ago
3c264938c6
Use nanoTime() it is more accurate on some platforms.
12 years ago
b81c8ba8bc
Start of work to allow loading from a Properties file.
12 years ago
92bea1ddaa
Add idle time-out handling, max lifetime handling, and connection leak detection.
12 years ago
04199ba9f4
Fixed the average execution time calculation.
12 years ago
6a46daa7c9
Change named of some getter/setters
12 years ago
403ca5f916
Add one more warm up run.
12 years ago
7b123e7e52
Enhance benchmark
12 years ago
65c27de32d
Restore wrapped ResultSets
12 years ago
a3196b1a03
Benchmark and tuning.
12 years ago
47268a5213
Benchmark and tuning.
12 years ago
95905042b5
Start of a benchmark
12 years ago
21fe1b4439
Fix up the mock datasource
12 years ago
44f986a972
Fix statement tracking
12 years ago
052446ca53
Use Thread.currentThread().getStackTrace() instead of creating a Throwable.
12 years ago
fdbdc025a0
initial commit
12 years ago
Brett Wooldridge
Mikhail Mazurskiy
Guillaume Smet
Johannes Herr
Jared Stehler
Flavio W. Brasil
Sebastian Jaenicke
Antti Lampinen