Cleaner handling of resetting autoCommit and setTransactionIsolation.

pull/22/merge
Brett Wooldridge 11 years ago
parent b6237b6b51
commit 7852524e66

@ -154,7 +154,6 @@ public final class HikariPool implements HikariPoolMBean
connectionProxy.captureStack(leakDetectionThreshold, houseKeepingTimer); connectionProxy.captureStack(leakDetectionThreshold, houseKeepingTimer);
} }
connection.setAutoCommit(isAutoCommit);
connection.setTransactionIsolation(transactionIsolation); connection.setTransactionIsolation(transactionIsolation);
connection.clearWarnings(); connection.clearWarnings();
@ -340,15 +339,11 @@ public final class HikariPool implements HikariPoolMBean
String initSql = configuration.getConnectionInitSql(); String initSql = configuration.getConnectionInitSql();
if (initSql != null && initSql.length() > 0) if (initSql != null && initSql.length() > 0)
{ {
Statement statement = connection.createStatement(); connection.setAutoCommit(true);
try try (Statement statement = connection.createStatement())
{ {
statement.executeQuery(initSql); statement.executeQuery(initSql);
} }
finally
{
statement.close();
}
} }
idleConnectionCount.incrementAndGet(); idleConnectionCount.incrementAndGet();
@ -392,6 +387,9 @@ public final class HikariPool implements HikariPoolMBean
try try
{ {
connection.setAutoCommit(true);
connection.setTransactionIsolation(transactionIsolation);
if (jdbc4ConnectionTest) if (jdbc4ConnectionTest)
{ {
return connection.isValid((int) TimeUnit.MILLISECONDS.toSeconds(timeoutMs)); return connection.isValid((int) TimeUnit.MILLISECONDS.toSeconds(timeoutMs));
@ -401,6 +399,10 @@ public final class HikariPool implements HikariPoolMBean
{ {
statement.executeQuery(configuration.getConnectionTestQuery()); statement.executeQuery(configuration.getConnectionTestQuery());
} }
finally
{
}
return true; return true;
} }
@ -415,7 +417,7 @@ public final class HikariPool implements HikariPoolMBean
{ {
try try
{ {
connection.commit(); connection.setAutoCommit(false);
} }
catch (SQLException e) catch (SQLException e)
{ {

Loading…
Cancel
Save