CHANGES log and cleanup.

pull/698/head
Brett Wooldridge 9 years ago
parent 97057a1696
commit 6edaa336a6

@ -1,5 +1,18 @@
HikariCP Changes
Changes in 2.4.8
* Added Connection.commit() call to the fail-fast initialization for databases that
automatically start a new Connection in a transaction and throw an exception on close
if it is not committed.
* feature 694: report if a previously reported leaked connection is returned to the pool
* issue 689: log a warning if default transaction isolation level cannot be detected.
This can occur with pseudo-database drivers such as the one for JSonar
* issue 674: fix regression caused by pull request #450 (overzealous optimisation)
Changes in 2.4.7
* Miscellaneous stability improvements.

@ -157,34 +157,6 @@ public class TestConnectionTimeoutRetry
}
}
@Test @org.junit.Ignore
public void testConnectionRetries4() throws SQLException
{
HikariConfig config = new HikariConfig();
config.setMinimumIdle(0);
config.setMaximumPoolSize(1);
config.setConnectionTimeout(1000);
config.setValidationTimeout(1000);
config.setConnectionTestQuery("VALUES 1");
config.setDataSourceClassName("com.zaxxer.hikari.mocks.StubDataSource");
try (HikariDataSource ds = new HikariDataSource(config)) {
StubDataSource stubDataSource = ds.unwrap(StubDataSource.class);
stubDataSource.setThrowException(new SQLException("Connection refused"));
long start = ClockSource.INSTANCE.currentTime();
try {
Connection connection = ds.getConnection();
connection.close();
Assert.fail("Should not have been able to get a connection.");
}
catch (SQLException e) {
long elapsed = ClockSource.INSTANCE.elapsedMillis(start);
Assert.assertTrue("Didn't wait long enough for timeout", (elapsed >= config.getConnectionTimeout()));
}
}
}
@Test
public void testConnectionRetries5() throws SQLException
{

Loading…
Cancel
Save