From e4ab6e27e4fd127d1feeea862a7ff10eb91c2ae7 Mon Sep 17 00:00:00 2001
From: Sutra Zhou <zhoushuqun@gmail.com>
Date: Sun, 3 Mar 2024 18:35:25 +0800
Subject: [PATCH] Optimize Request#extras, refs #1148.

---
 .../us/codecraft/webmagic/scheduler/RedisPriorityScheduler.java | 2 +-
 .../java/us/codecraft/webmagic/scheduler/RedisScheduler.java    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/webmagic-extension/src/main/java/us/codecraft/webmagic/scheduler/RedisPriorityScheduler.java b/webmagic-extension/src/main/java/us/codecraft/webmagic/scheduler/RedisPriorityScheduler.java
index 46d47e5a..7abe5bfa 100644
--- a/webmagic-extension/src/main/java/us/codecraft/webmagic/scheduler/RedisPriorityScheduler.java
+++ b/webmagic-extension/src/main/java/us/codecraft/webmagic/scheduler/RedisPriorityScheduler.java
@@ -102,7 +102,7 @@ public class RedisPriorityScheduler extends RedisScheduler {
     }
 
     private void setExtrasInItem(Jedis jedis,Request request, Task task) {
-        if (request.getExtras() != null) {
+        if (!request.getExtras().isEmpty()) {
             String field = DigestUtils.sha1Hex(request.getUrl());
             String value = JSON.toJSONString(request);
             jedis.hset(getItemKey(task), field, value);
diff --git a/webmagic-extension/src/main/java/us/codecraft/webmagic/scheduler/RedisScheduler.java b/webmagic-extension/src/main/java/us/codecraft/webmagic/scheduler/RedisScheduler.java
index 19e83132..8d61bea3 100644
--- a/webmagic-extension/src/main/java/us/codecraft/webmagic/scheduler/RedisScheduler.java
+++ b/webmagic-extension/src/main/java/us/codecraft/webmagic/scheduler/RedisScheduler.java
@@ -84,7 +84,7 @@ public class RedisScheduler extends DuplicateRemovedScheduler implements Monitor
             return true;
         }
 
-        if (request.getExtras() != null && !request.getExtras().isEmpty()) {
+        if (!request.getExtras().isEmpty()) {
             return true;
         }
         if (request.getPriority() != 0L) {