From 969ad1766b51d9e7ad63a3862de3fde8e159a0d4 Mon Sep 17 00:00:00 2001
From: "yihua.huang" <code4crafter@gmail.com>
Date: Sun, 6 Apr 2014 21:32:20 +0800
Subject: [PATCH] change logger style to slf4j for cleaner code

---
 .../codecraft/webmagic/downloader/HttpClientDownloader.java   | 2 +-
 .../java/us/codecraft/webmagic/model/PageModelExtractor.java  | 4 +---
 .../codecraft/webmagic/scheduler/FileCacheQueueScheduler.java | 4 +---
 3 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/webmagic-core/src/main/java/us/codecraft/webmagic/downloader/HttpClientDownloader.java b/webmagic-core/src/main/java/us/codecraft/webmagic/downloader/HttpClientDownloader.java
index bcf4a53b..30c561b5 100644
--- a/webmagic-core/src/main/java/us/codecraft/webmagic/downloader/HttpClientDownloader.java
+++ b/webmagic-core/src/main/java/us/codecraft/webmagic/downloader/HttpClientDownloader.java
@@ -74,7 +74,7 @@ public class HttpClientDownloader extends AbstractDownloader {
         } else {
             acceptStatCode = Sets.newHashSet(200);
         }
-        logger.info("downloading page " + request.getUrl());
+        logger.info("downloading page {}" , request.getUrl());
         RequestBuilder requestBuilder = RequestBuilder.get().setUri(request.getUrl());
         if (headers != null) {
             for (Map.Entry<String, String> headerEntry : headers.entrySet()) {
diff --git a/webmagic-extension/src/main/java/us/codecraft/webmagic/model/PageModelExtractor.java b/webmagic-extension/src/main/java/us/codecraft/webmagic/model/PageModelExtractor.java
index 5e4da114..b7b7900a 100644
--- a/webmagic-extension/src/main/java/us/codecraft/webmagic/model/PageModelExtractor.java
+++ b/webmagic-extension/src/main/java/us/codecraft/webmagic/model/PageModelExtractor.java
@@ -340,9 +340,7 @@ class PageModelExtractor {
     private Object convert(String value, ObjectFormatter objectFormatter) {
         try {
             Object format = objectFormatter.format(value);
-            if (logger.isDebugEnabled()) {
-                logger.debug("String " + value + " is converted to " + format);
-            }
+            logger.debug("String {} is converted to {}", value, format);
             return format;
         } catch (Exception e) {
             logger.error("convert " + value + " to " + objectFormatter.clazz() + " error!", e);
diff --git a/webmagic-extension/src/main/java/us/codecraft/webmagic/scheduler/FileCacheQueueScheduler.java b/webmagic-extension/src/main/java/us/codecraft/webmagic/scheduler/FileCacheQueueScheduler.java
index 38e8a799..2698f739 100644
--- a/webmagic-extension/src/main/java/us/codecraft/webmagic/scheduler/FileCacheQueueScheduler.java
+++ b/webmagic-extension/src/main/java/us/codecraft/webmagic/scheduler/FileCacheQueueScheduler.java
@@ -149,9 +149,7 @@ public class FileCacheQueueScheduler implements Scheduler {
         if (!inited.get()) {
             init(task);
         }
-        if (logger.isDebugEnabled()) {
-            logger.debug("push to queue " + request.getUrl());
-        }
+        logger.debug("push to queue {}" , request.getUrl());
         if (urls.add(request.getUrl())) {
             queue.add(request);
             fileUrlWriter.println(request.getUrl());