From 622ed5a17f98ee1625222452096741ebe16dfe85 Mon Sep 17 00:00:00 2001 From: Harikrishna Date: Fri, 24 Nov 2023 10:07:04 +0530 Subject: [PATCH] Refactor compareLong method using Long.compare, corrected the local variable name (#1136) --- .../java/us/codecraft/webmagic/utils/NumberUtils.java | 8 +------- .../java/us/codecraft/webmagic/utils/WMCollections.java | 6 +++--- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/webmagic-core/src/main/java/us/codecraft/webmagic/utils/NumberUtils.java b/webmagic-core/src/main/java/us/codecraft/webmagic/utils/NumberUtils.java index 55e18510..fbeb8ed3 100644 --- a/webmagic-core/src/main/java/us/codecraft/webmagic/utils/NumberUtils.java +++ b/webmagic-core/src/main/java/us/codecraft/webmagic/utils/NumberUtils.java @@ -6,12 +6,6 @@ package us.codecraft.webmagic.utils; public abstract class NumberUtils { public static int compareLong(long o1, long o2) { - if (o1 < o2) { - return -1; - } else if (o1 == o2) { - return 0; - } else { - return 1; - } + return Long.compare(o1, o2); } } diff --git a/webmagic-core/src/main/java/us/codecraft/webmagic/utils/WMCollections.java b/webmagic-core/src/main/java/us/codecraft/webmagic/utils/WMCollections.java index 23e1644c..a2ca5afd 100644 --- a/webmagic-core/src/main/java/us/codecraft/webmagic/utils/WMCollections.java +++ b/webmagic-core/src/main/java/us/codecraft/webmagic/utils/WMCollections.java @@ -21,10 +21,10 @@ public class WMCollections { } public static List newArrayList(T... t){ - List set = new ArrayList(t.length); + List list = new ArrayList(t.length); for (T t1 : t) { - set.add(t1); + list.add(t1); } - return set; + return list; } }