From 34da2fb3a02708b562ec747679ef0cd8d171a042 Mon Sep 17 00:00:00 2001
From: Sutra Zhou <zhoushuqun@gmail.com>
Date: Sun, 24 Oct 2021 23:20:38 +0800
Subject: [PATCH] Make PageProcessor#getSite be default method. Closes #1040.

---
 .../webmagic/processor/PageProcessor.java     | 26 +++++++-----
 .../webmagic/processor/PageProcessorTest.java | 40 +++++++++++++++++++
 2 files changed, 56 insertions(+), 10 deletions(-)
 create mode 100644 webmagic-core/src/test/java/us/codecraft/webmagic/processor/PageProcessorTest.java

diff --git a/webmagic-core/src/main/java/us/codecraft/webmagic/processor/PageProcessor.java b/webmagic-core/src/main/java/us/codecraft/webmagic/processor/PageProcessor.java
index 1fb125c7..3d79b96a 100644
--- a/webmagic-core/src/main/java/us/codecraft/webmagic/processor/PageProcessor.java
+++ b/webmagic-core/src/main/java/us/codecraft/webmagic/processor/PageProcessor.java
@@ -4,13 +4,16 @@ import us.codecraft.webmagic.Page;
 import us.codecraft.webmagic.Site;
 
 /**
- * Interface to be implemented to customize a crawler.<br>
- * <br>
+ * Interface to be implemented to customize a crawler.
+ *
+ * <p>
  * In PageProcessor, you can customize:
- * <br>
- * start urls and other settings in {@link Site}<br>
- * how the urls to fetch are detected               <br>
- * how the data are extracted and stored             <br>
+ * </p>
+ * <ul>
+ * <li>start URLs and other settings in {@link Site}</li>
+ * <li>how the URLs to fetch are detected</li>
+ * <li>how the data are extracted and stored</li>
+ * </ul>
  *
  * @author code4crafter@gmail.com <br>
  * @see Site
@@ -20,17 +23,20 @@ import us.codecraft.webmagic.Site;
 public interface PageProcessor {
 
     /**
-     * process the page, extract urls to fetch, extract the data and store
+     * Processes the page, extract URLs to fetch, extract the data and store.
      *
      * @param page page
      */
-    public void process(Page page);
+    void process(Page page);
 
     /**
-     * get the site settings
+     * Returns the site settings.
      *
      * @return site
      * @see Site
      */
-    public Site getSite();
+    default Site getSite() {
+        return Site.me();
+    }
+
 }
diff --git a/webmagic-core/src/test/java/us/codecraft/webmagic/processor/PageProcessorTest.java b/webmagic-core/src/test/java/us/codecraft/webmagic/processor/PageProcessorTest.java
new file mode 100644
index 00000000..ebb1225c
--- /dev/null
+++ b/webmagic-core/src/test/java/us/codecraft/webmagic/processor/PageProcessorTest.java
@@ -0,0 +1,40 @@
+package us.codecraft.webmagic.processor;
+
+import static org.junit.Assert.assertEquals;
+
+import org.junit.Test;
+
+import us.codecraft.webmagic.Page;
+import us.codecraft.webmagic.Site;
+
+public class PageProcessorTest {
+
+    @Test
+    public void testGetSite() {
+        Site actualSite = new PageProcessor() {
+
+            @Override
+            public void process(Page page) {
+            }
+
+        }.getSite();
+
+        assertEquals(Site.me(), actualSite);
+
+        actualSite = new PageProcessor() {
+
+            @Override
+            public void process(Page page) {
+            }
+
+            @Override
+			public Site getSite() {
+                return Site.me().setTimeOut(123);
+            };
+
+        }.getSite();
+
+        assertEquals(Site.me().setTimeOut(123), actualSite);
+    }
+
+}