diff --git a/excalidraw-app/App.tsx b/excalidraw-app/App.tsx index 5fd135226..7d1c13c69 100644 --- a/excalidraw-app/App.tsx +++ b/excalidraw-app/App.tsx @@ -25,6 +25,7 @@ import { TTDDialogTrigger, StoreAction, reconcileElements, + exportToCanvas, } from "../packages/excalidraw"; import { exportToBlob, @@ -133,7 +134,6 @@ import { AIComponents } from "./components/AI"; import { ExcalidrawPlusIframeExport } from "./ExcalidrawPlusIframeExport"; import { fileSave } from "../packages/excalidraw/data/filesystem"; import type { ExportToCanvasConfig } from "../packages/excalidraw/scene/export"; -import { exportToCanvas } from "../packages/utils"; polyfill(); @@ -646,8 +646,6 @@ const ExcalidrawWrapper = () => { (el) => el.strokeStyle === "dashed" && !el.isDeleted, ); - const zoom = appState.zoom.value; - exportToCanvas({ data: { elements: getNonDeletedElements(elements).filter( @@ -1401,7 +1399,7 @@ const ExcalidrawWrapper = () => { maxWH{" "} @@ -1409,7 +1407,7 @@ const ExcalidrawWrapper = () => { ...s, maxWidthOrHeight: !event.target.value.trim() ? undefined - : Math.min(parseInt(event.target.value as any), 600), + : parseInt(event.target.value as any), })) } /> @@ -1440,7 +1438,7 @@ const ExcalidrawWrapper = () => { exportToBlob({ data: { elements: excalidrawAPI!.getSceneElements(), - files: null, + files: excalidrawAPI?.getFiles() || null, }, config, }).then((blob) => { diff --git a/packages/excalidraw/components/ImageExportDialog.tsx b/packages/excalidraw/components/ImageExportDialog.tsx index a1be9044c..0056cef5f 100644 --- a/packages/excalidraw/components/ImageExportDialog.tsx +++ b/packages/excalidraw/components/ImageExportDialog.tsx @@ -23,7 +23,6 @@ import { nativeFileSystemSupported } from "../data/filesystem"; import type { NonDeletedExcalidrawElement } from "../element/types"; import { t } from "../i18n"; import { isSomeElementSelected } from "../scene"; -import { exportToCanvas } from "../../utils/export"; import { copyIcon, downloadIcon, helpIcon } from "./icons"; import { Dialog } from "./Dialog"; @@ -36,6 +35,7 @@ import { FilledButton } from "./FilledButton"; import { cloneJSON } from "../utils"; import { prepareElementsForExport } from "../data"; import { useCopyStatus } from "../hooks/useCopiedIndicator"; +import { exportToCanvas } from "../scene/export"; const supportsContextFilters = "filter" in document.createElement("canvas").getContext("2d")!; diff --git a/packages/excalidraw/components/PublishLibrary.tsx b/packages/excalidraw/components/PublishLibrary.tsx index 4ea6188dd..c31695eb0 100644 --- a/packages/excalidraw/components/PublishLibrary.tsx +++ b/packages/excalidraw/components/PublishLibrary.tsx @@ -7,7 +7,6 @@ import { t } from "../i18n"; import Trans from "./Trans"; import type { LibraryItems, LibraryItem, UIAppState } from "../types"; -import { exportToCanvas, exportToSvg } from "../../utils/export"; import { COLOR_WHITE, EDITOR_LS_KEYS, @@ -25,6 +24,7 @@ import { ToolButton } from "./ToolButton"; import { EditorLocalStorage } from "../data/EditorLocalStorage"; import "./PublishLibrary.scss"; +import { exportToCanvas, exportToSvg } from "../scene/export"; interface PublishLibraryDataParams { authorName: string; diff --git a/packages/excalidraw/hooks/useLibraryItemSvg.ts b/packages/excalidraw/hooks/useLibraryItemSvg.ts index dc8cac3c9..dfacb1691 100644 --- a/packages/excalidraw/hooks/useLibraryItemSvg.ts +++ b/packages/excalidraw/hooks/useLibraryItemSvg.ts @@ -2,8 +2,8 @@ import { atom, useAtom } from "jotai"; import { useEffect, useState } from "react"; import { COLOR_PALETTE } from "../colors"; import { jotaiScope } from "../jotai"; -import { exportToSvg } from "../../utils/export"; import type { LibraryItem } from "../types"; +import { exportToSvg } from "../scene/export"; export type SvgCache = Map; diff --git a/packages/excalidraw/index.tsx b/packages/excalidraw/index.tsx index 5c55b759f..d97ae0db4 100644 --- a/packages/excalidraw/index.tsx +++ b/packages/excalidraw/index.tsx @@ -225,12 +225,6 @@ export { export { reconcileElements } from "./data/reconcile"; -export { - exportToBlob, - exportToSvg, - exportToClipboard, -} from "../utils/export"; - export { serializeAsJSON, serializeLibraryAsJSON } from "./data/json"; export { loadFromBlob, @@ -273,7 +267,12 @@ export { WelcomeScreen }; export { LiveCollaborationTrigger }; export { Stats } from "./components/Stats"; -export { exportToCanvas } from "./scene/export"; +export { + exportToCanvas, + exportToBlob, + exportToClipboard, + exportToSvg, +} from "./scene/export"; export { DefaultSidebar } from "./components/DefaultSidebar"; export { TTDDialog } from "./components/TTDDialog/TTDDialog"; diff --git a/packages/excalidraw/renderer/helpers.ts b/packages/excalidraw/renderer/helpers.ts index cae562bf4..50dffcda6 100644 --- a/packages/excalidraw/renderer/helpers.ts +++ b/packages/excalidraw/renderer/helpers.ts @@ -1,4 +1,4 @@ -import type { StaticCanvasAppState, AppState } from "../types"; +import type { AppState } from "../types"; import type { StaticCanvasRenderConfig } from "../scene/types"; diff --git a/packages/excalidraw/scene/export.ts b/packages/excalidraw/scene/export.ts index 3f53d3e3c..1111bce85 100644 --- a/packages/excalidraw/scene/export.ts +++ b/packages/excalidraw/scene/export.ts @@ -21,6 +21,7 @@ import { SVG_NS, THEME, THEME_FILTER, + MIME_TYPES, } from "../constants"; import { getDefaultAppState } from "../appState"; import { serializeAsJSON } from "../data/json"; @@ -28,14 +29,14 @@ import { getInitializedImageElements, updateImageCache, } from "../element/image"; -import { restoreAppState } from "../data/restore"; +import { restore, restoreAppState } from "../data/restore"; import { getElementsOverlappingFrame, getFrameLikeElements, getFrameLikeTitle, getRootElements, } from "../frame"; -import { newTextElement } from "../element"; +import { getNonDeletedElements, newTextElement } from "../element"; import { type Mutable } from "../utility-types"; import { newElementWith } from "../element/mutateElement"; import { isFrameLikeElement } from "../element/typeChecks"; @@ -43,6 +44,12 @@ import type { RenderableElementsMap } from "./types"; import { syncInvalidIndices } from "../fractionalIndex"; import { renderStaticScene } from "../renderer/staticScene"; import { Fonts } from "../fonts"; +import { encodePngMetadata } from "../data/image"; +import { + copyBlobToClipboardAsPng, + copyTextToSystemClipboard, + copyToClipboard, +} from "../clipboard"; const SVG_EXPORT_TAG = ``; @@ -153,9 +160,13 @@ const prepareElementsForRender = ({ return nextElements; }; +type ExportToCanvasAppState = Partial< + Omit +>; + export type ExportToCanvasData = { elements: readonly NonDeletedExcalidrawElement[]; - appState?: Partial>; + appState?: ExportToCanvasAppState; files: BinaryFiles | null; }; @@ -632,6 +643,18 @@ export const exportToCanvas = async ({ return canvas; }; +type ExportToSvgConfig = Pick< + ExportToCanvasConfig, + "canvasBackgroundColor" | "padding" | "theme" | "exportingFrame" +> & { + /** + * if true, all embeddables passed in will be rendered when possible. + */ + renderEmbeddables?: boolean; + skipInliningFonts?: true; + reuseImages?: boolean; +}; + export const exportToSvg = async ({ data, config, @@ -640,31 +663,28 @@ export const exportToSvg = async ({ elements: readonly NonDeletedExcalidrawElement[]; appState: { exportBackground: boolean; - exportPadding?: number; exportScale?: number; viewBackgroundColor: string; exportWithDarkMode?: boolean; exportEmbedScene?: boolean; frameRendering?: AppState["frameRendering"]; + gridModeEnabled?: boolean; }; files: BinaryFiles | null; }; - config?: { - /** - * if true, all embeddables passed in will be rendered when possible. - */ - renderEmbeddables?: boolean; - exportingFrame?: ExcalidrawFrameLikeElement | null; - skipInliningFonts?: true; - reuseImages?: boolean; - }; + config?: ExportToSvgConfig; }): Promise => { // clone const cfg = Object.assign({}, config); cfg.exportingFrame = cfg.exportingFrame ?? null; - const elements = data.elements; + const { elements: restoredElements } = restore( + { ...data, files: data.files || {} }, + null, + null, + ); + const elements = getNonDeletedElements(restoredElements); const frameRendering = getFrameRenderingConfig( cfg?.exportingFrame ?? null, @@ -672,13 +692,14 @@ export const exportToSvg = async ({ ); let { - exportPadding = DEFAULT_EXPORT_PADDING, exportWithDarkMode = false, viewBackgroundColor, exportScale = 1, exportEmbedScene, } = data.appState; + let padding = cfg.padding ?? 0; + const elementsForRender = prepareElementsForRender({ elements, exportingFrame: cfg.exportingFrame, @@ -687,7 +708,7 @@ export const exportToSvg = async ({ }); if (cfg.exportingFrame) { - exportPadding = 0; + padding = 0; } let metadata = ""; @@ -719,8 +740,8 @@ export const exportToSvg = async ({ : getRootElements(elementsForRender), ); - width += exportPadding * 2; - height += exportPadding * 2; + width += padding * 2; + height += padding * 2; // initialize SVG root const svgRoot = document.createElementNS(SVG_NS, "svg"); @@ -733,8 +754,8 @@ export const exportToSvg = async ({ svgRoot.setAttribute("filter", THEME_FILTER); } - const offsetX = -minX + exportPadding; - const offsetY = -minY + exportPadding; + const offsetX = -minX + padding; + const offsetY = -minY + padding; const frameElements = getFrameLikeElements(elements); @@ -830,3 +851,103 @@ export const getCanvasSize = ( return [minX, minY, width, height]; }; + +export { MIME_TYPES }; + +type ExportToBlobConfig = ExportToCanvasConfig & { + mimeType?: string; + quality?: number; +}; + +export const exportToBlob = async ({ + data, + config, +}: { + data: ExportToCanvasData; + config?: ExportToBlobConfig; +}): Promise => { + let { mimeType = MIME_TYPES.png, quality } = config || {}; + + if (mimeType === MIME_TYPES.png && typeof quality === "number") { + console.warn(`"quality" will be ignored for "${MIME_TYPES.png}" mimeType`); + } + + // typo in MIME type (should be "jpeg") + if (mimeType === "image/jpg") { + mimeType = MIME_TYPES.jpg; + } + + if (mimeType === MIME_TYPES.jpg && !config?.canvasBackgroundColor === false) { + console.warn( + `Defaulting "exportBackground" to "true" for "${MIME_TYPES.jpg}" mimeType`, + ); + config = { + ...config, + canvasBackgroundColor: data.appState?.viewBackgroundColor || COLOR_WHITE, + }; + } + + const canvas = await exportToCanvas({ data, config }); + + quality = quality ? quality : /image\/jpe?g/.test(mimeType) ? 0.92 : 0.8; + + return new Promise((resolve, reject) => { + canvas.toBlob( + async (blob) => { + if (!blob) { + return reject(new Error("couldn't export to blob")); + } + if ( + blob && + mimeType === MIME_TYPES.png && + data.appState?.exportEmbedScene + ) { + blob = await encodePngMetadata({ + blob, + metadata: serializeAsJSON( + // NOTE as long as we're using the Scene hack, we need to ensure + // we pass the original, uncloned elements when serializing + // so that we keep ids stable + data.elements, + data.appState, + data.files || {}, + "local", + ), + }); + } + resolve(blob); + }, + mimeType, + quality, + ); + }); +}; + +export const exportToClipboard = async ({ + type, + data, + config, +}: { + data: ExportToCanvasData; +} & ( + | { type: "png"; config?: ExportToBlobConfig } + | { type: "svg"; config?: ExportToSvgConfig } + | { type: "json"; config?: never } +)) => { + if (type === "svg") { + const svg = await exportToSvg({ + data: { + ...data, + appState: restoreAppState(data.appState, null), + }, + config, + }); + await copyTextToSystemClipboard(svg.outerHTML); + } else if (type === "png") { + await copyBlobToClipboardAsPng(exportToBlob({ data, config })); + } else if (type === "json") { + await copyToClipboard(data.elements, data.files); + } else { + throw new Error("Invalid export type"); + } +}; diff --git a/packages/excalidraw/tests/__snapshots__/export.test.tsx.snap b/packages/excalidraw/tests/__snapshots__/export.test.tsx.snap index 1ba16e2ee..4f020586a 100644 --- a/packages/excalidraw/tests/__snapshots__/export.test.tsx.snap +++ b/packages/excalidraw/tests/__snapshots__/export.test.tsx.snap @@ -1,7 +1,7 @@ // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html exports[`export > exporting svg containing transformed images > svg export output 1`] = ` -" +" @@ -10,5 +10,5 @@ exports[`export > exporting svg containing transformed images > svg export outpu - " + " `; diff --git a/packages/excalidraw/tests/scene/__snapshots__/export.test.ts.snap b/packages/excalidraw/tests/scene/__snapshots__/export.test.ts.snap index ee168ad2e..c76367213 100644 --- a/packages/excalidraw/tests/scene/__snapshots__/export.test.ts.snap +++ b/packages/excalidraw/tests/scene/__snapshots__/export.test.ts.snap @@ -2,10 +2,10 @@ exports[`exportToSvg > with a CJK font 1`] = ` @@ -57,7 +57,7 @@ exports[`exportToSvg > with a CJK font 1`] = ` with a CJK font 1`] = ` /> with a CJK font 1`] = ` /> with a CJK font 1`] = ` with a CJK font 1`] = ` with a CJK font 1`] = ` exports[`exportToSvg > with default arguments 1`] = ` @@ -186,7 +186,7 @@ exports[`exportToSvg > with default arguments 1`] = ` with default arguments 1`] = ` /> with default arguments 1`] = ` /> with default arguments 1`] = ` with elements that have a link 1`] = ` - " + " `; exports[`exportToSvg > with exportEmbedScene 1`] = ` " - eyJ2ZXJzaW9uIjoiMSIsImVuY29kaW5nIjoiYnN0cmluZyIsImNvbXByZXNzZWQiOnRydWUsImVuY29kZWQiOiJ4nO1WW2vbMFx1MDAxNH7vrzDaa1llJ2myvGXrLoWxwTIorPRBtY5tYVlyJTmXhfz3SvJiOV7Z81x1MDAxYeJcdTAwMDfD+c5Vn76DvbuIXCJktjWgeYRgk1x1MDAxMs6oXCJrdOnwXHUwMDE1KM2ksK7E21o2KvWRhTH1/OqKS5tQSG3mI4xxm1x1MDAwNFx1MDAxYypcdTAwMTBG27B7a0fRzr+th1GXurpTT99cdTAwMTdZyVx1MDAwNE2e0mr69Wbx+ZdP9UFcdTAwMWJcdTAwMWIzjsedvXXdR9POXjNqXG6LxVx1MDAxOHdYXHUwMDAxLC/MXHUwMDAwJFwi527WgGijZFx0XHUwMDFmJJfKXHLyXHUwMDA2+ye0fiRpmSvZXGJcdTAwMWFi4lx0IY9ZiMlcdTAwMTjnS7PlLVx1MDAwYiQtXHUwMDFhXHUwMDA1aNDh7jDiXHUwMDAw7/K0tCyHLNsyL1x1MDAwNGh9lCNrkjKzXHUwMDFknMrNV99Sz+5DmEqRXG5uXHUwMDFkvaLhvF9Y0D+Fj1x1MDAxY5Z7cEQj0ju+XHUwMDA2oL7bOL6eTN/hWedcdDqIXHUwMDEzPES/SeE1XHUwMDExx7NcdTAwMTnG42R6XHUwMDFk2uhcdTAwMWKrXHUwMDA248tmhGtcYlS7yT5cdTAwMDalXHUwMDFjTdfUlLRJgVxyzkQ5jLPqK1+ofVAzZaSSglwij+8vz1r837VcdTAwMTifrlx1MDAxNoFzVms4a/G1aDE5XS1cdTAwMWHYmN7FSWGW7Lfz9M7g0E+kYtzxPFx0JVxcqi0hXHUwMDE1y5kgPDqudYB//jvMWVx1MDAwYs5yR1x1MDAxY+KQ9VxcljvD7D9F5zayXHUwMDBl3tRORZhcdTAwMDD195VaXHUwMDFl4Esn97dJmJk0Rv5cdTAwMDDdXHUwMDFl0TNyXsJXsoSj81x1MDAxMnZLXHUwMDE4XHUwMDA2P6UltG8vXHUwMDE0ROp6aSyx1t2uJFoxWL9/QfSZf9yX1K+wXHUwMDEzPbhb2u0v9s9cdTAwMGXWRI8ifQ== + eyJ2ZXJzaW9uIjoiMSIsImVuY29kaW5nIjoiYnN0cmluZyIsImNvbXByZXNzZWQiOnRydWUsImVuY29kZWQiOiJ4nO1WW2vbMFx1MDAxOH3vrzDua1llJ2nSvGXrLoWxwTIobOxBtT7bwrLkSnIuXHUwMDBi+e+V5MZy3JDXQIhcdTAwMWZcZjrf/eh82JurIFxi9bqCcFx1MDAxYYSwSjCjROJleGPxXHUwMDA1SEVcdTAwMDU3ptidlahl4jxzravp7S1cdTAwMTMmIFx1MDAxN0pPXHUwMDA3XGKhJlxiXHUwMDE4lMC1Mm5/zTlcYjbubSyU2NDFk3z5OUtcdTAwMGLKSfySlOPvXHUwMDBms69/XFyoc1pcdTAwMTmfYTRsz2tbfTBuz0tKdG6wXGKhXHUwMDE2y4Fmue6BmGfM9upcdTAwMTGlpSjgk2BC2kaukXt86WecXHUwMDE0mVx1MDAxNDUn3idcdTAwMWFh/Jx6n5QyNtdr1rCAk7yWXHUwMDEw9io87Vrs4W2cXHUwMDEyhmVcdTAwMWZlSmY5XHUwMDA3pfZiRIVcdTAwMTOq172pbH/VI3Hs/vNdSVxcwqOll9eMdVx1MDAxM3PylnjPYLhcdTAwMDdLdIg74ytcdTAwMDDiqlxyo7vR+Fx1MDAxZU1ai9dBXHUwMDE0oz76Q3CniSiaTFx1MDAxMFx1MDAxYcbjO19GPVx1MDAxODVolzbFTIGn2nb2uaNcdTAwMTQ/S11cdTAwMTHchHguXHUwMDE45UV/XHUwMDA2o73iQOadllx0xaXgJHT49uaQXHUwMDEyKYnuL8I7kfCic1x1MDAxNVx1MDAxZTBGK1x1MDAwNceFXHUwMDE3o4vwTiS8+FxchadhpTvXJrie0//W0pnAol9wSZlleeRT2FCTQkiaUY5ZsJ9rXHUwMDA3/z7uZk8zRjNLW8gg7ZhcZnOamn+F1qxF5a2J6VxuU1x1MDAwZfL9hVx1MDAxYVx1MDAxZeBbK/ZcdTAwMGax71x1MDAxOdda/Fx1MDAwMtWM6Fx1MDAxODm+cdFl4060cYPLxr1tnG/7nDbOvFx1MDAxZLUhrqq5NsRcdTAwMWFzs3/hgsLy41x1MDAwMcmn7rHfSLevVvJg72izvdq+XHUwMDAybvIt4SJ9 - original textoriginal text" + original textoriginal text" `; diff --git a/packages/excalidraw/tests/scene/export.test.ts b/packages/excalidraw/tests/scene/export.test.ts index f7d4467fe..49f7d9eca 100644 --- a/packages/excalidraw/tests/scene/export.test.ts +++ b/packages/excalidraw/tests/scene/export.test.ts @@ -11,9 +11,15 @@ import { textFixture, } from "../fixtures/elementFixture"; import { API } from "../helpers/api"; -import { exportToCanvas, exportToSvg } from "../../../utils"; import { FONT_FAMILY, FRAME_STYLE } from "../../constants"; import { prepareElementsForExport } from "../../data"; +import { diagramFactory } from "../fixtures/diagramFixture"; +import { vi } from "vitest"; + +const DEFAULT_OPTIONS = { + exportBackground: false, + viewBackgroundColor: "#ffffff", +}; describe("exportToSvg", () => { const ELEMENT_HEIGHT = 100; @@ -46,11 +52,6 @@ describe("exportToSvg", () => { }, ] as NonDeletedExcalidrawElement[]; - const DEFAULT_OPTIONS = { - exportBackground: false, - viewBackgroundColor: "#ffffff", - }; - it("with default arguments", async () => { const svgElement = await exportUtils.exportToSvg({ data: { elements: ELEMENTS, appState: DEFAULT_OPTIONS, files: null }, @@ -127,7 +128,6 @@ describe("exportToSvg", () => { elements: ELEMENTS, appState: { ...DEFAULT_OPTIONS, - exportPadding: 0, }, files: null, }, @@ -149,7 +149,6 @@ describe("exportToSvg", () => { elements: ELEMENTS, appState: { ...DEFAULT_OPTIONS, - exportPadding: 0, exportScale: SCALE, }, files: null, @@ -226,7 +225,7 @@ describe("exporting frames", () => { }), ]; - const canvas = await exportToCanvas({ + const canvas = await exportUtils.exportToCanvas({ data: { elements, files: null, @@ -259,7 +258,7 @@ describe("exporting frames", () => { }), ]; - const canvas = await exportToCanvas({ + const canvas = await exportUtils.exportToCanvas({ data: { elements, files: null, @@ -302,8 +301,12 @@ describe("exporting frames", () => { y: 0, }); - const svg = await exportToSvg({ - data: { elements: [rectOverlapping, frame, frameChild], files: null }, + const svg = await exportUtils.exportToSvg({ + data: { + elements: [rectOverlapping, frame, frameChild], + files: null, + appState: DEFAULT_OPTIONS, + }, config: { padding: 0, exportingFrame: frame, @@ -347,8 +350,12 @@ describe("exporting frames", () => { y: 0, }); - const svg = await exportToSvg({ - data: { elements: [frameChild, frame, elementOutside], files: null }, + const svg = await exportUtils.exportToSvg({ + data: { + elements: [frameChild, frame, elementOutside], + files: null, + appState: DEFAULT_OPTIONS, + }, config: { padding: 0, exportingFrame: frame, @@ -416,8 +423,12 @@ describe("exporting frames", () => { true, ); - const svg = await exportToSvg({ - data: { elements: exportedElements, files: null }, + const svg = await exportUtils.exportToSvg({ + data: { + elements: exportedElements, + files: null, + appState: DEFAULT_OPTIONS, + }, config: { padding: 0, exportingFrame, @@ -462,10 +473,11 @@ describe("exporting frames", () => { false, ); - const svg = await exportToSvg({ + const svg = await exportUtils.exportToSvg({ data: { elements: exportedElements, files: null, + appState: DEFAULT_OPTIONS, }, config: { padding: 0, @@ -525,10 +537,11 @@ describe("exporting frames", () => { true, ); - const svg = await exportToSvg({ + const svg = await exportUtils.exportToSvg({ data: { elements: exportedElements, files: null, + appState: DEFAULT_OPTIONS, }, config: { padding: 0, @@ -549,3 +562,47 @@ describe("exporting frames", () => { }); }); }); + +describe("exportToBlob", async () => { + describe("mime type", () => { + it("should change image/jpg to image/jpeg", async () => { + const blob = await exportUtils.exportToBlob({ + data: { + ...diagramFactory(), + + appState: { + exportBackground: true, + }, + }, + config: { + getDimensions: (width, height) => ({ width, height, scale: 1 }), + // testing typo in MIME type (jpg → jpeg) + mimeType: "image/jpg", + }, + }); + expect(blob?.type).toBe(exportUtils.MIME_TYPES.jpg); + }); + it("should default to image/png", async () => { + const blob = await exportUtils.exportToBlob({ + data: diagramFactory(), + }); + expect(blob?.type).toBe(exportUtils.MIME_TYPES.png); + }); + + it("should warn when using quality with image/png", async () => { + const consoleSpy = vi + .spyOn(console, "warn") + .mockImplementationOnce(() => void 0); + await exportUtils.exportToBlob({ + data: diagramFactory(), + config: { + mimeType: exportUtils.MIME_TYPES.png, + quality: 1, + }, + }); + expect(consoleSpy).toHaveBeenCalledWith( + `"quality" will be ignored for "${exportUtils.MIME_TYPES.png}" mimeType`, + ); + }); + }); +}); diff --git a/packages/utils/export.test.ts b/packages/utils/export.test.ts deleted file mode 100644 index be0dca298..000000000 --- a/packages/utils/export.test.ts +++ /dev/null @@ -1,144 +0,0 @@ -import * as utils from "."; -import { diagramFactory } from "../excalidraw/tests/fixtures/diagramFixture"; -import { vi } from "vitest"; -import * as mockedSceneExportUtils from "../excalidraw/scene/export"; - -import { MIME_TYPES } from "../excalidraw/constants"; - -import { exportToCanvas } from "../excalidraw/scene/export"; -const exportToSvgSpy = vi.spyOn(mockedSceneExportUtils, "exportToSvg"); - -describe("exportToCanvas", async () => { - it("with default arguments", async () => { - const canvas = await exportToCanvas({ - data: diagramFactory({ elementOverrides: { width: 100, height: 100 } }), - }); - - expect(canvas.width).toBe(100); - expect(canvas.height).toBe(100); - }); - - it("when custom width and height", async () => { - const canvas = await exportToCanvas({ - data: { - ...diagramFactory({ elementOverrides: { width: 100, height: 100 } }), - }, - config: { - getDimensions: () => ({ width: 200, height: 200, scale: 1 }), - }, - }); - - expect(canvas.width).toBe(200); - expect(canvas.height).toBe(200); - }); -}); - -describe("exportToBlob", async () => { - describe("mime type", () => { - it("should change image/jpg to image/jpeg", async () => { - const blob = await utils.exportToBlob({ - data: { - ...diagramFactory(), - - appState: { - exportBackground: true, - }, - }, - config: { - getDimensions: (width, height) => ({ width, height, scale: 1 }), - // testing typo in MIME type (jpg → jpeg) - mimeType: "image/jpg", - }, - }); - expect(blob?.type).toBe(MIME_TYPES.jpg); - }); - it("should default to image/png", async () => { - const blob = await utils.exportToBlob({ - data: diagramFactory(), - }); - expect(blob?.type).toBe(MIME_TYPES.png); - }); - - it("should warn when using quality with image/png", async () => { - const consoleSpy = vi - .spyOn(console, "warn") - .mockImplementationOnce(() => void 0); - await utils.exportToBlob({ - data: diagramFactory(), - config: { - mimeType: MIME_TYPES.png, - quality: 1, - }, - }); - expect(consoleSpy).toHaveBeenCalledWith( - `"quality" will be ignored for "${MIME_TYPES.png}" mimeType`, - ); - }); - }); -}); - -describe("exportToSvg", () => { - const passedElements = () => exportToSvgSpy.mock.calls[0][0].data.elements; - const passedOptions = () => exportToSvgSpy.mock.calls[0][0].data.appState; - - afterEach(() => { - vi.clearAllMocks(); - }); - - it("with default arguments", async () => { - await utils.exportToSvg({ - data: diagramFactory({ - overrides: { appState: void 0 }, - }), - }); - - const passedOptionsWhenDefault = { - ...passedOptions(), - // To avoid varying snapshots - name: "name", - }; - expect(passedElements().length).toBe(3); - expect(passedOptionsWhenDefault).toMatchSnapshot(); - }); - - // FIXME the utils.exportToSvg no longer filters out deleted elements. - // It's already supposed to be passed non-deleted elements by we're not - // type-checking for it correctly. - it.skip("with deleted elements", async () => { - await utils.exportToSvg({ - data: diagramFactory({ - overrides: { appState: void 0 }, - elementOverrides: { isDeleted: true }, - }), - }); - - expect(passedElements().length).toBe(0); - }); - - it("with exportPadding", async () => { - await utils.exportToSvg({ - data: diagramFactory({ - overrides: { appState: { name: "diagram name" } }, - }), - config: { padding: 0 }, - }); - - expect(passedElements().length).toBe(3); - expect(passedOptions()).toEqual( - expect.objectContaining({ exportPadding: 0 }), - ); - }); - - it("with exportEmbedScene", async () => { - await utils.exportToSvg({ - data: diagramFactory({ - overrides: { - appState: { name: "diagram name", exportEmbedScene: true }, - }, - }), - }); - - expect(passedElements().length).toBe(3); - expect(passedOptions().exportEmbedScene).toBe(true); - }); -}); diff --git a/packages/utils/export.ts b/packages/utils/export.ts deleted file mode 100644 index 18c53af13..000000000 --- a/packages/utils/export.ts +++ /dev/null @@ -1,163 +0,0 @@ -import { - exportToCanvas as _exportToCanvas, - type ExportToCanvasConfig, - type ExportToCanvasData, - exportToSvg as _exportToSvg, -} from "../excalidraw/scene/export"; -import { restore } from "../excalidraw/data/restore"; -import { COLOR_WHITE, MIME_TYPES } from "../excalidraw/constants"; -import { encodePngMetadata } from "../excalidraw/data/image"; -import { serializeAsJSON } from "../excalidraw/data/json"; -import { - copyBlobToClipboardAsPng, - copyTextToSystemClipboard, - copyToClipboard, -} from "../excalidraw/clipboard"; -import { getNonDeletedElements } from "../excalidraw"; - -export { MIME_TYPES }; - -type ExportToBlobConfig = ExportToCanvasConfig & { - mimeType?: string; - quality?: number; -}; - -type ExportToSvgConfig = Pick< - ExportToCanvasConfig, - "canvasBackgroundColor" | "padding" | "theme" | "exportingFrame" -> & { - /** - * if true, all embeddables passed in will be rendered when possible. - */ - renderEmbeddables?: boolean; - skipInliningFonts?: true; - reuseImages?: boolean; -}; - -export const exportToCanvas = async ({ - data, - config, -}: { - data: ExportToCanvasData; - config?: ExportToCanvasConfig; -}) => { - return _exportToCanvas({ - data, - config, - }); -}; - -export const exportToBlob = async ({ - data, - config, -}: { - data: ExportToCanvasData; - config?: ExportToBlobConfig; -}): Promise => { - let { mimeType = MIME_TYPES.png, quality } = config || {}; - - if (mimeType === MIME_TYPES.png && typeof quality === "number") { - console.warn(`"quality" will be ignored for "${MIME_TYPES.png}" mimeType`); - } - - // typo in MIME type (should be "jpeg") - if (mimeType === "image/jpg") { - mimeType = MIME_TYPES.jpg; - } - - if (mimeType === MIME_TYPES.jpg && !config?.canvasBackgroundColor === false) { - console.warn( - `Defaulting "exportBackground" to "true" for "${MIME_TYPES.jpg}" mimeType`, - ); - config = { - ...config, - canvasBackgroundColor: data.appState?.viewBackgroundColor || COLOR_WHITE, - }; - } - - const canvas = await _exportToCanvas({ data, config }); - - quality = quality ? quality : /image\/jpe?g/.test(mimeType) ? 0.92 : 0.8; - - return new Promise((resolve, reject) => { - canvas.toBlob( - async (blob) => { - if (!blob) { - return reject(new Error("couldn't export to blob")); - } - if ( - blob && - mimeType === MIME_TYPES.png && - data.appState?.exportEmbedScene - ) { - blob = await encodePngMetadata({ - blob, - metadata: serializeAsJSON( - // NOTE as long as we're using the Scene hack, we need to ensure - // we pass the original, uncloned elements when serializing - // so that we keep ids stable - data.elements, - data.appState, - data.files || {}, - "local", - ), - }); - } - resolve(blob); - }, - mimeType, - quality, - ); - }); -}; - -export const exportToSvg = async ({ - data, - config, -}: { - data: ExportToCanvasData; - config?: ExportToSvgConfig; -}): Promise => { - const { elements: restoredElements, appState: restoredAppState } = restore( - { ...data, files: data.files || {} }, - null, - null, - ); - - const appState = { ...restoredAppState, exportPadding: config?.padding }; - const elements = getNonDeletedElements(restoredElements); - const files = data.files || {}; - - return _exportToSvg({ - data: { elements, appState, files }, - config: { - exportingFrame: config?.exportingFrame, - renderEmbeddables: config?.renderEmbeddables, - skipInliningFonts: config?.skipInliningFonts, - reuseImages: config?.reuseImages, - }, - }); -}; - -export const exportToClipboard = async ({ - type, - data, - config, -}: { - data: ExportToCanvasData; -} & ( - | { type: "png"; config?: ExportToBlobConfig } - | { type: "svg"; config?: ExportToSvgConfig } - | { type: "json"; config?: never } -)) => { - if (type === "svg") { - const svg = await exportToSvg({ data, config }); - await copyTextToSystemClipboard(svg.outerHTML); - } else if (type === "png") { - await copyBlobToClipboardAsPng(exportToBlob({ data, config })); - } else if (type === "json") { - await copyToClipboard(data.elements, data.files); - } else { - throw new Error("Invalid export type"); - } -}; diff --git a/packages/utils/index.ts b/packages/utils/index.ts index 9ba56da87..6809d45bf 100644 --- a/packages/utils/index.ts +++ b/packages/utils/index.ts @@ -1,4 +1,3 @@ -export * from "./export"; export * from "./withinBounds"; export * from "./bbox"; export { getCommonBounds } from "../excalidraw/element/bounds"; diff --git a/packages/utils/utils.unmocked.test.ts b/packages/utils/utils.unmocked.test.ts index cdf6b6bb5..fa2c1a806 100644 --- a/packages/utils/utils.unmocked.test.ts +++ b/packages/utils/utils.unmocked.test.ts @@ -1,6 +1,6 @@ import { decodePngMetadata, decodeSvgMetadata } from "../excalidraw/data/image"; import type { ImportedDataState } from "../excalidraw/data/types"; -import * as utils from "../utils"; +import { exportToBlob, exportToSvg } from "../excalidraw/scene/export"; import { API } from "../excalidraw/tests/helpers/api"; // NOTE this test file is using the actual API, unmocked. Hence splitting it @@ -15,13 +15,14 @@ describe("embedding scene data", () => { const sourceElements = [rectangle, ellipse]; - const svgNode = await utils.exportToSvg({ + const svgNode = await exportToSvg({ data: { elements: sourceElements, appState: { viewBackgroundColor: "#ffffff", gridModeEnabled: false, exportEmbedScene: true, + exportBackground: true, }, files: null, }, @@ -47,7 +48,7 @@ describe("embedding scene data", () => { const sourceElements = [rectangle, ellipse]; - const blob = await utils.exportToBlob({ + const blob = await exportToBlob({ data: { elements: sourceElements, appState: { diff --git a/yarn.lock b/yarn.lock index c67e3d8b2..a81a49970 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3887,11 +3887,6 @@ ansi-regex@^5.0.1: resolved "https://registry.yarnpkg.com/ansi-regex/-/ansi-regex-5.0.1.tgz#082cb2c89c9fe8659a311a53bd6a4dc5301db304" integrity sha512-quJQXlTSUGL2LH9SUXo8VwsY4soanhgo6LNSm84E1LBcE8s3O0wpdiRzyR9z/ZZJMlMWv37qOOb9pdJlMUEKFQ== -ansi-regex@^6.0.1: - version "6.1.0" - resolved "https://registry.yarnpkg.com/ansi-regex/-/ansi-regex-6.1.0.tgz#95ec409c69619d6cb1b8b34f14b660ef28ebd654" - integrity sha512-7HSX4QQb4CspciLpVFwyRe79O3xsIZDDLER21kERQ71oaPodF8jL725AgJMFAYbooIqolJoRLuM81SpeUkpkvA== - ansi-styles@^2.2.1: version "2.2.1" resolved "https://registry.yarnpkg.com/ansi-styles/-/ansi-styles-2.2.1.tgz#b432dd3358b634cf75e1e4664368240533c1ddbe" @@ -9638,7 +9633,7 @@ string-natural-compare@^3.0.1: resolved "https://registry.yarnpkg.com/string-natural-compare/-/string-natural-compare-3.0.1.tgz#7a42d58474454963759e8e8b7ae63d71c1e7fdf4" integrity sha512-n3sPwynL1nwKi3WJ6AIsClwBMa0zTi54fn2oLU6ndfTSIO05xaznjSf15PcBZU6FNWbmN5Q6cxT4V5hGvB4taw== -"string-width-cjs@npm:string-width@^4.2.0": +"string-width-cjs@npm:string-width@^4.2.0", string-width@^4.2.3: version "4.2.3" resolved "https://registry.yarnpkg.com/string-width/-/string-width-4.2.3.tgz#269c7117d27b05ad2e536830a8ec895ef9c6d010" integrity sha512-wKyQRQpjJ0sIp62ErSZdGsjMJWsap5oRNihHhu6G7JVO/9jIB6UyevL+tXuOqrng8j/cxKTWyWUwvSTriiZz/g== @@ -9656,15 +9651,6 @@ string-width@^4.1.0, string-width@^4.2.0: is-fullwidth-code-point "^3.0.0" strip-ansi "^6.0.0" -string-width@^4.2.3: - version "4.2.3" - resolved "https://registry.yarnpkg.com/string-width/-/string-width-4.2.3.tgz#269c7117d27b05ad2e536830a8ec895ef9c6d010" - integrity sha512-wKyQRQpjJ0sIp62ErSZdGsjMJWsap5oRNihHhu6G7JVO/9jIB6UyevL+tXuOqrng8j/cxKTWyWUwvSTriiZz/g== - dependencies: - emoji-regex "^8.0.0" - is-fullwidth-code-point "^3.0.0" - strip-ansi "^6.0.1" - string-width@^5.0.0, string-width@^5.0.1, string-width@^5.1.2: version "5.1.2" resolved "https://registry.yarnpkg.com/string-width/-/string-width-5.1.2.tgz#14f8daec6d81e7221d2a357e668cab73bdbca794" @@ -9736,34 +9722,13 @@ stringify-object@^3.3.0: is-obj "^1.0.1" is-regexp "^1.0.0" -"strip-ansi-cjs@npm:strip-ansi@^6.0.1": +"strip-ansi-cjs@npm:strip-ansi@^6.0.1", strip-ansi@6.0.1, strip-ansi@^3.0.0, strip-ansi@^6.0.0, strip-ansi@^6.0.1, strip-ansi@^7.0.1: version "6.0.1" resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-6.0.1.tgz#9e26c63d30f53443e9489495b2105d37b67a85d9" integrity sha512-Y38VPSHcqkFrCpFnQ9vuSXmquuv5oXOKpGeT6aGrr3o3Gc9AlVa6JBfUSOCnbxGGZF+/0ooI7KrPuUSztUdU5A== dependencies: ansi-regex "^5.0.1" -strip-ansi@^3.0.0: - version "3.0.1" - resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-3.0.1.tgz#6a385fb8853d952d5ff05d0e8aaf94278dc63dcf" - integrity sha512-VhumSSbBqDTP8p2ZLKj40UjBCV4+v8bUSEpUb4KjRgWk9pbqGF4REFj6KEagidb2f/M6AzC0EmFyDNGaw9OCzg== - dependencies: - ansi-regex "^2.0.0" - -strip-ansi@^6.0.0, strip-ansi@^6.0.1: - version "6.0.1" - resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-6.0.1.tgz#9e26c63d30f53443e9489495b2105d37b67a85d9" - integrity sha512-Y38VPSHcqkFrCpFnQ9vuSXmquuv5oXOKpGeT6aGrr3o3Gc9AlVa6JBfUSOCnbxGGZF+/0ooI7KrPuUSztUdU5A== - dependencies: - ansi-regex "^5.0.1" - -strip-ansi@^7.0.1: - version "7.1.0" - resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-7.1.0.tgz#d5b6568ca689d8561370b0707685d22434faff45" - integrity sha512-iq6eVVI64nQQTRYq2KtEg2d2uU7LElhTJwsH4YzIHZshxlgZms/wIc4VoDQTlG/IvVIrBKG06CrZnp0qv7hkcQ== - dependencies: - ansi-regex "^6.0.1" - strip-bom@^3.0.0: version "3.0.0" resolved "https://registry.yarnpkg.com/strip-bom/-/strip-bom-3.0.0.tgz#2334c18e9c759f7bdd56fdef7e9ae3d588e68ed3" @@ -10994,7 +10959,7 @@ workbox-window@7.1.0, workbox-window@^7.0.0: "@types/trusted-types" "^2.0.2" workbox-core "7.1.0" -"wrap-ansi-cjs@npm:wrap-ansi@^7.0.0": +"wrap-ansi-cjs@npm:wrap-ansi@^7.0.0", wrap-ansi@^7.0.0: version "7.0.0" resolved "https://registry.yarnpkg.com/wrap-ansi/-/wrap-ansi-7.0.0.tgz#67e145cff510a6a6984bdf1152911d69d2eb9e43" integrity sha512-YVGIj2kamLSTxw6NsZjoBxfSwsn0ycdesmc4p+Q21c5zPuZ1pl+NfxVdxPtdHvmNVOQ6XSYG4AUtyt/Fi7D16Q== @@ -11012,15 +10977,6 @@ wrap-ansi@^6.2.0: string-width "^4.1.0" strip-ansi "^6.0.0" -wrap-ansi@^7.0.0: - version "7.0.0" - resolved "https://registry.yarnpkg.com/wrap-ansi/-/wrap-ansi-7.0.0.tgz#67e145cff510a6a6984bdf1152911d69d2eb9e43" - integrity sha512-YVGIj2kamLSTxw6NsZjoBxfSwsn0ycdesmc4p+Q21c5zPuZ1pl+NfxVdxPtdHvmNVOQ6XSYG4AUtyt/Fi7D16Q== - dependencies: - ansi-styles "^4.0.0" - string-width "^4.1.0" - strip-ansi "^6.0.0" - wrap-ansi@^8.1.0: version "8.1.0" resolved "https://registry.yarnpkg.com/wrap-ansi/-/wrap-ansi-8.1.0.tgz#56dc22368ee570face1b49819975d9b9a5ead214"