From 113dfc0023c31673f1a070123e198b94b180666d Mon Sep 17 00:00:00 2001
From: Ryan Di <ryan.weihao.di@gmail.com>
Date: Thu, 5 Dec 2024 15:13:42 +0800
Subject: [PATCH] remove cover from fit options

---
 excalidraw-app/App.tsx              |  2 --
 packages/excalidraw/scene/export.ts | 19 +------------------
 2 files changed, 1 insertion(+), 20 deletions(-)

diff --git a/excalidraw-app/App.tsx b/excalidraw-app/App.tsx
index 7d1c13c69e..4198b61b33 100644
--- a/excalidraw-app/App.tsx
+++ b/excalidraw-app/App.tsx
@@ -681,7 +681,6 @@ const ExcalidrawWrapper = () => {
           //   // scale: 0.01,
           //   // scale: 2,
           //   // origin: "content",
-          //   // fit: "cover",
           //   // scale: 2,
           //   // x: 0,
           //   // y: 0,
@@ -1270,7 +1269,6 @@ const ExcalidrawWrapper = () => {
               >
                 <option value="none">none</option>
                 <option value="contain">contain</option>
-                <option value="cover">cover</option>
               </select>
             </label>
             <label>
diff --git a/packages/excalidraw/scene/export.ts b/packages/excalidraw/scene/export.ts
index 1111bce85e..5ddd319dc9 100644
--- a/packages/excalidraw/scene/export.ts
+++ b/packages/excalidraw/scene/export.ts
@@ -197,8 +197,6 @@ export type ExportToCanvasConfig = {
    * order to maintain the aspect ratio. It is recommended to set `position`
    * to `center` when using `fit=contain`.
    *
-   * When `fit` is set to `cover`, padding is disabled (set to 0).
-   *
    * When `fit` is set to `none` and either `width` or `height` or
    * `maxWidthOrHeight` is set, padding is simply adding to the bounding box
    * and the content may overflow the canvas, thus right or bottom padding
@@ -279,8 +277,6 @@ export type ExportToCanvasConfig = {
    *
    * - `none`    - no scaling.
    * - `contain` - scale to fit the frame. Includes `padding`.
-   * - `cover`   - scale to fill the frame while maintaining aspect ratio. If
-   *               content overflows, it will be cropped.
    *
    * If `maxWidthOrHeight` or `widthOrHeight` is set, `fit` is ignored.
    *
@@ -288,7 +284,7 @@ export type ExportToCanvasConfig = {
    * `widthOrHeight` is specified in which case `none` is the default (can be
    * changed). If `x` or `y` are specified, `none` is forced.
    */
-  fit?: "none" | "contain" | "cover";
+  fit?: "none" | "contain";
   /**
    * When either `x` or `y` are not specified, indicates how the canvas should
    * be aligned on the respective axis.
@@ -399,13 +395,6 @@ export const exportToCanvas = async ({
     cfg.fit = "none";
   }
 
-  if (cfg.fit === "cover") {
-    if (cfg.padding && !import.meta.env.PROD) {
-      console.warn("`padding` is ignored when `fit` is set to `cover`");
-    }
-    cfg.padding = 0;
-  }
-
   cfg.padding = cfg.padding ?? 0;
   cfg.scale = cfg.scale ?? 1;
 
@@ -536,12 +525,6 @@ export const exportToCanvas = async ({
       const hRatio = (height - cfg.padding * 2) / height;
       canvasScale = Math.min(wRatio, hRatio);
     }
-  } else if (cfg.fit === "cover") {
-    const wRatio = width / origWidth;
-    const hRatio = height / origHeight;
-    // scale the orig canvas to fill the the target frame
-    // (opposite of "contain")
-    canvasScale = Math.max(wRatio, hRatio);
   }
 
   x = cfg.x ?? origX;