support show the summary of kafka metadata.

pull/510/head
winlin 9 years ago
parent d013374871
commit f0e39cc330

@ -2128,6 +2128,8 @@ int SrsConfig::global_to_json(SrsJsonObject* obj)
sobj->set(sdir->name, sdir->dumps_arg0_to_boolean());
} else if (sdir->name == "brokers") {
sobj->set(sdir->name, sdir->dumps_args());
} else if (sdir->name == "topic") {
sobj->set(sdir->name, sdir->dumps_arg0_to_str());
}
}
obj->set(dir->name, sobj);
@ -3546,7 +3548,7 @@ int SrsConfig::check_config()
SrsConfDirective* conf = root->get("kafka");
for (int i = 0; conf && i < (int)conf->directives.size(); i++) {
string n = conf->at(i)->name;
if (n != "enabled" && n != "brokers") {
if (n != "enabled" && n != "brokers" && n != "topic") {
ret = ERROR_SYSTEM_CONFIG_INVALID;
srs_error("unsupported kafka directive %s, ret=%d", n.c_str(), ret);
return ret;

@ -32,6 +32,7 @@ using namespace std;
#include <srs_app_async_call.hpp>
#include <srs_app_utility.hpp>
#include <srs_kernel_utility.hpp>
#include <srs_protocol_utility.hpp>
#include <srs_kernel_balance.hpp>
#include <srs_kafka_stack.hpp>
#include <srs_core_autofree.hpp>
@ -201,6 +202,48 @@ int SrsKafkaProducer::request_metadata()
}
SrsAutoFree(SrsKafkaTopicMetadataResponse, metadata);
// show kafka metadata.
string summary;
if (true) {
vector<string> bs;
for (int i = 0; i < metadata->brokers.size(); i++) {
SrsKafkaBroker* broker = metadata->brokers.at(i);
string hostport = srs_int2str(broker->node_id) + "/" + broker->host.to_str();
if (broker->port > 0) {
hostport += ":" + srs_int2str(broker->port);
}
bs.push_back(hostport);
}
vector<string> ps;
for (int i = 0; i < metadata->metadatas.size(); i++) {
SrsKafkaTopicMetadata* topic = metadata->metadatas.at(i);
string desc = "topic=" + topic->name.to_str();
for (int j = 0; j < topic->metadatas.size(); j++) {
SrsKafkaPartitionMetadata* partition = topic->metadatas.at(j);
desc += ", partition" + srs_int2str(partition->partition_id) +"=";
desc += srs_int2str(partition->leader) + "/";
vector<string> replicas = srs_kafka_array2vector(&partition->replicas);
desc += srs_join_vector_string(replicas, ",");
}
ps.push_back(desc);
}
std::stringstream ss;
ss << "brokers=" << srs_join_vector_string(bs, ",");
ss << ", " << srs_join_vector_string(ps, ",");
summary = ss.str();
}
srs_trace("kafka metadata: %s", summary.c_str());
meatadata_ok = true;
return ret;

@ -1467,17 +1467,3 @@ void srs_api_dump_summaries(SrsJsonObject* obj)
sys->set("conn_srs", SrsJsonAny::integer(nrs->nb_conn_srs));
}
string srs_join_vector_string(vector<string>& vs, string separator)
{
string str = "";
for (int i = 0; i < (int)vs.size(); i++) {
str += vs.at(i);
if (i != (int)vs.size() - 1) {
str += separator;
}
}
return str;
}

@ -677,8 +677,5 @@ extern bool srs_is_boolean(const std::string& str);
// dump summaries for /api/v1/summaries.
extern void srs_api_dump_summaries(SrsJsonObject* obj);
// join string in vector with indicated separator
extern std::string srs_join_vector_string(std::vector<std::string>& vs, std::string separator);
#endif

@ -23,7 +23,7 @@
#include <srs_kafka_stack.hpp>
#include <string>
#include <sstream>
using namespace std;
#include <srs_kernel_error.hpp>
@ -31,6 +31,8 @@ using namespace std;
#include <srs_kernel_log.hpp>
#include <srs_protocol_io.hpp>
#include <srs_protocol_stream.hpp>
#include <srs_kernel_utility.hpp>
#include <srs_protocol_utility.hpp>
#ifdef SRS_AUTO_KAFKA
@ -64,6 +66,15 @@ bool SrsKafkaString::empty()
return _size <= 0;
}
string SrsKafkaString::to_str()
{
string ret;
if (_size > 0) {
ret.append(data, _size);
}
return ret;
}
int SrsKafkaString::nb_bytes()
{
return _size == -1? 2 : 2 + _size;
@ -1077,8 +1088,24 @@ int SrsKafkaClient::fetch_metadata(string topic, SrsKafkaTopicMetadataResponse**
vector<string> srs_kafka_array2vector(SrsKafkaArray<SrsKafkaString>* arr)
{
vector<string> strs;
for (int i = 0; i < arr->nb_bytes(); i++) {
for (int i = 0; i < arr->size(); i++) {
SrsKafkaString* elem = arr->at(i);
strs.push_back(elem->to_str());
}
return strs;
}
vector<string> srs_kafka_array2vector(SrsKafkaArray<int32_t>* arr)
{
vector<string> strs;
for (int i = 0; i < arr->size(); i++) {
int32_t elem = arr->at(i);
strs.push_back(srs_int2str(elem));
}
return strs;
}

@ -77,6 +77,7 @@ public:
public:
virtual bool null();
virtual bool empty();
virtual std::string to_str();
// interface ISrsCodec
public:
virtual int nb_bytes();
@ -147,6 +148,14 @@ public:
length++;
elems.push_back(elem);
}
virtual int size()
{
return length;
}
virtual T* at(int index)
{
return elems.at(index);
}
// interface ISrsCodec
public:
virtual int nb_bytes()
@ -228,6 +237,14 @@ public:
length++;
elems.push_back(elem);
}
virtual int size()
{
return length;
}
virtual int32_t at(int index)
{
return elems.at(index);
}
// interface ISrsCodec
public:
virtual int nb_bytes()
@ -792,6 +809,7 @@ public:
// convert kafka array[string] to vector[string]
extern std::vector<std::string> srs_kafka_array2vector(SrsKafkaArray<SrsKafkaString>* arr);
extern std::vector<std::string> srs_kafka_array2vector(SrsKafkaArray<int32_t>* arr);
#endif

@ -312,3 +312,17 @@ int srs_write_large_iovs(ISrsProtocolReaderWriter* skt, iovec* iovs, int size, s
return ret;
}
string srs_join_vector_string(vector<string>& vs, string separator)
{
string str = "";
for (int i = 0; i < (int)vs.size(); i++) {
str += vs.at(i);
if (i != (int)vs.size() - 1) {
str += separator;
}
}
return str;
}

@ -35,6 +35,7 @@ CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
#endif
#include <string>
#include <vector>
#include <srs_kernel_consts.hpp>
@ -130,5 +131,8 @@ extern int srs_write_large_iovs(
ssize_t* pnwrite = NULL
);
// join string in vector with indicated separator
extern std::string srs_join_vector_string(std::vector<std::string>& vs, std::string separator);
#endif

Loading…
Cancel
Save