From c2a667cc35c11d43a7b27e70d4a5cdc027202ff4 Mon Sep 17 00:00:00 2001 From: winlin Date: Mon, 16 Mar 2020 22:01:09 +0800 Subject: [PATCH] For #1638, #307, add comments for api and enum --- trunk/src/app/srs_app_http_api.cpp | 1 + trunk/src/app/srs_app_rtc_conn.hpp | 1 + trunk/src/app/srs_app_source.cpp | 1 - trunk/src/app/srs_app_source.hpp | 1 + 4 files changed, 3 insertions(+), 1 deletion(-) diff --git a/trunk/src/app/srs_app_http_api.cpp b/trunk/src/app/srs_app_http_api.cpp index c7b779556..0d3a787ff 100644 --- a/trunk/src/app/srs_app_http_api.cpp +++ b/trunk/src/app/srs_app_http_api.cpp @@ -818,6 +818,7 @@ srs_error_t SrsGoApiSdp::serve_http(ISrsHttpResponseWriter* w, ISrsHttpMessage* string app = app_obj->to_str(); string stream_name = stream_name_obj->to_str(); + // TODO: FIXME: It seems remote_sdp doesn't represents the full SDP information. SrsSdp remote_sdp; err = remote_sdp.decode(remote_sdp_str); if (err != srs_success) { diff --git a/trunk/src/app/srs_app_rtc_conn.hpp b/trunk/src/app/srs_app_rtc_conn.hpp index d0db07e36..cf03ea3bd 100644 --- a/trunk/src/app/srs_app_rtc_conn.hpp +++ b/trunk/src/app/srs_app_rtc_conn.hpp @@ -110,6 +110,7 @@ private: enum SrsRtcSessionStateType { + // TODO: FIXME: Should prefixed by enum name. INIT = -1, WAITING_STUN = 1, DOING_DTLS_HANDSHAKE = 2, diff --git a/trunk/src/app/srs_app_source.cpp b/trunk/src/app/srs_app_source.cpp index 2ef7824a1..48716296d 100755 --- a/trunk/src/app/srs_app_source.cpp +++ b/trunk/src/app/srs_app_source.cpp @@ -327,7 +327,6 @@ srs_error_t SrsMessageQueue::dump_packets(int max_count, SrsSharedPtrMessage** p return err; } - srs_error_t SrsMessageQueue::dump_packets(SrsConsumer* consumer, bool atc, SrsRtmpJitterAlgorithm ag) { srs_error_t err = srs_success; diff --git a/trunk/src/app/srs_app_source.hpp b/trunk/src/app/srs_app_source.hpp index 814119556..083bf3e02 100644 --- a/trunk/src/app/srs_app_source.hpp +++ b/trunk/src/app/srs_app_source.hpp @@ -325,6 +325,7 @@ public: virtual SrsSharedPtrMessage* pop(); }; +// To find the RTP packet for RTX or restore. class SrsRtpPacketQueue { private: