From 9ee0ed919a5ed1c1d5980c48189f09e90ed3dd1f Mon Sep 17 00:00:00 2001
From: winlin <winlin@vip.126.com>
Date: Sat, 27 Feb 2021 23:10:46 +0800
Subject: [PATCH] RTC: No cache for RTP packet size.

---
 trunk/src/kernel/srs_kernel_rtc_rtp.cpp | 18 ++----------------
 trunk/src/kernel/srs_kernel_rtc_rtp.hpp |  3 ---
 2 files changed, 2 insertions(+), 19 deletions(-)

diff --git a/trunk/src/kernel/srs_kernel_rtc_rtp.cpp b/trunk/src/kernel/srs_kernel_rtc_rtp.cpp
index 3e2d12677..eb770735c 100644
--- a/trunk/src/kernel/srs_kernel_rtc_rtp.cpp
+++ b/trunk/src/kernel/srs_kernel_rtc_rtp.cpp
@@ -854,7 +854,6 @@ SrsRtpPacket2::SrsRtpPacket2()
 
     nalu_type = SrsAvcNaluTypeReserved;
     frame_type = SrsFrameTypeReserved;
-    cached_payload_size = 0;
     decode_handler = NULL;
 
     ++_srs_pps_objs_rtps->sugar;
@@ -870,7 +869,6 @@ void SrsRtpPacket2::reset()
 {
     nalu_type = SrsAvcNaluTypeReserved;
     frame_type = SrsFrameTypeReserved;
-    cached_payload_size = 0;
     decode_handler = NULL;
 
     // It's important to reset the header.
@@ -931,8 +929,6 @@ cleanup:
 
 bool SrsRtpPacket2::recycle()
 {
-    // Clear the cache size, it may change when reuse it.
-    cached_payload_size = 0;
     // Reset the handler, for decode only.
     decode_handler = NULL;
 
@@ -1015,7 +1011,6 @@ SrsRtpPacket2* SrsRtpPacket2::copy()
     cp->frame_type = frame_type;
 
     // For performance issue, do not copy the unused field.
-    //cp->cached_payload_size = cached_payload_size;
     //cp->decode_handler = decode_handler;
 
     return cp;
@@ -1024,17 +1019,11 @@ SrsRtpPacket2* SrsRtpPacket2::copy()
 void SrsRtpPacket2::set_padding(int size)
 {
     header.set_padding(size);
-    if (cached_payload_size) {
-        cached_payload_size += size - header.get_padding();
-    }
 }
 
 void SrsRtpPacket2::add_padding(int size)
 {
     header.set_padding(header.get_padding() + size);
-    if (cached_payload_size) {
-        cached_payload_size += size;
-    }
 }
 
 void SrsRtpPacket2::set_decode_handler(ISrsRtpPacketDecodeHandler* h)
@@ -1054,11 +1043,8 @@ void SrsRtpPacket2::set_extension_types(SrsRtpExtensionTypes* v)
 
 uint64_t SrsRtpPacket2::nb_bytes()
 {
-    if (!cached_payload_size) {
-        int nn_payload = (payload_? payload_->nb_bytes():0);
-        cached_payload_size = header.nb_bytes() + nn_payload + header.get_padding();
-    }
-    return cached_payload_size;
+    int nn_payload = (payload_? payload_->nb_bytes():0);
+    return header.nb_bytes() + nn_payload + header.get_padding();
 }
 
 srs_error_t SrsRtpPacket2::encode(SrsBuffer* buf)
diff --git a/trunk/src/kernel/srs_kernel_rtc_rtp.hpp b/trunk/src/kernel/srs_kernel_rtc_rtp.hpp
index ec4b44a99..1c119e0bc 100644
--- a/trunk/src/kernel/srs_kernel_rtc_rtp.hpp
+++ b/trunk/src/kernel/srs_kernel_rtc_rtp.hpp
@@ -315,10 +315,7 @@ public:
     SrsAvcNaluType nalu_type;
     // The frame type, for RTMP bridger or SFU source.
     SrsFrameType frame_type;
-// Fast cache for performance.
 private:
-    // The cached payload size for packet.
-    int cached_payload_size;
     // The helper handler for decoder, use RAW payload if NULL.
     ISrsRtpPacketDecodeHandler* decode_handler;
 public: