From 70d561421c583e5f3ee1e0b6455e6a0c2c79dd67 Mon Sep 17 00:00:00 2001 From: winlin Date: Wed, 5 Aug 2020 18:06:54 +0800 Subject: [PATCH] RTC: Check error for send_rtcp_fb_pli --- trunk/src/app/srs_app_rtc_conn.cpp | 5 +---- trunk/src/app/srs_app_rtc_source.cpp | 7 +++++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/trunk/src/app/srs_app_rtc_conn.cpp b/trunk/src/app/srs_app_rtc_conn.cpp index 9f3894599..e7ff1a8d3 100644 --- a/trunk/src/app/srs_app_rtc_conn.cpp +++ b/trunk/src/app/srs_app_rtc_conn.cpp @@ -2226,10 +2226,7 @@ srs_error_t SrsRtcConnection::send_rtcp_fb_pli(uint32_t ssrc) return srs_error_wrap(err, "protect rtcp psfb pli"); } - // TDOO: FIXME: Check error. - sendonly_skt->sendto(protected_buf, nb_protected_buf, 0); - - return err; + return sendonly_skt->sendto(protected_buf, nb_protected_buf, 0); } void SrsRtcConnection::simulate_nack_drop(int nn) diff --git a/trunk/src/app/srs_app_rtc_source.cpp b/trunk/src/app/srs_app_rtc_source.cpp index d4648b0c3..9f37932ad 100644 --- a/trunk/src/app/srs_app_rtc_source.cpp +++ b/trunk/src/app/srs_app_rtc_source.cpp @@ -1704,8 +1704,11 @@ srs_error_t SrsRtcVideoRecvTrack::on_rtp(SrsRtcStream* source, SrsRtpPacket2* pk if (request_key_frame_) { // TODO: FIXME: add coroutine to request key frame. request_key_frame_ = false; - // TODO: FIXME: Check error. - session_->send_rtcp_fb_pli(track_desc_->ssrc_); + + if ((err = session_->send_rtcp_fb_pli(track_desc_->ssrc_)) != srs_success) { + srs_warn("PLI err %s", srs_error_desc(err).c_str()); + srs_freep(err); + } } // For NACK to handle packet.