RTC: Fix parse error stap playload crash bug

trunk/src/kernel/srs_kernel_rtc_rtp.cpp

@@ -994,6 +994,14 @@ srs_error_t SrsRtpSTAPPayload::decode(SrsBuffer* buf)
     // STAP header, RTP payload format for aggregation packets
     // @see https://tools.ietf.org/html/rfc6184#section-5.7
     uint8_t v = buf->read_1bytes();
+
+    // forbidden_zero_bit shoul be zero.
+    // @see https://tools.ietf.org/html/rfc6184#section-5.3
+    uint8_t f = (v & 0x80);
+    if (f == 0x80) {
+        return srs_error_new(ERROR_RTC_RTP_MUXER, "forbidden_zero_bit should be zero");
+    }
+
     nri = SrsAvcNaluType(v & (~kNalTypeMask));
 
     // NALUs.

trunk/src/utest/srs_utest_rtc.cpp

@@ -37,6 +37,58 @@ CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #include <vector>
 using namespace std;
 
+VOID TEST(KernelRTCTest, RtpSTAPPayloadException)
+{
+    srs_error_t err = srs_success;
+
+    unsigned char rtp_pkt[328] = {
+        0x90, 0xe0, 0x65, 0x8d, 0x37, 0xbc, 0x20, 0xb7, 0xd8, 0xf7, 0xae, 0x77, 0xbe, 0xde, 0x00, 0x03,
+        0x51, 0x06, 0x4f, 0xd5, 0x2f, 0x0e, 0xe1, 0x90, 0x75, 0xc3, 0x00, 0x00, 0xd8, 0x01, 0x00, 0x03,
+        0xef, 0x93, 0xc7, 0x6a, 0x23, 0x45, 0xdc, 0xb0, 0xce, 0x2b, 0x51, 0x1a, 0x8a, 0xd1, 0x35, 0xab,
+        0x11, 0xa7, 0x15, 0xc4, 0xd6, 0xe4, 0x5d, 0x12, 0x6c, 0x04, 0x86, 0x25, 0xd3, 0x88, 0x76, 0xa2,
+        0xb8, 0x58, 0x47, 0x0d, 0x0a, 0xd6, 0x2b, 0x85, 0x04, 0x6a, 0x09, 0x2a, 0x4a, 0xce, 0x22, 0xa2,
+        0x05, 0x78, 0x8e, 0x71, 0x5c, 0x22, 0x23, 0x58, 0x9e, 0x16, 0x15, 0xe1, 0x5f, 0xff, 0xfd, 0x32,
+        0x0a, 0xe2, 0xb8, 0xea, 0xd6, 0xba, 0xd5, 0x7e, 0x5a, 0xd6, 0x61, 0x1c, 0x82, 0x38, 0xce, 0x4a,
+        0xd7, 0xe2, 0xea, 0xaa, 0xab, 0xa8, 0x83, 0xf6, 0x7f, 0x10, 0xf1, 0x7c, 0x55, 0x4d, 0xeb, 0xaa,
+        0xf8, 0xfd, 0x35, 0xaa, 0xeb, 0x59, 0x8e, 0xf8, 0x8f, 0x12, 0xb9, 0xdd, 0x39, 0xfa, 0x3f, 0x62,
+        0x9e, 0x23, 0x96, 0xab, 0x5e, 0xc4, 0xce, 0x97, 0x55, 0x43, 0x65, 0x29, 0xde, 0x8f, 0xe2, 0xb9,
+        0x0f, 0xb8, 0xd0, 0xee, 0x00, 0x31, 0x35, 0xdb, 0x5a, 0xff, 0xff, 0xf8, 0x10, 0xa9, 0x3c, 0xf7,
+        0x90, 0x8c, 0xf7, 0x3f, 0x5f, 0xd7, 0x15, 0xac, 0xee, 0xa8, 0xfe, 0x23, 0x84, 0x8b, 0xe6, 0x97,
+        0x2a, 0x61, 0x38, 0xba, 0xd3, 0xee, 0x7b, 0x49, 0xfa, 0x81, 0xcb, 0x3f, 0x72, 0xd5, 0x56, 0x8f,
+        0xe7, 0x7b, 0x1d, 0xda, 0x85, 0x71, 0xbc, 0x45, 0x75, 0x5d, 0x55, 0x47, 0xc5, 0xf5, 0x36, 0xe4,
+        0xa9, 0x17, 0x4a, 0x84, 0xf9, 0xdd, 0xd0, 0xa5, 0xb1, 0xcf, 0x69, 0xcf, 0xcd, 0x1d, 0xac, 0xe4,
+        0xc6, 0x3d, 0xd0, 0x95, 0xa3, 0xbd, 0x0a, 0xd4, 0xa2, 0xb9, 0x05, 0x78, 0xae, 0x5a, 0x92, 0xb5,
+        0x90, 0x4b, 0xa6, 0x85, 0x3c, 0x27, 0xb3, 0x4d, 0xd2, 0x5c, 0xfa, 0x61, 0x01, 0x4a, 0xa6, 0xd9,
+        0x26, 0xf3, 0x78, 0x44, 0x57, 0x2e, 0x79, 0xc5, 0x71, 0x42, 0xb5, 0x34, 0x87, 0x94, 0x57, 0x8a,
+        0xe1, 0x09, 0xb3, 0x8a, 0xe7, 0x0b, 0x7f, 0xfc, 0xff, 0xec, 0x28, 0xe3, 0x4c, 0xff, 0xff, 0xa6,
+        0x6a, 0xca, 0x2b, 0x84, 0xab, 0x0a, 0xd7, 0xf1, 0xf5, 0x9a, 0x47, 0x08, 0x54, 0xd5, 0xac, 0x9a,
+        0xf5, 0x09, 0x5a, 0x29, 0x35, 0x52, 0x79, 0xe0,
+    };
+
+    int nb_buf = sizeof(rtp_pkt);
+    SrsBuffer buf((char*)rtp_pkt, nb_buf);
+
+    SrsRtpHeader header;
+    EXPECT_TRUE((err = header.decode(&buf)) == srs_success);
+
+    // We must skip the padding bytes before parsing payload.
+    uint8_t padding = header.get_padding();
+    EXPECT_TRUE(buf.require(padding));
+    buf.set_size(buf.size() - padding);
+
+    SrsAvcNaluType nalu_type = SrsAvcNaluTypeReserved;
+    // Try to parse the NALU type for video decoder.
+    if (!buf.empty()) {
+        nalu_type = SrsAvcNaluType((uint8_t)(buf.head()[0] & kNalTypeMask));
+    }
+
+    EXPECT_TRUE(nalu_type == kStapA);
+    ISrsRtpPayloader* payload = new SrsRtpSTAPPayload();
+
+    EXPECT_TRUE((err = payload->decode(&buf)) != srs_success);
+    srs_freep(payload);
+}
+
 class MockResource : public ISrsDisposingHandler, public ISrsResource
 {
 public: