Polish spring-cloud-incubator/spring-cloud-alibaba#591

6 years ago · d3d1172508
parent 49c6fedfe4
commit d3d1172508
1 changed files with 5 additions and 2 deletions
--- a/spring-cloud-alibaba-dubbo/src/main/java/org/springframework/cloud/alibaba/dubbo/metadata/repository/DubboServiceMetadataRepository.java
+++ b/spring-cloud-alibaba-dubbo/src/main/java/org/springframework/cloud/alibaba/dubbo/metadata/repository/DubboServiceMetadataRepository.java
@ -293,9 +293,12 @@ public class DubboServiceMetadataRepository {

    public void unexportURL(URL url) {
        String key = url.getServiceKey();
+        // NPE issue : https://github.com/spring-cloud-incubator/spring-cloud-alibaba/issues/591
        List<URL> urls = allExportedURLs.get(key);
-        urls.remove(url);
-        this.allExportedURLs.addAll(key, urls);
+        if (!isEmpty(urls)) {
+            urls.remove(url);
+            allExportedURLs.addAll(key, urls);
+        }
    }

    /**