From c6e7b851378973ef69775958623cd392805786c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=91=A8=E7=AB=8B?= Date: Thu, 27 Jun 2019 10:15:47 +0800 Subject: [PATCH] fix NPE fix NPE --- .../cloud/alibaba/nacos/ribbon/NacosRule.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/spring-cloud-alibaba-nacos-discovery/src/main/java/org/springframework/cloud/alibaba/nacos/ribbon/NacosRule.java b/spring-cloud-alibaba-nacos-discovery/src/main/java/org/springframework/cloud/alibaba/nacos/ribbon/NacosRule.java index 50a6f9161..fd4f4a9db 100644 --- a/spring-cloud-alibaba-nacos-discovery/src/main/java/org/springframework/cloud/alibaba/nacos/ribbon/NacosRule.java +++ b/spring-cloud-alibaba-nacos-discovery/src/main/java/org/springframework/cloud/alibaba/nacos/ribbon/NacosRule.java @@ -36,10 +36,13 @@ public class NacosRule extends AbstractLoadBalancerRule { String name = loadBalancer.getName(); NamingService namingService = this.nacosDiscoveryProperties.namingServiceInstance(); - List instances = namingService.selectInstances(name, true); - List instancesToChoose = instances; + if (CollectionUtils.isEmpty(instances)) { + log.warn("{}服务当前无任何实例", name); + return null; + } + List instancesToChoose = instances; if (StringUtils.isNotBlank(clusterName)) { List sameClusterInstances = instances.stream() .filter(instance -> Objects.equals(clusterName, instance.getClusterName())) @@ -63,4 +66,4 @@ public class NacosRule extends AbstractLoadBalancerRule { @Override public void initWithNiwsConfig(IClientConfig iClientConfig) { } -} \ No newline at end of file +}