From 0e388707352bcda94a41d67100e28c0a2eaa10fc Mon Sep 17 00:00:00 2001 From: horizonzy <1060026287@qq.com> Date: Mon, 21 Dec 2020 22:06:17 +0800 Subject: [PATCH 1/5] fix nacos heart beat unit, second to millisecond. --- .../alibaba/cloud/nacos/registry/NacosRegistration.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/main/java/com/alibaba/cloud/nacos/registry/NacosRegistration.java b/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/main/java/com/alibaba/cloud/nacos/registry/NacosRegistration.java index 75912ca45..151f7ed82 100644 --- a/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/main/java/com/alibaba/cloud/nacos/registry/NacosRegistration.java +++ b/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/main/java/com/alibaba/cloud/nacos/registry/NacosRegistration.java @@ -19,6 +19,7 @@ package com.alibaba.cloud.nacos.registry; import java.net.URI; import java.util.List; import java.util.Map; +import java.util.concurrent.TimeUnit; import javax.annotation.PostConstruct; @@ -99,15 +100,15 @@ public class NacosRegistration implements Registration, ServiceInstance { if (null != nacosDiscoveryProperties.getHeartBeatInterval()) { metadata.put(PreservedMetadataKeys.HEART_BEAT_INTERVAL, - nacosDiscoveryProperties.getHeartBeatInterval().toString()); + String.valueOf(TimeUnit.SECONDS.toMillis(nacosDiscoveryProperties.getHeartBeatInterval()))); } if (null != nacosDiscoveryProperties.getHeartBeatTimeout()) { metadata.put(PreservedMetadataKeys.HEART_BEAT_TIMEOUT, - nacosDiscoveryProperties.getHeartBeatTimeout().toString()); + String.valueOf(TimeUnit.SECONDS.toMillis(nacosDiscoveryProperties.getHeartBeatTimeout()))); } if (null != nacosDiscoveryProperties.getIpDeleteTimeout()) { metadata.put(PreservedMetadataKeys.IP_DELETE_TIMEOUT, - nacosDiscoveryProperties.getIpDeleteTimeout().toString()); + String.valueOf(TimeUnit.SECONDS.toMillis(nacosDiscoveryProperties.getIpDeleteTimeout()))); } customize(registrationCustomizers, this); } From 802958b21880acffa9e8902710ea41b96f698795 Mon Sep 17 00:00:00 2001 From: horizonzy <1060026287@qq.com> Date: Wed, 23 Dec 2020 09:51:42 +0800 Subject: [PATCH 2/5] Revert "fix nacos heart beat unit, second to millisecond." This reverts commit 0e388707 --- .../alibaba/cloud/nacos/registry/NacosRegistration.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/main/java/com/alibaba/cloud/nacos/registry/NacosRegistration.java b/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/main/java/com/alibaba/cloud/nacos/registry/NacosRegistration.java index 151f7ed82..75912ca45 100644 --- a/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/main/java/com/alibaba/cloud/nacos/registry/NacosRegistration.java +++ b/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/main/java/com/alibaba/cloud/nacos/registry/NacosRegistration.java @@ -19,7 +19,6 @@ package com.alibaba.cloud.nacos.registry; import java.net.URI; import java.util.List; import java.util.Map; -import java.util.concurrent.TimeUnit; import javax.annotation.PostConstruct; @@ -100,15 +99,15 @@ public class NacosRegistration implements Registration, ServiceInstance { if (null != nacosDiscoveryProperties.getHeartBeatInterval()) { metadata.put(PreservedMetadataKeys.HEART_BEAT_INTERVAL, - String.valueOf(TimeUnit.SECONDS.toMillis(nacosDiscoveryProperties.getHeartBeatInterval()))); + nacosDiscoveryProperties.getHeartBeatInterval().toString()); } if (null != nacosDiscoveryProperties.getHeartBeatTimeout()) { metadata.put(PreservedMetadataKeys.HEART_BEAT_TIMEOUT, - String.valueOf(TimeUnit.SECONDS.toMillis(nacosDiscoveryProperties.getHeartBeatTimeout()))); + nacosDiscoveryProperties.getHeartBeatTimeout().toString()); } if (null != nacosDiscoveryProperties.getIpDeleteTimeout()) { metadata.put(PreservedMetadataKeys.IP_DELETE_TIMEOUT, - String.valueOf(TimeUnit.SECONDS.toMillis(nacosDiscoveryProperties.getIpDeleteTimeout()))); + nacosDiscoveryProperties.getIpDeleteTimeout().toString()); } customize(registrationCustomizers, this); } From 447171de80cd5b1ea3eb87b4b29d0f4d5db2386a Mon Sep 17 00:00:00 2001 From: horizonzy <1060026287@qq.com> Date: Wed, 23 Dec 2020 10:09:26 +0800 Subject: [PATCH 3/5] modify the heart beat doc unit. second -> millisecond --- .../com/alibaba/cloud/nacos/NacosDiscoveryProperties.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/main/java/com/alibaba/cloud/nacos/NacosDiscoveryProperties.java b/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/main/java/com/alibaba/cloud/nacos/NacosDiscoveryProperties.java index 3ee047b4f..632448dbd 100644 --- a/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/main/java/com/alibaba/cloud/nacos/NacosDiscoveryProperties.java +++ b/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/main/java/com/alibaba/cloud/nacos/NacosDiscoveryProperties.java @@ -183,17 +183,17 @@ public class NacosDiscoveryProperties { private String secretKey; /** - * Heart beat interval. Time unit: second. + * Heart beat interval. Time unit: millisecond. */ private Integer heartBeatInterval; /** - * Heart beat timeout. Time unit: second. + * Heart beat timeout. Time unit: millisecond. */ private Integer heartBeatTimeout; /** - * Ip delete timeout. Time unit: second. + * Ip delete timeout. Time unit: millisecond. */ private Integer ipDeleteTimeout; From 71036479a1ac3f84d04d2fdc81faff178f3dc88b Mon Sep 17 00:00:00 2001 From: horizonzy <1060026287@qq.com> Date: Wed, 23 Dec 2020 12:58:09 +0800 Subject: [PATCH 4/5] update test heart beat param value --- .../nacos/registry/NacosAutoServiceRegistrationTests.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/test/java/com/alibaba/cloud/nacos/registry/NacosAutoServiceRegistrationTests.java b/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/test/java/com/alibaba/cloud/nacos/registry/NacosAutoServiceRegistrationTests.java index 9ae2cff93..3da9899c9 100644 --- a/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/test/java/com/alibaba/cloud/nacos/registry/NacosAutoServiceRegistrationTests.java +++ b/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/test/java/com/alibaba/cloud/nacos/registry/NacosAutoServiceRegistrationTests.java @@ -69,9 +69,9 @@ import static org.springframework.boot.test.context.SpringBootTest.WebEnvironmen "spring.cloud.nacos.discovery.accessKey=test-accessKey", "spring.cloud.nacos.discovery.ip=8.8.8.8", "spring.cloud.nacos.discovery.secretKey=test-secretKey", - "spring.cloud.nacos.discovery.heart-beat-interval=3", - "spring.cloud.nacos.discovery.heart-beat-timeout=6", - "spring.cloud.nacos.discovery.ip-delete-timeout=9" }, + "spring.cloud.nacos.discovery.heart-beat-interval=3000", + "spring.cloud.nacos.discovery.heart-beat-timeout=6000", + "spring.cloud.nacos.discovery.ip-delete-timeout=9000" }, webEnvironment = RANDOM_PORT) public class NacosAutoServiceRegistrationTests { From 076a1648a25553e43a3bbd20a51c87e4721e0ce2 Mon Sep 17 00:00:00 2001 From: horizonzy <1060026287@qq.com> Date: Wed, 23 Dec 2020 13:08:49 +0800 Subject: [PATCH 5/5] update test heart beat param value --- .../nacos/registry/NacosAutoServiceRegistrationTests.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/test/java/com/alibaba/cloud/nacos/registry/NacosAutoServiceRegistrationTests.java b/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/test/java/com/alibaba/cloud/nacos/registry/NacosAutoServiceRegistrationTests.java index 3da9899c9..1fbac697f 100644 --- a/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/test/java/com/alibaba/cloud/nacos/registry/NacosAutoServiceRegistrationTests.java +++ b/spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/test/java/com/alibaba/cloud/nacos/registry/NacosAutoServiceRegistrationTests.java @@ -186,15 +186,15 @@ public class NacosAutoServiceRegistrationTests { } private void checkoutNacosDiscoveryHeartBeatInterval() { - assertThat(properties.getHeartBeatInterval()).isEqualTo(Integer.valueOf(3)); + assertThat(properties.getHeartBeatInterval()).isEqualTo(Integer.valueOf(3000)); } private void checkoutNacosDiscoveryHeartBeatTimeout() { - assertThat(properties.getHeartBeatTimeout()).isEqualTo(Integer.valueOf(6)); + assertThat(properties.getHeartBeatTimeout()).isEqualTo(Integer.valueOf(6000)); } private void checkoutNacosDiscoveryIpDeleteTimeout() { - assertThat(properties.getIpDeleteTimeout()).isEqualTo(Integer.valueOf(9)); + assertThat(properties.getIpDeleteTimeout()).isEqualTo(Integer.valueOf(9000)); } private void checkoutNacosDiscoveryServiceName() {