Before this change snabbdom could only be consumed by bundlers like webpack.
Now we add the `.js` extension to the build outputs so browsers can import the modules directly as well.
ISSUES FIXED: #963
The benchmark code was not yet updated to version 3 of snabbdom and
thus cannot be run at the moment. Further, it depends on faker, which is
not available any more. So for now, the benchmark code and all its
dependencies have been removed. In the future we should again add
benchmarks and can reference this commit for some code.
The environment was used to ensure that the browserstack access keys
are only available after approval, so a potentially malicious actor
can't modify the testing code and extract those secrets. This however
creates a lot of noise in the notifications of the maintainers and it
drastically reduces the feedback cycle for the contributor in case their
change causes an issue in one of the supported browsers. Additionally
the potential harm in extracting the access keys is pretty low. The
snabbdombot account has only user access, so it can't change
browserstack settings and it can only access the automate features. So
the only thing that can happen is that our PRs fail because some third
party is running browser tests and thus exhausting our 5 parallel tests
limit. In that case we can simply change the access key of the
snabbdombot account. For this reason, the secrets are now repository
secrets and the CI does not need an approval to run
release-it automates all the steps defined in CONTRIBUTING.md. In
addition to that it can also create GitHub releases with the relevant
part of the CHANGELOG
Now that we use prettier, we can automatically format the README
anyways. The only difference then would be the automatic table of
contents, but the structure of the README does not change often and is
not very complex, so there is not really a need to automate this
commitlint can't provide the user with a convenient prompt to create a
fitting commit message, while commitizen is not able to lint an existing
commit message. The newly released commithelper does both
Simon Friis Vindum
Jan van Brügge
iambumblehead
Michael Reinstein
Jan van Brügge
dependabot[bot]
shanyue
Shahar Or (mightyiam)
Renovate Bot