chore: tsconfig noImplicitThis true

pull/618/head
Shahar Or (mightyiam) 5 years ago committed by Shahar Dawn Or
parent 238e7fc49e
commit 3b65f77c6f

@ -151,8 +151,8 @@ describe('event listeners', function () {
assert.strictEqual(5, called);
});
it('access to virtual node in event handler', function () {
var result: VNode[] = [];
function clicked (ev: Event, vnode: VNode) {
var result: Array<VNode | HTMLElement> = [];
function clicked (this: HTMLElement, ev: Event, vnode: VNode) {
result.push(this);
result.push(vnode);
}
@ -166,8 +166,8 @@ describe('event listeners', function () {
assert.strictEqual(vnode1, result[1]);
});
it('access to virtual node in event handler with argument', function () {
var result: Array<VNode | Event> = [];
function clicked (arg: number, ev: Event, vnode: VNode) {
var result: Array<VNode | HTMLElement> = [];
function clicked (this: HTMLElement, arg: number, ev: Event, vnode: VNode) {
result.push(this);
result.push(vnode);
}
@ -181,8 +181,8 @@ describe('event listeners', function () {
assert.strictEqual(vnode1, result[1]);
});
it('access to virtual node in event handler with arguments', function () {
var result: Array<VNode | Event> = [];
function clicked (arg1: number, arg2: string, ev: Event, vnode: VNode) {
var result: Array<VNode | HTMLElement> = [];
function clicked (this: HTMLElement, arg1: number, arg2: string, ev: Event, vnode: VNode) {
result.push(this);
result.push(vnode);
}

@ -3,7 +3,6 @@
"compilerOptions": {
"strictFunctionTypes": false,
"strictBindCallApply": false,
"noImplicitThis": false,
"target": "ES5",
"jsx": "react",
"jsxFactory": "jsx",

Loading…
Cancel
Save